Re: [lisp] Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10
Luigi Iannone <ggx@gigix.net> Wed, 27 April 2022 11:31 UTC
Return-Path: <ggx@gigix.net>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5252CC07C444 for <lisp@ietfa.amsl.com>; Wed, 27 Apr 2022 04:31:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gigix-net.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id saIq1qAXd50H for <lisp@ietfa.amsl.com>; Wed, 27 Apr 2022 04:31:49 -0700 (PDT)
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0582C239029 for <lisp@ietf.org>; Wed, 27 Apr 2022 04:31:49 -0700 (PDT)
Received: by mail-wm1-x32e.google.com with SMTP id 129so991821wmz.0 for <lisp@ietf.org>; Wed, 27 Apr 2022 04:31:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gigix-net.20210112.gappssmtp.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AaCEuey68ZR49WnWaTgk57xNhDuuv1e0/qH7SgfVkko=; b=qYhi7o9xFJnofSaF9lxCuerHeDiUg4BlTbF1gjcuEGsVmzULvQSYyf0rwEBBeZrxcC fUp0EoiRr+0QDnQaJy+gllga45x7lZzcE9oYnnRzVTcf9iXhADl/dcEJIzZcwCOt9v0Z 6XpxERqpixPNlIAaoCavqSLy0khItCYzxvXEf3NLhGtxjZtxIK+gQbgkDLoduld7Pxf9 14aOd2HtHIKGkqkveUJqtjZwd96HWjOeZzT/Py7k+iH3jKoXiDiJNpFcE9DnWVj5dq43 ZNXMA1KF5xHpsMCOopyEqXxdyQNQRgeGgcn9Hv7SnX6aGrTfNLtZV9CQ7GjE6I2oKlvO m7Dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AaCEuey68ZR49WnWaTgk57xNhDuuv1e0/qH7SgfVkko=; b=HZYR6FiBLJcKFAYicWI6h+HbMxkGHTqge9ktMRE7H8cZKdqMzu88Ig7UgPNX+lkyqe sdvgOdass2EybmqQHRdSMklHDTQtn2cnfWFN/U/tUYpWrjUO75vLulOzA0yE5gSOcoVN Nbv7BWb8xHMrFMylKLmUA4UNd1NBvokbjeFOlvwRWuz29gBlYB9VckaF5k5VQSEk7x5R hJmklVSaB+jKz2EDGTbjfXfya36rAx4OOQqjiTpYAhXbHu/lQbibtCWvW0mBfeK2N+Wv TNGL7cbQ90UVzC0fK33mnoqf/Gi7ICT5v9Av46Lp5K6VKUSns7DBOanBGnWi7TuYu+n2 Fcew==
X-Gm-Message-State: AOAM532uzxQlnIeG+Er7fQQCu/tpnhZIqn8tHQqEr+B458yO4gJ5U7ec 0bbHdq7TZBL8N2m5ztjkbSmiDA==
X-Google-Smtp-Source: ABdhPJxFznLYZF7Xsb8cbzzIqrdPbLgl2TZoiaut5X1ZeSQ/ydZY4x/mGUe1L3JyTEp0VME+vP8owQ==
X-Received: by 2002:a05:600c:6d3:b0:38e:c692:d50a with SMTP id b19-20020a05600c06d300b0038ec692d50amr34669552wmn.30.1651059107684; Wed, 27 Apr 2022 04:31:47 -0700 (PDT)
Received: from smtpclient.apple ([37.171.140.136]) by smtp.gmail.com with ESMTPSA id az30-20020a05600c601e00b0038ebd950caesm1381746wmb.30.2022.04.27.04.31.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Apr 2022 04:31:46 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
From: Luigi Iannone <ggx@gigix.net>
In-Reply-To: <CAP7zK5bL0ZOjw_93Q1OSe_nyVELUhs3PFZwBMcqbC6QMcVGuMg@mail.gmail.com>
Date: Wed, 27 Apr 2022 13:31:43 +0200
Cc: Dino Farinacci <farinacci@gmail.com>, "Alberto Rodriguez-Natal (natal)" <natal@cisco.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-lisp-vendor-lcaf.all@ietf.org" <draft-ietf-lisp-vendor-lcaf.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lisp@ietf.org" <lisp@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0F77FADF-2408-4855-AD9E-58164AFFA744@gigix.net>
References: <165098180257.525.977533583517805963@ietfa.amsl.com> <BYAPR11MB3591085FFE95328E988F8334B6FB9@BYAPR11MB3591.namprd11.prod.outlook.com> <31ABB7B9-239C-4D19-8257-81211B76E868@gmail.com> <CAP7zK5bL0ZOjw_93Q1OSe_nyVELUhs3PFZwBMcqbC6QMcVGuMg@mail.gmail.com>
To: Dhruv Dhody <dd@dhruvdhody.com>
X-Mailer: Apple Mail (2.3696.80.82.1.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/o8_BJEkn2WaiLt3TRYVlIfJZoAE>
Subject: Re: [lisp] Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2022 11:31:55 -0000
Hi Dhruv, Indeed in 8060 the length unit is one single byte, hence there is no need of padding. Thanks for your review. Ciao L. > On 27 Apr 2022, at 05:48, Dhruv Dhody <dd@dhruvdhody.com> wrote: > > Hi Dino, > > In some protocols that I am aware of, it is usual to state that the > variable-length portion in the TLVs/objects is 4-byte aligned. But looking > at RFC 8060, I see that LISP does not follow this approach for any of the > LCAF and it works just fine without it. I agree with you that no change is > required then. Thanks for taking my comment into consideration. > > Thanks! > Dhruv > > On Wed, Apr 27, 2022 at 3:19 AM Dino Farinacci <farinacci@gmail.com> wrote: > >> Dhruv, can you explain more specifically what you mean by padding? Since >> any LCAF encoding (even a vendor LCAF) has a length field, the encoding can >> be the exact number of bytes described by the length. So no padding is >> required. >> >> Or did you mean something else? >> >> Dino >> >>> On Apr 26, 2022, at 7:49 AM, Alberto Rodriguez-Natal (natal) < >> natal@cisco.com> wrote: >>> >>> Hi Dhruv, >>> >>> Thanks for your review! You’re bringing good points. >>> >>> As per your comment on padding, it’s a good question but I cannot recall >> right now any padding requirement in other LISP docs. A a quick search for >> ‘padding' in rfc6833bis and RFC8060 shows not results. Maybe someone else >> on the list can comment on padding requirements in LISP (if any)? >>> >>> Also, good point on expanding LISP on first use, we’ll make sure to do >> so in the revised draft. >>> >>> Thanks! >>> Alberto >>> >>> From: Dhruv Dhody via Datatracker <noreply@ietf.org> >>> Date: Tuesday, April 26, 2022 at 4:03 PM >>> To: rtg-dir@ietf.org <rtg-dir@ietf.org> >>> Cc: draft-ietf-lisp-vendor-lcaf.all@ietf.org < >> draft-ietf-lisp-vendor-lcaf.all@ietf.org>, last-call@ietf.org < >> last-call@ietf.org>, lisp@ietf.org<lisp@ietf.org> >>> Subject: Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10 >>> >>> Reviewer: Dhruv Dhody >>> Review result: Has Issues >>> >>> I was assigned the reviewer today. I noticed that the IESG ballot is >> done and >>> the document is approved, I am not sure how valuable this review would >> be but >>> anyways... >>> >>> Hello, >>> >>> I have been selected as the Routing Directorate reviewer for this draft
- [lisp] Rtgdir last call review of draft-ietf-lisp… Dhruv Dhody via Datatracker
- Re: [lisp] Rtgdir last call review of draft-ietf-… Alberto Rodriguez-Natal (natal)
- Re: [lisp] Rtgdir last call review of draft-ietf-… Dino Farinacci
- Re: [lisp] Rtgdir last call review of draft-ietf-… Dhruv Dhody
- Re: [lisp] Rtgdir last call review of draft-ietf-… Dino Farinacci
- Re: [lisp] Rtgdir last call review of draft-ietf-… Luigi Iannone
- Re: [lisp] Rtgdir last call review of draft-ietf-… Alberto Rodriguez-Natal (natal)
- Re: [lisp] [RTG-DIR] Rtgdir last call review of d… Dhruv Dhody
- Re: [lisp] [RTG-DIR] Rtgdir last call review of d… Alberto Rodriguez-Natal (natal)