[lisp] Re: Review draft-ietf-lisp-te

Luigi Iannone <ggx@gigix.net> Mon, 13 May 2024 11:58 UTC

Return-Path: <ggx@gigix.net>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E8ACC180B57 for <lisp@ietfa.amsl.com>; Mon, 13 May 2024 04:58:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gigix-net.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KXaBxUtD0CyT for <lisp@ietfa.amsl.com>; Mon, 13 May 2024 04:58:33 -0700 (PDT)
Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC0E7C169423 for <lisp@ietf.org>; Mon, 13 May 2024 04:58:33 -0700 (PDT)
Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-420180b5897so4584215e9.3 for <lisp@ietf.org>; Mon, 13 May 2024 04:58:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gigix-net.20230601.gappssmtp.com; s=20230601; t=1715601511; x=1716206311; darn=ietf.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=tKVeiqEzjpQ8fH3qCbETF0vAcDJW58g5PKb53S3Wo7o=; b=eMmhM6EkeN8EtkvmVZLFohJXekjQIrGCCCjddgXRB7g4D9DKCnTky4Qg9aQgRmAuug CI1oVPX9C/3tJSOzOys9yDePM1kosk8wOONGTjbi6dLHYPrpUvnLgBDs/0Akl+aPid2U 9Zj7AJWfmhFAOTCEEBR8+42xTyLqHp/z43XAC+N2hEMdHL6jDkGWK8A688nNHY+Gfxuq HSCJdgddPFX80ZBlihTYagYMv6NOfxXBAXg6kGg/amunuEh8diM4rNhVFq2XqtST/pEw nbFfBLQp6da25AK/jW3Ntx7QJahFMl7jt5mSQWGq2xxcIfylEDgZ6Aa11p0rfPTZkiko 3WSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715601511; x=1716206311; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tKVeiqEzjpQ8fH3qCbETF0vAcDJW58g5PKb53S3Wo7o=; b=upYKsckp+4NtuEKAyAfgTluJDjc1LDcMALOIeh9e5pIYdwYqyIhugtbDYaOS7rwZ+o 4LyT6S5JCVi2BjhVbtOicOFNcbDX2V/MYmafdkiKdlpISdZfQgYQmD7Bm7SUCCzKoUan 5lZFrSdLTjeVAhIUt8GfqV7ZYrpEOsF72KCfeKYMZhrKvzYRoIHdDdQfPdDOxMD6dkGS QZ5fO6VfX7A+OMAvybCMeOdkSJTARc70mhpTe7AkMT4lct2YSGRLqSGXWAm4viMINDDp COIZK1mNoURIUo5lQQgnvZize51kgmu1JPD6c2QjFxq1082Dv742+g3/z6J7ABnkJZbL ufKw==
X-Gm-Message-State: AOJu0YyXStRGMAjYLhF+F1o6VZ8ZXt0WOgXL1mCXtyvqU9E3SXHjooJz DsA8IWOo8iYqLPJfMMna2ghD4ouMHXHAlWq5gJgxS099sMaN5+U2fiCDuoNag3ky4eR2gfnoxJS zdN0=
X-Google-Smtp-Source: AGHT+IFrg7DTfXCvy/u3cpsR+mFoqT9Pve9sp7loTr9g/H1qpmOVqwhT138m/tR5D+D9OKfJovr53g==
X-Received: by 2002:a05:600c:1d21:b0:41b:97c5:ccc7 with SMTP id 5b1f17b1804b1-41fea9320bbmr62062815e9.8.1715601511551; Mon, 13 May 2024 04:58:31 -0700 (PDT)
Received: from smtpclient.apple (91-167-176-17.subs.proxad.net. [91.167.176.17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccfe1527sm152876155e9.44.2024.05.13.04.58.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2024 04:58:31 -0700 (PDT)
From: Luigi Iannone <ggx@gigix.net>
Message-Id: <3CD7999A-2BBC-4C21-9D7F-AE4256466140@gigix.net>
Content-Type: multipart/alternative; boundary="Apple-Mail=_245BB7B9-A7B5-407A-B26D-0DC7764B2E27"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Date: Mon, 13 May 2024 13:58:00 +0200
In-Reply-To: <5069882E-D7F8-48D5-86FC-2BA095A95D55@gmail.com>
To: Dino Farinacci <farinacci@gmail.com>
References: <261E2219-4B13-43EE-AF78-C470826C28DF@gigix.net> <5069882E-D7F8-48D5-86FC-2BA095A95D55@gmail.com>
X-Mailer: Apple Mail (2.3774.500.171.1.1)
Message-ID-Hash: JIQGXD4WKVI5ZROP3M67R7B4MAM2E6OI
X-Message-ID-Hash: JIQGXD4WKVI5ZROP3M67R7B4MAM2E6OI
X-MailFrom: ggx@gigix.net
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-lisp.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: LISP mailing list list <lisp@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [lisp] Re: Review draft-ietf-lisp-te
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/zujFy04v2g0Y8oVuUIIqa7QMvO8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Owner: <mailto:lisp-owner@ietf.org>
List-Post: <mailto:lisp@ietf.org>
List-Subscribe: <mailto:lisp-join@ietf.org>
List-Unsubscribe: <mailto:lisp-leave@ietf.org>


> On 7 May 2024, at 16:36, Dino Farinacci <farinacci@gmail.com> wrote:
> 
> 
>> The text still assumes that an ELP must be returned.
> 
> That is correct.
> 
>> 
>> Just replace the words:
>> 
>>   “which returns a ELP-based locator record for a path to RTR 'y', and encapsulates packets…"
> 
> The example is illustrating nesting so I believe it is not needed.

I understand the example, but the text is a bit misleading because seems to suggest that lookup _must_ return an ELP. 
Anyway, in the last revision is already better.  


> 
>>>>> Luigi, the terms are used in self contained sections. They are fine. S-EID is ONLY used in the multicast section because the is the convention we use to look up a multicast mapping (S-EID, G-EID).
>> 
>> I think a unique term makes more sense, but this is not a blocking point.
> 
> It is a unique term. The term S-EID is used in all the multicast drafts to describe an (S,G).

Fine.

> 
>> This is exactly the point. I do not see an alternate path. I see only an alternate tunnel.
>> The current text is still confusing. You want "to route around the path from B to C” and to do it you route "through link B—>C”. This looks like a contradiction to me.
> 
> B and C have other links. Don’t you see the link between B and X. That is “another” path.

But the figure has no “other path” in it. I added one in my first review but you did not like it.

The text:

if it is desirable to route around the path from B to C through link B-->C, 

Still look like a contradiction. Furthermore, in figure 1 you were already routing through link B—>C, so it looks like you “route around” through the very same link…..



> 
>> The sentence remains superfluous. Of course you can do it with ODL, but this is out of the scope of the IETF and I do not see why it should be there.
>> The other LISP documents never mention a provision system, so why this one has to mention it? Is there a compelling reason?
> 
> Because in other cases ETRs register their own RLOCs because they know them. With an ELP, a provisioning system knows the topology and can register all the addresses in the ELP.  It has a broader view. 
> 
> There are deployments that take an ISIS topology, compute paths offline as an SDN controller, and can build an ELP path based on policy rules (where re-encapsulation points can be placed in the network). 
> 

The sentence is still superfluous. The fact that some LISP deployments use some SDN approach has no place in the document. This is a technical document for implementation of a feature, not a LISP advertisement.
You can leave the sentence there if you really wish, but remains superfluous.


Fix the example and we tackle the text.

Ciao

L.


> Dino