[lmap] Benoit Claise's No Objection on draft-ietf-lmap-yang-11: (with COMMENT)

[Benoit Claise <[e-mail]>]

Benoit Claise has entered the following ballot position for
draft-ietf-lmap-yang-11: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-lmap-yang/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

- No objection to the publication, but the following phrasing puzzles
me.

   It aims to be consistent with the
   LMAP Information Model [I-D.ietf-lmap-information-model].

Actually, the data model is based on information model, right?

>From the charter:
5. The Report protocol and the associated data model: The definition of

how the Report is delivered from a MA to a Collector; this includes a 
Data Model consistent with the Information Model plus a transport 
protocol (to be selected, perhaps REST-style HTTP(s) or IPFIX).

This is reason why the information model is standard track in the
charter.
Therefore the information model must be a normative reference, right?

- one question about the typedefs naming.
It would nice to be able to reuse YANG constructs, typedefs being of
them
We created http://www.yangcatalog.org/yang-search/yang-search.php with
that goal in mind.
	=> insert "identifier"
	=> select typedef
Some of the typedefs are so generically named in LMAP YANG module:
identifier, tag, cycle-number, wildcard, etc.
Do you expect YANG designers to reuse them outside of LMAP? Some of them,
I guess so
Should the other ones be renamed with LMAP in mind. Ex:
lmap-identifier?
In other words, are all the ietf-lmap-common.yang typedef common?


Editorial:
- figure 1
OLD: ietf-lmap-comman.yang
NEW: ietf-lmap-common.yang