Re: [Lsr] Flooding Topology Computation Algorithm - draft-cc-lsr-flooding-reduction-08 Working Group Adoption Call

tony.li@tony.li Fri, 05 June 2020 21:56 UTC

Return-Path: <tony1athome@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D07133A0EA0 for <lsr@ietfa.amsl.com>; Fri, 5 Jun 2020 14:56:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.5
X-Spam-Level:
X-Spam-Status: No, score=-1.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zkU2lg-IOF7F for <lsr@ietfa.amsl.com>; Fri, 5 Jun 2020 14:56:17 -0700 (PDT)
Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F260D3A0E9B for <lsr@ietf.org>; Fri, 5 Jun 2020 14:56:16 -0700 (PDT)
Received: by mail-pl1-x631.google.com with SMTP id g12so4216753pll.10 for <lsr@ietf.org>; Fri, 05 Jun 2020 14:56:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=zr4HJ/hzFW504tP83bKE99mGo8W+Z00abWW6qtEhSu0=; b=F8uMJOaJhkUzM0PJlciDRjjGgSRzzSgJ3XIkX3Pxt0D54O3CG9VZjp3din38Strw/m h/+6WVdJbXLLZBEOQ3jZBhBJfOaAM4XN7WiHZqBTajZAqDi7WL+znLiPeOQTVrw61/n2 PSy0qVXzCQcG86He/OFzay0W7V+AO7A0/YtfSKjk4/sHS2Zp8xlVypJic0d6vayFzNw4 KeWyMPRVJjwYYD0N4G/a3VUfASWxf7BTaBOyRisXTxTZOSG22cL3YAAXFzXP59kuWByj /QgBwO2up/sEdluCEjnowI9xrMSmiAGxf6nRRjMom9Uxpriy/bb5O77AI5oLNCOLG/67 X86w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=zr4HJ/hzFW504tP83bKE99mGo8W+Z00abWW6qtEhSu0=; b=D2B/vm6zTjI/yqmugRVOBe11EWkK8hrwKzMN5NLCXgfsXJlv/6PGJetnTKIAWNTjnz E22R+Qw9B6Pb5Mlx775bpphrpAmAxGL4QBk6b8QtrreCsgfNFpNM3onW11aEijsp2Doq BnZ+KHskBRgk2EUoWTjmOJplqS//DaLweuEdTTpfAr4Cq08iDb7dzCLwTlZ0JVKh70Ta lL+xC3ZEBjymXLxm8GSprJhDghm06OQ27BVlDI9vYtTZncct0KmLweZPZ7iXFyUGvf2y Tf9kp81qIu5QQBwE+GhkKzPA2aGHMx8JHpXs9VR9vWgrMEfaP/T06fONcoeMMC7+ecuH 1XCg==
X-Gm-Message-State: AOAM532RhMQPwIJER7ecG4mejMbrqgukYZwS6FnvlfeC2HjwAfCVLtR8 GvBkb0g78ztgs3mYXLXuWCA=
X-Google-Smtp-Source: ABdhPJwKjXI1kKYkog1tlgn7gbva9IQ+5nR/aOVh1Mnxge1M3wkcCGhffo/BprNY9bu5hJqWokk9zA==
X-Received: by 2002:a17:90a:db90:: with SMTP id h16mr5301628pjv.119.1591394176455; Fri, 05 Jun 2020 14:56:16 -0700 (PDT)
Received: from [10.95.83.65] ([162.210.129.5]) by smtp.gmail.com with ESMTPSA id n4sm5258333pjt.48.2020.06.05.14.56.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2020 14:56:15 -0700 (PDT)
Sender: Tony Li <tony1athome@gmail.com>
From: tony.li@tony.li
Message-Id: <89CC2518-AAE7-4CA2-9910-C56EBD8A2200@tony.li>
Content-Type: multipart/alternative; boundary="Apple-Mail=_F889A650-D174-4FDD-ADD6-6EDAF9A76888"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Fri, 5 Jun 2020 14:56:13 -0700
In-Reply-To: <8FACDF6D-B0E7-4EE5-B568-A32450D8BA5F@futurewei.com>
Cc: "Acee Lindem (acee)" <acee=40cisco.com@dmarc.ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, Huaimo Chen <huaimo.chen@futurewei.com>
To: Yingzhen Qu <yingzhen.qu@futurewei.com>
References: <7B1E9ED7-F2B6-45AA-9E64-AD9E5B439D02@cisco.com> <8FACDF6D-B0E7-4EE5-B568-A32450D8BA5F@futurewei.com>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/-8CDVvNdCeLmcxtLmtB1tH6sFis>
Subject: Re: [Lsr] Flooding Topology Computation Algorithm - draft-cc-lsr-flooding-reduction-08 Working Group Adoption Call
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2020 21:56:19 -0000

Hi,


> I have a question regarding the draft. At the end of section 3, it says if there is any change in the base topology, the flooding topology MUST be re-computed. So in case of a link failure in the base topo, it’s possible that the link is not part of the flooding topology (e.g. one of the multiple links between two nodes), it might be optimal if we can figure it out and save recalculation here.


This comment isn’t specific to this algorithm, so you’ll pardon me if I jump in.

Always recomputing the flooding topology is always a safe thing to do and for the case of a distributed algorithm is probably the safest design choice.

Doing the analysis about the change is not exactly trivial and computing the flooding topology is not that hard.  We are typically not short of CPU cycles and recomputing the flooding topology is outside of the critical convergence window, so while there is some theoretical benefit, it’s not at all clear that it’s of great practical benefit.  But it is up to those specifying the algorithm.

Regards,
Tony