Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29

"Acee Lindem (acee)" <acee@cisco.com> Wed, 23 January 2019 16:19 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28B9E130E98; Wed, 23 Jan 2019 08:19:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -19.054
X-Spam-Level:
X-Spam-Status: No, score=-19.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y2OayPb6OYW3; Wed, 23 Jan 2019 08:19:01 -0800 (PST)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02B9F130E96; Wed, 23 Jan 2019 08:19:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5920; q=dns/txt; s=iport; t=1548260341; x=1549469941; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=GU0V5p0YPKKQIJOqcM7+83ySMOIpcwwv3Lgat1ROtG8=; b=WjUzrpmbUtw4Cf80yZk94S/RBr/RdIY6GLrO4g/BuLOE9twUt/Y+XGRc VTegGi2lCZeY3FkX4aWzqlylbDuNWx/pMNcIJOMPYmd3rTfD/Xb/lyGkS AVvmmKK/wNEeRMDLVk0WHv6rO8H7l0Tp4+xCEogzUoXrWQKskQf91QWaj 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AFAAClkkhc/5tdJa1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUgMBAQEBAQsBggNmgQInCoN3lAiBaCWYAxSBZwsBARg?= =?us-ascii?q?LhEkCF4JlIjUIDQEDAQECAQECbRwMhUoBAQEBAwEBIRE6FwQCAQgRAwEBAQE?= =?us-ascii?q?CAiMDAgICJQsUAQgIAgQBEoMiAYIBD6w7gS+EAwGGJwWBC4s2F4F/gTgME4J?= =?us-ascii?q?Mgx4BAYEuARIBNhWCXTGCJgKJS5hbCQKSHhiBZ4UxiwCKB5EAAhEUgScgATZ?= =?us-ascii?q?lcXAVOyoBgkGLHYUIATZBMYhegR+BHwEB?=
X-IronPort-AV: E=Sophos;i="5.56,512,1539648000"; d="scan'208";a="229503531"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2019 16:19:00 +0000
Received: from XCH-RTP-011.cisco.com (xch-rtp-011.cisco.com [64.101.220.151]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id x0NGIxCg009541 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 23 Jan 2019 16:18:59 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-011.cisco.com (64.101.220.151) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 23 Jan 2019 11:18:58 -0500
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1395.000; Wed, 23 Jan 2019 11:18:58 -0500
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Ladislav Lhotka <lhotka@nic.cz>, "stephane.litkowski@orange.com" <stephane.litkowski@orange.com>, tom petch <ietfc@btconnect.com>, Yingzhen Qu <yingzhen.qu@huawei.com>, "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-isis-yang-isis-cfg@ietf.org" <draft-ietf-isis-yang-isis-cfg@ietf.org>
Thread-Topic: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
Thread-Index: AQHUsvtFmHVGNqpKR26/bX73rx4nrKW9CLiA
Date: Wed, 23 Jan 2019 16:18:58 +0000
Message-ID: <86A1595E-3B6C-4C3A-9417-DE68BF6E7C0F@cisco.com>
References: <594D005A3CB0724DB547CF3E9A9E810B011230B1@sjceml521-mbx.china.huawei.com> <56F6AF71-F733-40E4-8C46-08C2803A3F90@cisco.com> <03aa01d4b250$9139d040$4001a8c0@gateway.2wire.net> <14660_1548173928_5C474268_14660_472_1_9E32478DFA9976438E7A22F69B08FF924B791E9B@OPEXCLILMA4.corporate.adroot.infra.ftgroup> <74815665dee940dddf16eb14c5c98170435aafd9.camel@nic.cz>
In-Reply-To: <74815665dee940dddf16eb14c5c98170435aafd9.camel@nic.cz>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.197]
Content-Type: text/plain; charset="utf-8"
Content-ID: <9395B5B42E01FB489C291CF353D91865@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.151, xch-rtp-011.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/05qox8ebtgUkLbH70yBmRgtLQSY>
Subject: Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 16:19:03 -0000

Tom, Lada, Stephane, 
I've changed the XML formatting so that the actual ietf-isis.yang model can be embedded as is without any substitution characters. This is in the -33 version. There are no other changes in this version (other than removing some trailing white spaces and expanding tabs). 
Thanks,
Acee 

On 1/23/19, 4:09 AM, "Ladislav Lhotka" <lhotka@nic.cz>; wrote:

    Hi Stéphane,
    
    the problem is in the source of the "ietf-isis" module inside <artwork>: the
    chevrons enclosing email addresses should be encoded as XML entities &lt; and
    &gt; but what I see there is &amp;lt; and &amp;gt;
    
    Lada
    
    On Tue, 2019-01-22 at 16:18 +0000, stephane.litkowski@orange.com wrote:
    > Hi Tom,
    > 
    > This is plaintext. You can see it in the XML source of the draft, there is no
    > link in the YANG module.
    > Is your concern coming from the "[" "]" characters ? Just a copy/paste from
    > the text version of the boilerplate, but there is no link behind.
    > 
    > 
    > -----Original Message-----
    > From: Lsr [mailto:lsr-bounces@ietf.org] On Behalf Of tom petch
    > Sent: Tuesday, January 22, 2019 13:48
    > To: Acee Lindem (acee); Yingzhen Qu; lsr@ietf.org; 
    > draft-ietf-isis-yang-isis-cfg@ietf.org
    > Subject: Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-
    > 29
    > 
    > -32 has the RFC2119 boilerplate in the YANG module - thank you - but...
    > YANG modules must be plain text and
    > 
    >          "are to be interpreted as described in BCP 14 [RFC2119]
    >           [RFC8174] when, and only when, they appear in all capitals, as
    >           shown here."
    > 
    > looks rather like XML/HTML anchors and not plain text.
    > 
    > Time idnits learnt what a YANG module looks like!
    > 
    > Tom Petch
    > 
    > ----- Original Message -----
    > From: "Acee Lindem (acee)" <acee@cisco.com>;
    > To: "Yingzhen Qu" <yingzhen.qu@huawei.com>;; <lsr@ietf.org>;;
    > <draft-ietf-isis-yang-isis-cfg@ietf.org>;
    > Sent: Monday, January 21, 2019 9:07 PM
    > Subject: Re: [Lsr] Shepherd review comments on
    > draft-ietf-isis-yang-isis-cfg-29
    > 
    > 
    > > Hi Yingzhen,
    > > All the idnits warnings are fixed in the -32 version of the drafts.
    > > Thanks,
    > > Acee
    > > 
    > > From: Yingzhen Qu <yingzhen.qu@huawei.com>;
    > > Date: Friday, January 18, 2019 at 5:35 PM
    > > To: "lsr@ietf.org"; <lsr@ietf.org>;,
    > "draft-ietf-isis-yang-isis-cfg@ietf.org";
    > <draft-ietf-isis-yang-isis-cfg@ietf.org>;
    > > Subject: Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
    > > Resent-From: <alias-bounces@ietf.org>;
    > > Resent-To: Stephane Litkowski <stephane.litkowski@orange.com>;, Derek
    > Yeung <derek@arrcus.com>;, Acee Lindem <acee@cisco.com>;, Jeffrey Zhang
    > <zzhang@juniper.
    > 
    > _______________________________________________
    > Lsr mailing list
    > Lsr@ietf.org
    > https://www.ietf.org/mailman/listinfo/lsr
    > 
    > ______________________________________________________________________________
    > ___________________________________________
    > 
    > Ce message et ses pieces jointes peuvent contenir des informations
    > confidentielles ou privilegiees et ne doivent donc
    > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce
    > message par erreur, veuillez le signaler
    > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
    > electroniques etant susceptibles d'alteration,
    > Orange decline toute responsabilite si ce message a ete altere, deforme ou
    > falsifie. Merci.
    > 
    > This message and its attachments may contain confidential or privileged
    > information that may be protected by law;
    > they should not be distributed, used or copied without authorisation.
    > If you have received this email in error, please notify the sender and delete
    > this message and its attachments.
    > As emails may be altered, Orange is not liable for messages that have been
    > modified, changed or falsified.
    > Thank you.
    > 
    -- 
    Ladislav Lhotka
    Head, CZ.NIC Labs
    PGP Key ID: 0xB8F92B08A9F76C67