Re: [Lsr] Flex Algo merge work, IS-IS and OSPF FAD sub-TLVs

Christian Hopps <chopps@chopps.org> Sat, 19 May 2018 13:15 UTC

Return-Path: <chopps@chopps.org>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2946912D87B for <lsr@ietfa.amsl.com>; Sat, 19 May 2018 06:15:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QBzQ3b3opoY2 for <lsr@ietfa.amsl.com>; Sat, 19 May 2018 06:15:31 -0700 (PDT)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56]) by ietfa.amsl.com (Postfix) with ESMTP id 770BB12778E for <lsr@ietf.org>; Sat, 19 May 2018 06:15:31 -0700 (PDT)
Received: from stubbs.lan (47-50-69-38.static.klmz.mi.charter.com [47.50.69.38]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPSA id C69F963342; Sat, 19 May 2018 13:15:30 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
From: Christian Hopps <chopps@chopps.org>
In-Reply-To: <8c0d3e38bfe04b1a973f3cb4285840e8@XCH-ALN-001.cisco.com>
Date: Sat, 19 May 2018 09:15:27 -0400
Cc: "Acee Lindem (acee)" <acee@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F02D7E3F-15D4-4C8C-89DE-D6F69AA71323@chopps.org>
References: <612C3B15-9DD2-48C0-A5E5-B999D07AD1D7@cisco.com> <8c0d3e38bfe04b1a973f3cb4285840e8@XCH-ALN-001.cisco.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
X-Mailer: Apple Mail (2.3445.6.18)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/1Yrpm5KW1T2N6_eW2CJtzU1jOtc>
Subject: Re: [Lsr] Flex Algo merge work, IS-IS and OSPF FAD sub-TLVs
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 May 2018 13:15:34 -0000

Hi Les,

It feels like your response is perhaps reading more into my suggestion than was intended. I was in no way suggesting we go back and start combining TLV registries, or that future registries needed to be combined unnecessarily.

I'm looking at this particular case where we have 2 copies of the same [sub-]sub-TLV registry that we will be creating as the document is written. The OSPF definitions for the sub-TLV types are exactly the same as the IS-IS sub-sub-TLVs ones. In fact option 2 keeps the containing [sub-]TLV separate and only the [sub-]sub-TLV space is combined.

Isn't it better to define something once and refer to that single definition? This is the motivation that led us to combining the documents in the first place, and so I'm simply wondering if we can benefit more from this same treatment.

Thanks,
Chris.

P.S WRT type field length of [sub-]sub-TLVs. We are *defining* the value content, so of course we can do whatever we want and no documents about other [sub-]TLV values, types or field lengths actually applies unless we wish it to.

P.P.S. WRT scoping. The document defines an IS-IS sub-TLV which is scoped to the IS-IS Router Capability TLV (242) and defines an OSPF TLV which is scoped to the Router Information LSA. I think these are fairly analogous, or at least can be treated as such for [sub-]sub-TLV definitions. In fact section 5.3 treats them as equal for defining their use. I don't put this above b/c it's not something I want to distract from the general discussion and sharing the FAD [sub-]TLV was only option 1 of a list.


> On May 18, 2018, at 11:41 AM, Les Ginsberg (ginsberg) <ginsberg@cisco.com> wrote:
> 
> (I never saw Chris's original email either - perhaps it was sent during the period when delivery to the alias when compromised.)
> 
> I am in full agreement w Acee - it is a VERY BAD idea to try to combine protocol TLV registries.
> There are many reasons for this - here are a few.
> 
> 1)In IS-IS the scope of TLV type identifiers is the protocol - in OSPF it is the LSA type
> 
> 2)There are (obviously) many legacy code points which will make consistency at best confusing
> 
> 3)Imposing an 8 bit type on OSPF or a 16 bit type on IS-IS is simply a non-starter.  RFC 7356 defines a non-backwards compatible way of doing this for IS-IS - but does so in a way that preserves the legacy codepoints - which seems obviously necessary. And introducing a 16 bit length into IS-IS isn't sensible unless we also address the current 256 LSP number limitation (which RFC 7356 also does). Suggesting this can be usefully done in a backwards compatible way does not make sense to me.
> I cannot imagine why OSPF would be motivated to move to a more restricted 8 bit type/length model.
> 
> I cannot support this suggestion.
> 
>   Les
> 
> 
>> -----Original Message-----
>> From: Lsr <lsr-bounces@ietf.org> On Behalf Of Acee Lindem (acee)
>> Sent: Friday, May 18, 2018 7:29 AM
>> To: Christian Hopps <chopps@chopps.org>
>> Cc: lsr@ietf.org
>> Subject: [Lsr] Flex Algo merge work, IS-IS and OSPF FAD sub-TLVs
>> 
>> Hi Chris,
>> 
>> Somehow, I lost the mail below and was only able to retrieve it from the
>> archive. Pardon my top posting.
>> 
>> While I believe that sharing code points for values, e.g., IGP Algorithm Type,
>> is a good idea, I don’t necessarily think it is a good idea to merge the TLV type
>> registries. It seems to me it would be a poor trade-off to impact optimal
>> protocol encoding including implementation just so we can have a combined
>> IANA registry. It is extremely unlikely that OSPF and IS-IS implementations
>> will ever share a common TLV parsing library.
>> 
>> Note that we did discuss this once before in the context of the OSPF and IS-
>> IS Tunnel Encapsulation drafts. I'd appreciate hearing what other WG
>> members feel with respect to this issue.
>> 
>> Thanks,
>> Acee
>> 
>> 
>> 
>> 
>> 
>> 
>> Christian Hopps <chopps@chopps.org> Thu, 17 May 2018 21:07 UTC
>> 
>> So in looking at the IANA requests inside the newly merged flex algorithm
>> draft I noticed that the document is creating 2 separate Flex Algorithm
>> Definition sub-tlvs Registries for IS-IS and OSPF with the initial content
>> described in sections:
>> 
>> 6.1.  ISIS Flexible Algorithm Exclude Admin Group Sub-TLV 6.2.  ISIS Flexible
>> Algorithm Include-Any Admin Group Sub-TLV 6.3.  ISIS Flexible Algorithm
>> Include-All Admin Group Sub-TLV
>> 
>> 7.1.  OSPF Flexible Algorithm Exclude Admin Group Sub-TLV 7.2.  OSPF
>> Flexible Algorithm Include-Any Admin Group Sub-TLV 7.3.  OSPF Flexible
>> Algorithm Include-All Admin Group Sub-TLV
>> 
>> They are basically the same thing (indeed the later OSPF sections refer back
>> to the IS-IS sections), except for one detail AFAICT, the size of the type and
>> length fields.
>> 
>> I think we may have some options here to make this a bit more elegant.
>> 
>> 1. Share the same sub-TLV structure
>>   a. using the OSPF sub-tlv structure (16 bit type and 16 bit len) for both
>> protocols
>>   b. using the IS-IS sub-tlv structure (8 bit type and 8 bit len) for both
>> protocols
>> 
>> 2. Use different structure with the same type field size of the
>>   a. more constrained IS-IS 8 bit size
>>   b. less constrained OSPF 16 bit size
>> 
>> 3. Define and use some generic method to define shared TLVs like this
>> where the only actual difference is the size of the type and length fields.
>> 
>> 
>> 1, Creates a clean and simple standard, 1 TLV definition and 1 sub-TLV
>> registry.
>> 
>> 1a, has the property that the length value in IS-IS can't normally exceed an 8
>> bit value; however, sub-TLV length values are already constrained beyond
>> the field size as sub-TLVs may appear anywhere in the TLV.
>> 
>> 1b, restricts both protocols to 256 types, and perhaps more importantly
>> restricts the sub-TLV length to 257 octets. This is handled all the time in IS-IS
>> using repeated TLVs, but not so much (ever?) in OSPF.
>> 
>> 
>> 2. Allows us to at least create a single IANA registry for the sub-tlv types so
>> we aren't duplicating them and their definitions for each protocol.
>> 
>> 
>> 3. Is interesting but probably requires some work outside of this document.
>> 
>> 
>> This document is serving as our guinea pig for how to merge work so I think
>> it's worth spending some effort on these types of details.
>> 
>> Thanks,
>> Chris.
>> 
>> _______________________________________________
>> Lsr mailing list
>> Lsr@ietf.org
>> https://www.ietf.org/mailman/listinfo/lsr