Re: [Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11

"Acee Lindem (acee)" <acee@cisco.com> Fri, 24 April 2020 12:38 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C4AE3A0C21; Fri, 24 Apr 2020 05:38:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Z/EQzGSk; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=JaEQDa/r
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id df1EXQJeFJRG; Fri, 24 Apr 2020 05:38:47 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5ED3A3A0C1B; Fri, 24 Apr 2020 05:38:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2554; q=dns/txt; s=iport; t=1587731925; x=1588941525; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EgnZr8K5Ia0BGO7yujV0QF7oo8jgRxP1/n4b+T0qo2A=; b=Z/EQzGSk10UJC5gWmT/RIV2TGPBiyO7gjBYbRXT4mvVEMUh/FfgP3ISR zkml3xwT/rkLjlNOUyEyoSNRXGizx+hQrXemEwptDGkI1/WdS1HGJ5KTP cVPk5BaoD2JIuPCpK+0LEzzx8iFWVTyKbpnS9Raq3qth3V6lvWmDRXk74 4=;
IronPort-PHdr: =?us-ascii?q?9a23=3At9yBhBFS8jj8wtoM/kmYLJ1GYnJ96bzpIg4Y7I?= =?us-ascii?q?YmgLtSc6Oluo7vJ1Hb+e4w0Q3SRYuO7fVChqKWqK3mVWEaqbe5+HEZON0ETB?= =?us-ascii?q?oZkYMTlg0kDtSCDBjyJ/PnRyc7B89FElRi+iLzPA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CnAABL3aJe/4cNJK1mHAEBAQEBBwE?= =?us-ascii?q?BEQEEBAEBgWkFAQELAYFTUQVsWCAECyoKhBWDRgOKcIJfmDCBLoEkA1QKAQE?= =?us-ascii?q?BDAEBIwoCBAEBhEQCF4IPJDYHDgIDAQELAQEFAQEBAgEFBG2FVgyFcgIBAxI?= =?us-ascii?q?REQwBATcBDwIBCBQGAiYCAgIwFRACBAENBSKDBAGCSwMuAQ6mWQKBOYhidYE?= =?us-ascii?q?ygwABAQWFJBiCDgMGgQ4qAYJiiVYaggCBEAEnHIJNPoJnAoFlgxIygi2OYIJ?= =?us-ascii?q?WoGkKgkWIDIsphEIWB4JZiFSRPo91iUGTOAIEAgQFAg4BAQWBWQUtgVZwFWU?= =?us-ascii?q?Bgj5QGA2RNINzhRSFQnSBKY0JAYEPAQE?=
X-IronPort-AV: E=Sophos;i="5.73,311,1583193600"; d="scan'208";a="742881917"
Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 24 Apr 2020 12:38:43 +0000
Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 03OCch2I008974 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 24 Apr 2020 12:38:43 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 24 Apr 2020 07:38:43 -0500
Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 24 Apr 2020 07:38:42 -0500
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 24 Apr 2020 07:38:42 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQASDlgBrwzFrAbKu+MBD8/FpHWCsYQgIA/Zoic4vzORZ/EygWUKYO9fDWj07+JSuocoZv/OSbj+Jq9Ikut+t7j1YrdTCHNvjY1w5izyuii/Azky7iLj8ULwXbnzmRxYcdeY7sP4QPGyAxzXhp4AceJubK/IUdftZkfB3an4XBZWlg+FWEJzIsjsSbiKPvQkHUjxa0Q60qYDpsSzpouCet3WK/DSsTUbjzckKQArIPQ1JaF+YYVwwEyXlSNZoXaLD6xy/Npi6RQMvPyq/59DDGXL3BJrtbtW5iHnVyjlbfRVgugpJXmnjXU/i+js++njgWeGCcEoSEVgN4DRIj//NA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgnZr8K5Ia0BGO7yujV0QF7oo8jgRxP1/n4b+T0qo2A=; b=ad5rw1kD3riv84Tdw2IZV/r3I0wEU4JoTbSFNpfKCp6zNgXhgYrIBNtvTwT7lXWFHmLBKWS7fg7ERM3ShfYnM78D4RLsB66cXof0kPHje8fRL9d/EbJrhcwOjwGDFOHgNNTnAYZuE6MXNeDksvUaCGUirxMR3Ys5yAI8hPi6r7pXZd74YH3rwWuma9do5wen2swYXUTdcigbaQ/pRtdtGeb6BWbvEWUvVGQl1pxoaEuK2mMmPzuccun57RyuknXwkUUWWv2BzD9UYOWXq9Cr+iU2pmeLfN2pi4LIHXXF5Z1kg2+xWPyxt6ggJVfHadl5ahj818yipzOcd+rQNpX6Gw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgnZr8K5Ia0BGO7yujV0QF7oo8jgRxP1/n4b+T0qo2A=; b=JaEQDa/rWsPw6ayo1Ex+K1nUZ/IqPA6Pz6hh2+t4RAyETzcbpv9lBOWot0ifEDCSmued2SVho9xz3ONZ+/+jdyJQi4e0J8U4/j7ZaMypSrTJPgS3m4gDBdMXh27G+J41TPZ6Qwh1QzDWs/8BYNMNI2gxiTSt9aBUZXhhBjQWD9I=
Received: from BN8PR11MB3794.namprd11.prod.outlook.com (2603:10b6:408:8f::13) by BN8PR11MB3793.namprd11.prod.outlook.com (2603:10b6:408:86::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 24 Apr 2020 12:38:41 +0000
Received: from BN8PR11MB3794.namprd11.prod.outlook.com ([fe80::8948:a1ef:4174:7f15]) by BN8PR11MB3794.namprd11.prod.outlook.com ([fe80::8948:a1ef:4174:7f15%6]) with mapi id 15.20.2921.030; Fri, 24 Apr 2020 12:38:41 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Mohit Sethi <mohit.m.sethi@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-isis-mpls-elc.all@ietf.org" <draft-ietf-isis-mpls-elc.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-isis-mpls-elc-11
Thread-Index: AQHWGguB+OxDJ5p14UCYzqdbDlwYy6iH82gA
Date: Fri, 24 Apr 2020 12:38:41 +0000
Message-ID: <E17FABFB-FF20-4BB0-8A2A-214A4E5DE04E@cisco.com>
References: <158771396796.16808.7505639544953079846@ietfa.amsl.com>
In-Reply-To: <158771396796.16808.7505639544953079846@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.36.20041300
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [136.56.133.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bb6d12ce-f9a4-4db3-3ac7-08d7e84c6b6e
x-ms-traffictypediagnostic: BN8PR11MB3793:
x-microsoft-antispam-prvs: <BN8PR11MB37939523BFA01380B39AFB3CC2D00@BN8PR11MB3793.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 03838E948C
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3794.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(6512007)(6506007)(110136005)(54906003)(5660300002)(33656002)(478600001)(316002)(36756003)(66946007)(71200400001)(66476007)(26005)(66556008)(64756008)(6486002)(66446008)(76116006)(81156014)(91956017)(8936002)(186003)(2906002)(4326008)(86362001)(8676002)(2616005); DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 324ZoVYDtd0VROuxnwZJhaveN36vNH5g4KNSWUk2A0OgXGFvf61S4xh+TJNvGJgzIz4kK6PseVDvOX2K5H40LAk1swtJJPd4h4AhMpcdv1cS5L4BAqR2ki7HFlDSoBk7v9akx8wO+JmJ1f9f4si4C4eFgM8Rn5V6D/pV7MPhpJSLJYPqfhD8NKaABZRUGKIR3OcLVa8ae9Xj3ISKAi1ehfWdmdRwwx/mhWFIcsp8L3q67mmdt2tSFMWYNSKvhTdQzPLtcPtJ2eA3RwbLRLqlPRYDkGj5n0N+Y4c3ZLHrWDo7kmlkNHYPkcpdU937NLSZ46tj2iZohikr6k96kf+5NLYeX6zA+jzVe7F7q7eJTAv+I0nQF4VVkyysx1wgUUi5fQj0X0fw42YELMhcVLhVrwB+DYY+La6YubQ8Bhyrc8fKOvQ8iVLUCPl10nhyWIH85UJx/orHzDRG7keAR3xEFaM2BGW1rCvjkuVFM7fMWuHyP++Yb3q8g2Xb+LLJDkFsI0zhdXhfwFlp0b2wzxFxVw==
x-ms-exchange-antispam-messagedata: 27oxdkwsCB32J352C/YXg3W1jdygSQBAaQCOMSmTJPFM/dhHAajZ87y8iagSmOPrz80Ql3BH5Ie3ZewsT1ai672JKAtJQrnGOWx/o71xbisiI4kwJ2ptYEk8ZnhzlEjZn6fWyh4g25U7p32kovhT4Q==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <D38D49479C0BAA44ABA8F39F2A6C7178@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bb6d12ce-f9a4-4db3-3ac7-08d7e84c6b6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 12:38:41.2609 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nosFeBgzCNldrPEU9NcNfMfGgVIcjZDT4x6cEVCDngJNDYqFRJ7I2QMKrm3iig4P
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3793
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com
X-Outbound-Node: alln-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/8oN1fV4ka_hlKQYL0LQdBpyplBg>
Subject: Re: [Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Apr 2020 12:38:51 -0000

Hi Mohit,

Speaking as document shepherd. See inline. 

On 4/24/20, 3:39 AM, "Mohit Sethi via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Mohit Sethi
    Review result: Ready with Nits

    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.

    For more information, please see the FAQ at

    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

    Document: draft-ietf-isis-mpls-elc-11
    Reviewer: Mohit Sethi
    Review Date: 2020-04-24
    IETF LC End Date: 2020-05-05
    IESG Telechat date: Not scheduled for a telechat

    Summary: This document specifies how Entropy Label Capability (ELC) and Entropy
    Readable Label Depth (ERLD) are advertised using IS-IS. For advertising ELC, a
    flag in the Prefix Attribute Flags is used. For advertising ERLD, a Node MSD
    Advertisement is used.

    Major issues:

    Minor issues: The document is short and straightforward. For someone like me
    who is not familiar with the routing area, would it make sense to explain why
    signalling ELC information with MPLS is not sufficient (or what are the
    benefits of advertising with IS-IS)?

I guess I'm wondering what you mean "signaling ELC information with MPLS"? With segment routing, the IGPs can be the only choice for signaling ELC capability. I don’t believe this comment requires any action. 

Thanks,
Acee


    Nits/editorial comments:

    In section 3, "used as the ECL  Flag" should perhaps be "used as the ELC Flag"?
    In section 4, "IANA for EARLD-MSD" should perhaps be "IANA for ERLD-MSD"?
    In section 6, "ECL Flag (E-flag)." should perhaps be "ELC Flag (E-flag)."?