Re: [Lsr] Opsdir last call review of draft-ietf-ospf-ospfv3-segment-routing-extensions-16

Peter Psenak <ppsenak@cisco.com> Tue, 20 November 2018 09:30 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93AAD12D4EF; Tue, 20 Nov 2018 01:30:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RSbMbDjW8Xi2; Tue, 20 Nov 2018 01:30:55 -0800 (PST)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3795A1292AD; Tue, 20 Nov 2018 01:30:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3494; q=dns/txt; s=iport; t=1542706255; x=1543915855; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=O1cLKBmVZAwu+OvW+Gje9PRz5o6oPFu6duHo9bpU2fM=; b=aI8x7VKY0xaCtSuv47DA1A2NADVOul0+OIi3/mW9SFJnX82RS6DPVA4O +zv+B6e/n7Zy9PZtPlaGFODrkq/VGJQhrlTPPEGDNVt6c7U8YRzsbduME TA1z0vmdMAkpy9hV1Vbqnn4TEoTJ6TJukSliTKFadD4URLEv6YqKQPb59 U=;
X-IronPort-AV: E=Sophos;i="5.56,256,1539648000"; d="scan'208";a="8115994"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 09:30:53 +0000
Received: from [10.147.24.21] ([10.147.24.21]) by aer-core-1.cisco.com (8.15.2/8.15.2) with ESMTP id wAK9UpWD003397; Tue, 20 Nov 2018 09:30:52 GMT
Message-ID: <5BF3D44A.1070403@cisco.com>
Date: Tue, 20 Nov 2018 10:30:50 +0100
From: Peter Psenak <ppsenak@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Alvaro Retana <aretana.ietf@gmail.com>, draft-ietf-ospf-ospfv3-segment-routing-extensions.all@ietf.org
CC: lsr@ietf.org, Joe Clarke <jclarke@cisco.com>
References: <154058293310.8782.9766839380541329981@ietfa.amsl.com> <5BD848FF.7060400@cisco.com> <CAMMESswCUsK+S7gTEPnSsx0fhuK8qyr2HNc5g2XRwh3CpFZL3Q@mail.gmail.com>
In-Reply-To: <CAMMESswCUsK+S7gTEPnSsx0fhuK8qyr2HNc5g2XRwh3CpFZL3Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.147.24.21, [10.147.24.21]
X-Outbound-Node: aer-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/8zhiuXrVBwcijtb8eAV65vMIQcA>
Subject: Re: [Lsr] Opsdir last call review of draft-ietf-ospf-ospfv3-segment-routing-extensions-16
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 09:30:58 -0000

Hi Alvaro,

done.

Have some issues posting the new ospfv2 draft, so requested manual posting.

thanks,
Peter

On 16/11/18 22:40 , Alvaro Retana wrote:
> [Took the ops-dir and the ietf@ietf lists off.]
>
> Hi!
>
> Joe makes a really good point below about the TLV types and RFC7770.  It
> looks like we all missed it! :-(
>
> To quote Peter (from a message in this thread), "I don't think it is
> good to specify the behavior which is described somewhere else.”
>
> Looking at -18, Section 4
> (draft-ietf-ospf-ospfv3-segment-routing-extensions) has the exact same
> text [*] as Section 3 in draft-ietf-ospf-segment-routing-extensions.
> Given that the IANA allocation is done
> in draft-ietf-ospf-segment-routing-extensions, and
> that draft-ietf-ospf-ospfv3-segment-routing-extensions refers back to
> it, then I would like to see the following changes:
>
> (1) In draft-ietf-ospf-segment-routing-extensions, Section 3:
>
> <OLD>
> These SR capabilities are advertised in the Router Information Opaque
> LSA (defined in [RFC7770]).
>
> <NEW>
> These SR capabilities are advertised in the Router Information Opaque
> LSA (defined in [RFC7770]).  The TLVs defined below are applicable to
> both OSPFv2 and OSPFv3; see also
> [ID.ietf-ospf-ospfv3-segment-routing-extensions].
>
> …and add an Informative reference to
> draft-ietf-ospf-ospfv3-segment-routing-extensions.
>
> (2) In draft-ietf-ospf-ospfv3-segment-routing-extensions, replace the
> entire Section 4 with:
>
> "
> Segment Routing requires some additional router capabilities to be
> advertised to other routers in the area.
>
> These SR capabilities are advertised in the OSPFv3 Router Information
> Opaque LSA (defined in [RFC7770]), and specified in
> [ID.ietf-ospf-segment-routing-extensions].
> “
>
>
> Even though draft-ietf-ospf-segment-routing-extensions is already with
> the RFC Editor, it is waiting
> for draft-ietf-spring-segment-routing-mpls, so we can still make
> changes.  Please submit a new version (and send an update of the XML to
> the rfc-editor).
>
> I am scheduling draft-ietf-ospf-ospfv3-segment-routing-extensions on the
> Dec/6 IESG Telechat.  Please submit an update before the end of this month.
>
> Thanks!!
>
> Alvaro.
>
>
>
> [*] Except for the OSPFv3 being specifically called out, and a couple of
> other minor points.
>
> On October 30, 2018 at 8:05:27 AM, Peter Psenak (ppsenak@cisco.com
> <mailto:ppsenak@cisco.com>) wrote:
>
>> > With respect to TLV types 8, 9, 14, and 15, they are defined in
>> > draft-ietf-ospf-segment-routing-extensions, and it took me a while to figure
>> > out where you were getting those values and why they weren't spelled out in the
>> > IANA considerations. You have a normative reference to this, which is good,
>> > but you only mention it with respect to the algorithm parameters. I think
>> > another mention is required.
>> >
>> > I'm going to be pedantic here. According to RFC7770, when a new OSPF Router
>> > Information LSA TLV is defined, the spec needs to explicitly state if it's
>> > applicable to OSPFv2, v3, or both. While you reference the TLVs from
>> > draft-ietf-ospf-segment-routing-extensions, I didn't see that either document
>> > _explicitly_ states that they are applicable to both.
>>
>> ##PP
>> added the following to each of the values:
>>
>> Type: X as defined in [I-D.ietf-ospf-segment-routing-extensions] and
>> aplicable to OSPFv3.