[Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11

Mohit Sethi via Datatracker <noreply@ietf.org> Fri, 24 April 2020 07:39 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: lsr@ietf.org
Delivered-To: lsr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C7543A0E59; Fri, 24 Apr 2020 00:39:28 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Mohit Sethi via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: lsr@ietf.org, draft-ietf-isis-mpls-elc.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.127.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158771396796.16808.7505639544953079846@ietfa.amsl.com>
Reply-To: Mohit Sethi <mohit.m.sethi@ericsson.com>
Date: Fri, 24 Apr 2020 00:39:28 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/B7QtDuNx7FlejJpgqHCSEqe2CXg>
Subject: [Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Apr 2020 07:39:29 -0000

Reviewer: Mohit Sethi
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-isis-mpls-elc-11
Reviewer: Mohit Sethi
Review Date: 2020-04-24
IETF LC End Date: 2020-05-05
IESG Telechat date: Not scheduled for a telechat

Summary: This document specifies how Entropy Label Capability (ELC) and Entropy
Readable Label Depth (ERLD) are advertised using IS-IS. For advertising ELC, a
flag in the Prefix Attribute Flags is used. For advertising ERLD, a Node MSD
Advertisement is used.

Major issues:

Minor issues: The document is short and straightforward. For someone like me
who is not familiar with the routing area, would it make sense to explain why
signalling ELC information with MPLS is not sufficient (or what are the
benefits of advertising with IS-IS)?

Nits/editorial comments:

In section 3, "used as the ECL  Flag" should perhaps be "used as the ELC Flag"?
In section 4, "IANA for EARLD-MSD" should perhaps be "IANA for ERLD-MSD"?
In section 6, "ECL Flag (E-flag)." should perhaps be "ELC Flag (E-flag)."?