Re: [Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11

Mohit Sethi M <mohit.m.sethi@ericsson.com> Wed, 29 April 2020 06:29 UTC

Return-Path: <mohit.m.sethi@ericsson.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4167C3A0A38; Tue, 28 Apr 2020 23:29:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.92
X-Spam-Level:
X-Spam-Status: No, score=-2.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.82, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H2gzCgMaiBsQ; Tue, 28 Apr 2020 23:29:28 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12B493A0A3B; Tue, 28 Apr 2020 23:29:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QH+oidRQQhgsnJfaUUPmaoBY7AD4gdzMAbka24GOwvd6w6AvlTZjyYdxk8rqpX6FqcBNbeRAQ2zVNJchBy9MaSDjbJFHRhLcskh4A7jEJhhN7fKd4RB372HtWftZnvCm2fHU1/pr9vMgVt6aznjHocjgqaGt1okzSNAIIw6ijzDaS98Me05HthUsRTi1iwZg4Q/sFpxIgLv0Bb8d9Wenj7lDJrQggccphK8mc/Q4J8wwWdfax33dBgkaF0Cmm6nf0fODn4CrtSpZnsJJTMdsFUvS0Zk6/CCO8+B6hvEDZZaAkDl1oVlnKf8+aT/TmLKHj4KFd7vkHOp7dsz9Eq2eqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FFeBSuepzHbByLBsTqIayEoL4QxmIpIbayzZftKKQs=; b=EzwzYtWaQziFLvHM9qm6W1BuziL91txup/CbUigYQWZmbZK/dMXb6mnb9jCv+jHnBMNjs73X25RgOD7HnA2bGEHy9QIVkhoizSnYINF5G23Gxw5g5x1gxVX5dNl2+Ul+kj5swfzQZKAqex2HbErCouOyFISEjv2tFcXWenRRMrDF0SmFMBgMZfwMPzC0ZRhl0mqVFBqzVOCjED5j+FHRGCufirzZZYaiSArngBqM148sz+f7hXSI7lX0PziBSqgxvzojraRe/STeXobYt32nWQ57CvOhb+MNOKNqjy2FqfRUWausvrMpUQ7VfCVznfOeaTOligT5kVcDF7dweOXfHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FFeBSuepzHbByLBsTqIayEoL4QxmIpIbayzZftKKQs=; b=Mt6nqPSNIFub5DQWR/Dsff1A2NAmZe8VahBdxfxohb4sLAmqybGYt4QrAmFp17iHND9qL2IFFhxZtP0oacXkZoF1IavyuDkTPbWbinlDePIwWO6gXQCMlXyHJFNIUAX/vfIf/30HRrtzkB6RJE96hY1qlAAPW8b4GDbmgkR0zzI=
Received: from HE1PR0701MB2905.eurprd07.prod.outlook.com (10.168.98.146) by HE1PR0701MB2508.eurprd07.prod.outlook.com (10.168.129.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.6; Wed, 29 Apr 2020 06:29:21 +0000
Received: from HE1PR0701MB2905.eurprd07.prod.outlook.com ([fe80::b909:1134:d9c1:e941]) by HE1PR0701MB2905.eurprd07.prod.outlook.com ([fe80::b909:1134:d9c1:e941%5]) with mapi id 15.20.2958.014; Wed, 29 Apr 2020 06:29:21 +0000
From: Mohit Sethi M <mohit.m.sethi@ericsson.com>
To: "Acee Lindem (acee)" <acee@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-isis-mpls-elc.all@ietf.org" <draft-ietf-isis-mpls-elc.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-isis-mpls-elc-11
Thread-Index: AQHWGjVQqaAFSzGSvUOr39K9RDpIIKiPqp0A
Date: Wed, 29 Apr 2020 06:29:21 +0000
Message-ID: <db960001-7069-53da-d494-f7b12566756c@ericsson.com>
References: <158771396796.16808.7505639544953079846@ietfa.amsl.com> <E17FABFB-FF20-4BB0-8A2A-214A4E5DE04E@cisco.com>
In-Reply-To: <E17FABFB-FF20-4BB0-8A2A-214A4E5DE04E@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [37.33.19.204]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fd4befec-1687-4606-f295-08d7ec06a744
x-ms-traffictypediagnostic: HE1PR0701MB2508:
x-microsoft-antispam-prvs: <HE1PR0701MB25089A41759B121981DA9345D0AD0@HE1PR0701MB2508.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 03883BD916
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0701MB2905.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(5660300002)(110136005)(31696002)(66476007)(66446008)(64756008)(66556008)(6512007)(53546011)(6506007)(66946007)(54906003)(4326008)(316002)(86362001)(6486002)(36756003)(478600001)(2616005)(186003)(26005)(71200400001)(76116006)(8676002)(8936002)(31686004)(2906002); DIR:OUT; SFP:1101;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: T9DA8EWdLPisxfhpYvytrWleCoZwQ6fADKtt1/arIbKbibt6H7YcZXwgRPv8duRgSxr+httkxSOj3HDYe/VDkxcdRcPtUkyPmF9iCzNYO5u4UGYaRzutxRngIjbhGwyNgEk3fOp2UjKsBz7J6qCFhSEShyHAolt4LNBS8pJTHIn2vM8yjC/hmrLeZkqHdXy/DzB0gu+nWAjRDcvrcLp7tfHpKXIJApzqv+fOEa0JTDc9QXpTHaLbapGfkH3JFLxNQiqSy563Ir09zNpeq532sbrIHn9QwVKN9UDvaUaXIpLK5IJC/hgfTVBK+hEP5XyI+mdyopgFFVy7OL9WvNx1vHfnmyT5OnUbrsQYCfc4Qysdmz/alC0lKWO38IE2K4SxaQVh20GjkJs+ENqS8r3+LdLDEh7wDU8mNwrOd5/pmqQwvzPO3hfeN6HB75qTH33FHf3GX1afdxHuLLbzGC0sp6xlREH/lwQ3SetsqOsAbPt2ToQcKOj03usVLDqMAbyWHUHGxZPmZ9f5hjwsJ+cAbw==
x-ms-exchange-antispam-messagedata: K5+W1BcOIclcM85pRMIcsnhsp2UYq88/ocHo7kcodrvNkmtR736EyuttotFvY9wi/fXUWx6g/YgdBiXJqk4OqnlKke1AOh4aqVauaWP1WvzgfRY/cACcIUBdGzl6AS6byoyZWa37mDXx8v6LnI0DsmteuiSGGQwnbkpXsf5RKuPK+BU7aj2kscsM93g8/ezksFPYp4lcJo8yPt24Krad9YBtBDOXOpilmoHs5BoXiMJLR8Lkm1MhCmruveq7ySKKZ7BKKFftFo2B7G/3z/AC6JTvHv2lhoMGwo2duHGe5gLT7IBaHNUiu4li8fBNz6g9FJ7tme34sRCk8DwaNHY/Pb1Oe47lyTzTjNrU9dilbel5GxsyBVLJrktn+W5Y4KWm6FgLkWlMWfi9XQv6DEkkq1pI+tzXBa+g+yFt/G9i0p/M9MvMTsYd6jLTWcaD7Lgd7QcnEnIQo4rEYCjj5V2tapRTFg3oohAuQkGmKIovHocMr4Pnb6oqSGgShZ1RinF+FWrn/U+JOfNPmew1IEe0mdb2dnmRzFW8Io6Py8+z70o1tEXAk/ySiiAxktoD+cm4WD6L20DRVVYKgVH9/p6bAu/uNMXBr2NTeJJfI2YooSrVTWTI9mQyohRmV63D6nPVtnXKIegLDqIu9rpkFEm5KfmXM+/fV5nbe7Px7NYdcCSkOv52gKb0VwDmMrPUWlMEdOIGuT4uKLm+HgSV+92+x1+khEjNCEBMLJY9SEc8kTH7qYFoYm24z7ji+dj153pMT/STkGZwrigmZL1dcxKtfXDgFdtzvZMxbJn1Kj27kn0=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_db960001706953dad494f7b12566756cericssoncom_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd4befec-1687-4606-f295-08d7ec06a744
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 06:29:21.4278 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /V5sPPembm1B3rIrIDkGgA5QI614ioe+by5gSQf6RWg8w5/UQ8g5FRgi5Ns+uGGLZBFWgb+YDgR0uz7kj5g03aAvVPww8WR2voIEtKbxbgg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB2508
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/ECVEqs4VzVcEzQQPkuFFoM_DF64>
Subject: Re: [Lsr] Genart last call review of draft-ietf-isis-mpls-elc-11
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 06:29:32 -0000

HI Acee,

On 4/24/20 3:38 PM, Acee Lindem (acee) wrote:

Hi Mohit,

Speaking as document shepherd. See inline.

On 4/24/20, 3:39 AM, "Mohit Sethi via Datatracker" <noreply@ietf.org><mailto:noreply@ietf.org> wrote:

    Reviewer: Mohit Sethi
    Review result: Ready with Nits

    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.

    For more information, please see the FAQ at

    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq><https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

    Document: draft-ietf-isis-mpls-elc-11
    Reviewer: Mohit Sethi
    Review Date: 2020-04-24
    IETF LC End Date: 2020-05-05
    IESG Telechat date: Not scheduled for a telechat

    Summary: This document specifies how Entropy Label Capability (ELC) and Entropy
    Readable Label Depth (ERLD) are advertised using IS-IS. For advertising ELC, a
    flag in the Prefix Attribute Flags is used. For advertising ERLD, a Node MSD
    Advertisement is used.

    Major issues:

    Minor issues: The document is short and straightforward. For someone like me
    who is not familiar with the routing area, would it make sense to explain why
    signalling ELC information with MPLS is not sufficient (or what are the
    benefits of advertising with IS-IS)?

I guess I'm wondering what you mean "signaling ELC information with MPLS"? With segment routing, the IGPs can be the only choice for signaling ELC capability. I don’t believe this comment requires any action.

I hope that you don't expect a gen-art reviewer to be an expert on every topic. I certainly am NOT on expert on routing. I interpreted the following text in the draft:

It also
   introduces the concept of Entropy Label Capability (ELC) and defines
   the signaling of this capability via MPLS signaling protocols.

to imply that signaling ELC information with MPLS is possible but this draft defines a mechanism for signaling the same information with IS-IS. Maybe the need for this is very obvious for those in the routing domain in which case ignoring my comment is perfectly fine.

--Mohit



Thanks,
Acee


    Nits/editorial comments:

    In section 3, "used as the ECL  Flag" should perhaps be "used as the ELC Flag"?
    In section 4, "IANA for EARLD-MSD" should perhaps be "IANA for ERLD-MSD"?
    In section 6, "ECL Flag (E-flag)." should perhaps be "ELC Flag (E-flag)."?