Re: [Lsr] Opsdir last call review of draft-ietf-ospf-lls-interface-id-06

Sheng Jiang <jiangsheng@huawei.com> Mon, 15 October 2018 02:20 UTC

Return-Path: <jiangsheng@huawei.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 40F30130DF5; Sun, 14 Oct 2018 19:20:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iBiQ6Tb_8wTe; Sun, 14 Oct 2018 19:20:31 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0BDC6129619; Sun, 14 Oct 2018 19:20:31 -0700 (PDT)
Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 0B7D610B8636F; Mon, 15 Oct 2018 03:20:28 +0100 (IST)
Received: from NKGEML414-HUB.china.huawei.com (10.98.56.75) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Oct 2018 03:20:29 +0100
Received: from NKGEML515-MBX.china.huawei.com ([fe80::a54a:89d2:c471:ff]) by nkgeml414-hub.china.huawei.com ([10.98.56.75]) with mapi id 14.03.0399.000; Mon, 15 Oct 2018 10:20:25 +0800
From: Sheng Jiang <jiangsheng@huawei.com>
To: Peter Psenak <ppsenak@cisco.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-ospf-lls-interface-id.all@ietf.org" <draft-ietf-ospf-lls-interface-id.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Opsdir last call review of draft-ietf-ospf-lls-interface-id-06
Thread-Index: AQHUYKTlZoRDQh6OZkGB/CbRMqmpCaUfmd4w
Date: Mon, 15 Oct 2018 02:20:24 +0000
Message-ID: <5D36713D8A4E7348A7E10DF7437A4B929020DCFB@NKGEML515-MBX.china.huawei.com>
References: <153914324720.10676.17623408848748308339@ietfa.amsl.com> <5BBE0B78.10609@cisco.com>
In-Reply-To: <5BBE0B78.10609@cisco.com>
Accept-Language: en-GB, zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.185.119]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/FKlKnNGfc8DKTwjSX3POon8KmB4>
Subject: Re: [Lsr] Opsdir last call review of draft-ietf-ospf-lls-interface-id-06
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Oct 2018 02:20:33 -0000

Thanks for addressing my comments.

Sheng

> -----Original Message-----
> From: Peter Psenak [mailto:ppsenak@cisco.com]
> Sent: Wednesday, October 10, 2018 10:24 PM
> To: Sheng Jiang <jiangsheng@huawei.com>;; ops-dir@ietf.org
> Cc: lsr@ietf.org; draft-ietf-ospf-lls-interface-id.all@ietf.org; ietf@ietf.org
> Subject: Re: Opsdir last call review of draft-ietf-ospf-lls-interface-id-06
> 
> Hi Sheng,
> 
> posted a new version that addresses your comments.
> 
> thanks,
> Peter
> 
> On 10/10/18 05:47 , Sheng Jiang wrote:
> > Reviewer: Sheng Jiang
> > Review result: Has Nits
> >
> > Hi, OPS-DIR, Authors,
> >
> > I have reviewed this document as part of the Operational directorate's
> > ongoing effort to review all IETF documents being processed by the
> > IESG. These comments were written with the intent of improving the
> > operational aspects of the IETF drafts. Comments that are not
> > addressed in last call may be included in AD reviews during the IESG
> > review. Document editors and WG chairs should treat these comments just like
> any other last call comments.
> >
> > This standard track document defines a new option Local Interface
> > Identifier in OSPF Hello and Database Description (DD) packets as an
> > extensions to OSPF link-local signalling. This document is short and
> > well written. It is READY with a couple of Nits, which should be easily fixed.
> >
> > Major issue: no.
> >
> > Minor issue: no.
> >
> > Nits:
> >
> > Unused Reference: 'RFC8379'. There is no relevant text. Either some
> > text should be added or this reference should be deleted.
> >
> > In the IANA section,  "18 - Local Interface Identifier TLV". Normally
> > the value that is actually assigned should be left to IANA. Here, it
> > should be TBD as a draft.
> >
> > Regards,
> >
> > Sheng
> >
> > .
> >