Re: [Lsr] Rtg-Dir Last Call review of draft-ietf-lsr-flex-algo

"Acee Lindem (acee)" <acee@cisco.com> Fri, 11 December 2020 17:46 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0DC103A0D3D; Fri, 11 Dec 2020 09:46:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.601
X-Spam-Level:
X-Spam-Status: No, score=-9.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=IKN0noi4; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=L1BEuDV/
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2CURUGrzKLFV; Fri, 11 Dec 2020 09:46:01 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4E043A0D39; Fri, 11 Dec 2020 09:46:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6274; q=dns/txt; s=iport; t=1607708761; x=1608918361; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3RGiSiMuHPWYAzQjXiXTJS/IFdPKO1zUIJJ4ZJ99LeM=; b=IKN0noi4wZbjMtDbnoU+MZpCYeUknvbwjnUeki9Yoj19X53wtVoDjufE 5wCcesiebKhY4h8l39pGv+2iGsldeDPbPu+C3Pj9r7OZmmBOsgFzNf74y bfn2DhzwMkRU57uVAMLd5MK+yGdc17E0YwQNLNHSEy6foV3t69FvEsDri U=;
X-IPAS-Result: =?us-ascii?q?A0DJAgAIsNNfmIoNJK1iHQICCRQFBUGBT4FSUXxbLy4Kh?= =?us-ascii?q?DWDSAONUwOBBZgFglMDVAsBAQENAQEYDQgCBAEBhEoCF4FoAiU4EwIDAQEBA?= =?us-ascii?q?wIDAQEBAQUBAQECAQYEFAEBAQEBAQEBhjYMhXIBAQEDAQEBEBEGCwwBASwLA?= =?us-ascii?q?Q8CAQIEAhQEAgImAgICJQsVEAEBBAENBSKDBAGCVQMOIAEOkmKQawKBPIhpd?= =?us-ascii?q?oEnC4MEAQEFgTMBE0GDCBiCEAMGgQ4qgnWCaQoIPEKGWRuCAIERJxyCIAcuP?= =?us-ascii?q?oJdAQECAQGBWxeDADOCLIFZgU4EUx8COSoaIxUKBCALHgo4klmTUpAvgQYKg?= =?us-ascii?q?nSJIpIlAx+DJYomhViPF5QBiwyRRyAQhCMCBAIEBQIOAQEFgW0hgVlwFTsqA?= =?us-ascii?q?YIKAQEyUBcCDY47g1eFFIVEdAI1AgYBCQEBAwl8iEQBgRABAQ?=
IronPort-PHdr: =?us-ascii?q?9a23=3AiJMaMRetn6tgZ4E2EjsDJOfRlGMj4e+mNxMJ6p?= =?us-ascii?q?chl7NFe7ii+JKnJkHE+PFxlwaTAdfX7vtegKzXvrzuH2sa7sXJvHMDdclKUB?= =?us-ascii?q?kIwYUTkhc7CcGIQUv8MLbxbiM8EcgDMT0t/3yyPUVPXsqrYVrUry6+6DcIEV?= =?us-ascii?q?P+OBZ7YOPvFd2ag8G+zevn/ZrVbk1Bjya8ZrUnKhKwoE3Ru8AajJEkJLw2z0?= =?us-ascii?q?7Co2BDfKJdwmY7KA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.78,412,1599523200"; d="scan'208";a="612926901"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 11 Dec 2020 17:45:59 +0000
Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 0BBHjxGV012482 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Dec 2020 17:45:59 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Dec 2020 11:45:59 -0600
Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Dec 2020 12:45:57 -0500
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 11 Dec 2020 11:45:57 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNB0OrNu5p/XkSB2AORAyY+aVkfpzuAMs2HSc5rTpZ2wrAB5wMLSs8bP9qG303g31GDRSwTQuFgZjybjhxOPmjElXizdTCmJ8J/1/GFzd4dnOVdxxyrcU4s4dHLwBHgM5QbNlwzxEqdy5/4LcoBmh9wAicSQ6QJLM9lO5XPidS+H2HqvfhMTJw+z54TLSqlaakxqhOmAW/pEnmPohrkTs8adWtXtBquDctUBFKPBRARVbPxm8d79FKhZi3rwuklZ3oOtaoUSDDwJJQ68zKe8jA9xfV8OmRzSzECGpSo+56vV6q7eZHMO4mcmWZIfLxOth7msY2meFAbV3p2sChPq3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RGiSiMuHPWYAzQjXiXTJS/IFdPKO1zUIJJ4ZJ99LeM=; b=YyUWdMysgPCRkeRzkzK20hqvDg4z/LFgGdwGIKGEKY4YuhzwNxawmh2V/ZrpaWA79GS7WyQVKJEGqmxB1NEXPh7HnjvRNM2OnKwketkBTHGw41kaiknnTA7m7bvjje37Cqr3LcGh8HdxkttiI1CihjN804ZOoR1ccIz3SqJfl2t2Hbd14IhBpcNpDDyUtBuOt0jDcy1AD8OIm5yLNmdEZDor0ldifLwQGO6GI3AUBWuTLu+UIqCEzhbpdIMzHc6V5ASxNuC1srR2fgRfdgRwQ5zz8UUqo3w8LZRG+sBvEZf5YfNVpozNkIlvPgo/NBL2rEILMf+tsAB5S7ycAwFrlw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RGiSiMuHPWYAzQjXiXTJS/IFdPKO1zUIJJ4ZJ99LeM=; b=L1BEuDV/PBEq5yAXNZZz607gA8Qrs0FIqJ1c3ih5kRcXcoTPIP5WHDmYyzbtbEu7yLvbJSlACGQ46DP1PQspIOkU2S+xKtaUVJb0xqkXCzMBgR9n0l141317mHlks5jxt880pHUNUJYCVp7CzssXfwQ2WuN7J7P+4H0VZrH4lB4=
Received: from BYAPR11MB2887.namprd11.prod.outlook.com (2603:10b6:a03:89::27) by BY5PR11MB3960.namprd11.prod.outlook.com (2603:10b6:a03:185::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Fri, 11 Dec 2020 17:45:54 +0000
Received: from BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::65a7:2fad:a960:2557]) by BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::65a7:2fad:a960:2557%3]) with mapi id 15.20.3654.015; Fri, 11 Dec 2020 17:45:54 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Peter Psenak <ppsenak=40cisco.com@dmarc.ietf.org>, Eric Gray <eric.gray=40ericsson.com@dmarc.ietf.org>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: [Lsr] Rtg-Dir Last Call review of draft-ietf-lsr-flex-algo
Thread-Index: Adaj5RbuL4NRT3uMSN6SXWsPfNq1nQCF4WSACm+8pAA=
Importance: high
X-Priority: 1
Date: Fri, 11 Dec 2020 17:45:54 +0000
Message-ID: <9320E440-6C52-467D-B43E-E5D30366CC81@cisco.com>
References: <MN2PR15MB31035D98D51D3A1E6C3B50F797030@MN2PR15MB3103.namprd15.prod.outlook.com> <a0cc19a8-b9c9-f41e-9b76-c15454d7e3b7@cisco.com>
In-Reply-To: <a0cc19a8-b9c9-f41e-9b76-c15454d7e3b7@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.43.20110804
authentication-results: dmarc.ietf.org; dkim=none (message not signed) header.d=none;dmarc.ietf.org; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [136.56.133.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f25f991f-23ae-4b8a-c9e1-08d89dfc9c00
x-ms-traffictypediagnostic: BY5PR11MB3960:
x-microsoft-antispam-prvs: <BY5PR11MB396059122A8A0614BD4FC79DC2CA0@BY5PR11MB3960.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jEWTAPbG0AfPs8Kh3HpKl/w25x/sURcR7vJyl7rxXz7gxCtXUwqpT5UBj9gGJiq3L4PFXvgLUZVTAyyiSsMrRbOBr3vRMCntLq2Sc6dM4f2nXas5ySPG1v3p2mxI7Sx4cHd3QX0nN6knpVW6h0bsFKP6PUfAWvG8gjxHryOyW941rFil1PBGuW8jzoUAxvXMJnr+aUKVNwre/97neofqSZK9ERst7bwjD8RhsyCnR7w2avfaViLhKF9sdmlDUEAURQ7sKXi6RWkvxE2vAcLJEeSiVPxfciv8DNi7mtSfXCoBNPbeR9XNDSgY166WQ/Nu5uCgbenqNJkZ1/2o5fL7+RDY6GAkcpEueBurLvdfwojlHbRZAgsRcGXZoxYd/sRbolRNpQg1ok/YPbURe9DVCIJI+8LHuFHSbujt4LUG0y+ZkRCAkwd2+ipUlxWGzlCSoz1hI56jiCijqG7/MYpBEQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2887.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(376002)(136003)(36756003)(66556008)(71200400001)(54906003)(110136005)(186003)(508600001)(83380400001)(4326008)(6486002)(6512007)(66446008)(53546011)(66946007)(966005)(6506007)(5660300002)(76116006)(26005)(2906002)(86362001)(8936002)(8676002)(64756008)(33656002)(66476007)(2616005)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?utf-8?B?MWpXMFp6RGR3ZWtHZFBVVDNuVDUyZTBlWW9UbW9XVGc3L2haVVUrdDNxb1Fa?= =?utf-8?B?UzRZOVZxNWtpK3d3Q29TTUdlWEMyaHY5dXV5d1NtUGpJbWxNTjlXRlpyaThp?= =?utf-8?B?OUlwME9MQkhON3RqME5UZ2lKQlFBcTk3SDM5RWhnUng1dk5Qdkhub3NsaFN0?= =?utf-8?B?djlCS20xZDlxVmlRNzEyeTJlVmZqWWhqWFNDQzk2L2g0MmJ4cHFSS21LR1lu?= =?utf-8?B?ZU8vS3ZJeDZaSGk1L2Q0SGFBSGt6NnpraGRCL25HbnZVNEs3RXIvWEN5YXNQ?= =?utf-8?B?b211UWIzc0NXem1ZQU0vdXJ5bWxQNGlPUk9nUE1obUt2R2dVbTFRMlIxUnk3?= =?utf-8?B?RDJLdHFJZGJqQnYxOHN3Q0YvUmg2Y284T3RsS0VZSGlFRE03NzN5bWtzZUp5?= =?utf-8?B?UDI3QmtJVXpYcjFTN3ltSEh6ejBQQWFxU3V3L0J1aktYY05QRG4zN1U4NXFx?= =?utf-8?B?a1hydFowWkZCa2tPRnJqcTFLYUJlSC9ZcldIdWJRN1l6OGNvYjIzVS9wQUVh?= =?utf-8?B?SDR4Vys0OElQemljQXMwSG5tK2oyTjVpMThOWm93K1pyTExJcFFLVk94VVVk?= =?utf-8?B?ODZWM3dhSlUzTmZ0TkZ4bkFFL1VJR3pWVDNDUVEvdCs1T0dFaTdhTk5aVmN4?= =?utf-8?B?bVJ0K1IwNGFJR2RCWng4R0dFZXg1eXQwdnBwS1p1eWJscDFkMVhRRFZCM1Zy?= =?utf-8?B?UVBzME9ZeTBjQ2dzb1phMkZ5VnpmTmgyU3A2ZGpWcUwzMEtPV2hlQVhvaEx5?= =?utf-8?B?WC9HZ2VuUXBhM053NzM2c0RYN0doSkgvdm1pRmpuR29KVUlXYjNUTXRXWS9i?= =?utf-8?B?NklJdjBLbG5IVVo0UXhDSWt2dWJZMFNYTzlQbDlzQ29ZWnFaNmRKWkJMc1NX?= =?utf-8?B?dFlBeHU4MkFQSWpWc0t6VExFdDIzVGJwRytBSUgwdTE3S0JKOXJGeVpDaVl5?= =?utf-8?B?M0tPZVlnSDlLZ3EyZXZLd3lqazR6ZUx3TUF1NUlhMmZ2dlFrQ0EvM0lRSHMv?= =?utf-8?B?RmJLeUo4aFN1S3M4b0t6NU1ZaUZkK3lDQnJtdUhmVVVkT0xkVllLWnVZQkFW?= =?utf-8?B?djVSdExKN3NVYmlGbUYvZlMzb2R6eUFwNXhnZTIrVStJNGpaSnFHbkp3d1B2?= =?utf-8?B?T2hEUisydEF5OXlUNTRqdzV2MitoN1lGdWhESDFoSkY5Y3A4a0lxMks2YmJC?= =?utf-8?B?ZXViN3BVU0s1OXZvblRuMXZ3SzNWY20vejl3Z1FpZzBZSVRISUYzRDNnTk5x?= =?utf-8?B?NGwvdDgvSGdjcEdsdlphVVlhMDRhRFNDMDJoYzJVNWFYZXZoVkdqZ2hVVm04?= =?utf-8?Q?rTeh3hEMXZEqeyaULLbVqREZuVGFWm5LFv?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <369F13497F0B1C47957DF81123CB76A3@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2887.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f25f991f-23ae-4b8a-c9e1-08d89dfc9c00
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 17:45:54.6722 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kxs/FEibBkLg7s1Jr2SiPXB/Mvqx8/PA+deg4Hz//NKAdmiDYzUxip5xF8wOtYgh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3960
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com
X-Outbound-Node: alln-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/G9sxts_r98wad-ZQ4VRr3RQLSDc>
Subject: Re: [Lsr] Rtg-Dir Last Call review of draft-ietf-lsr-flex-algo
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2020 17:46:04 -0000

Hey Eric, 
The Routing Directorate review is marked completed (giving that the comments were Nits):

https://datatracker.ietf.org/doc/draft-ietf-lsr-flex-algo/reviewrequest/13840/

We are assuming that you are happy with Peter's responses to your comments. Thanks again for your review. 

Thanks,
Acee

On 10/19/20, 5:46 AM, "Lsr on behalf of Peter Psenak" <lsr-bounces@ietf.org on behalf of ppsenak=40cisco.com@dmarc.ietf.org> wrote:

    Hi Eric,

    thanks for the review, please see inline:


    On 16/10/2020 20:48, Eric Gray wrote:
    > Hello,
    > 
    > I have been selected as the Routing Directorate reviewer for this draft. 
    > The Routing Directorate seeks to review all routing or routing-related 
    > drafts as they pass through IETF last call and IESG review, and 
    > sometimes on special request. The purpose of the review is to provide 
    > assistance to the Routing ADs. For more information about the Routing 
    > Directorate, please see 
    > https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir.
    > 
    > Although these comments are primarily for the use of the Routing ADs, it 
    > would be helpful if you could consider them along with any other IETF 
    > Last Call comments that you receive, and strive to resolve them through 
    > discussion or by updating the draft.
    > 
    > Document: draft-ietf-lsr-flex-algo-12.txt
    > 
    > Reviewer: Eric Gray
    > 
    > Review Date: 16 October, 2020
    > 
    > IETF LC End Date: Unknown
    > 
    > Intended Status: Standards Track
    > 
    > Summary:
    > 
    > This document is well organized, relatively easy to read, and probably 
    > ready for publication, but has one potential minor issue and a very 
    > small number of NITs that might be considered prior to publication.
    > 
    > Major Issues:
    > 
    > None
    > 
    > Minor Issues:
    > 
    > The statement in section 15 (Backward Compatibility) - "This extension 
    > brings no new backward compatibility issues" - seems somewhat flip.
    > 
    > I suspect that a tiny bit of analysis would not hurt.
    > 
    > The extensions in this draft are clearly intended to work in an 
    > environment where routers that _do_not_ support these extensions are 
    > also deployed, but apparently relies on configuration of those routers 
    > that _do_ support the extensions to address this.
    > 
    > That seems correct.
    > 
    >  From my reading of the draft (which I have not closely followed for its 
    > entire development), while it introduces at least one new TLV, the OSPF 
    > routing protocol has well defined handling for TLVs that are not 
    > understood - hence the introduction of one or more new TLVs should not 
    > present a problem in OSPF.
    > 
    > Obviously Sub-TLVs of the new OSPF TLV type will not introduce 
    > compatibility issues.
    > 
    > I assume (but do not actually know) that a similar situation exists for 
    > the new ISIS FAD Sub-TLV of the existing TLV Type 242 - i.e. - ISIS 
    > presumably has well defined handling for sub-TLVs (of at least type 242) 
    > that are not recognized.  If so, than the new Sub-TLV types defined are 
    > also not an issue.
    > 
    > Shouldn't this section say something along these lines?  I suspect that 
    > it would be more helpful if verifying the content of the 
    > "considerations" sections were not left as an exercise for the reader. 😊

    What about the "Backward Compatibility" section to be updated to:


    "This extension brings no new backward compatibility issues. ISIS, 
    OSPFv2 and OSPFv3 all have well defined handling of unrecognized TLVs 
    and sub-TLVs, that allows the introduction of the new extensions, 
    similar to those defined here, without introducing any interoperability 
    problems."


    > 
    > NITs:
    > 
    > In the Introduction, the phrase "must often be replaced" seems very 
    > slightly problematic (especially given this is a standards track RFC 
    > wanna-be).  Would it be better to say "is often replaced" instead?


    done.

    > 
    > In section 17.1.2 and 17.2 - '... a "Interior Gateway ...' should 
    > probably be '... an "Interior Gateway ..." in both cases.

    done.

    thanks,
    Peter



    > 
    > --
    > 
    > Eric
    > 

    _______________________________________________
    Lsr mailing list
    Lsr@ietf.org
    https://www.ietf.org/mailman/listinfo/lsr