Re: [Lsr] Suresh Krishnan's No Objection on draft-ietf-lsr-isis-rfc7810bis-04: (with COMMENT)

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Thu, 20 December 2018 15:43 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F1D6130E6D; Thu, 20 Dec 2018 07:43:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xheUrv8-qxob; Thu, 20 Dec 2018 07:43:07 -0800 (PST)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0DB212872C; Thu, 20 Dec 2018 07:43:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=25248; q=dns/txt; s=iport; t=1545320586; x=1546530186; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=pJB6NbigKKnV4i54++h8BL/GI4XMpLgJ6NjPEjvniCc=; b=OSCWzeXV4pSxBuAcsxeuFbB620gJxZ1I/V7F4InvpmVQbwnQJZ7unPb6 Tb1FmcK8p+mmP4JitEL8crTs2XnDvTJjBezgQYqLhsXL2dEQVNNVa/Lw/ Amm5dn6FO91DKdrQO+uow9Dzn2jkqxrX5OeHSmG57NjQHI7sxsFNAO1Ql 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAABGtxtc/4MNJK1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgQ1ILmaBAicKg3OIGYt7gg2JFY5IgXs?= =?us-ascii?q?LAQGEbAIXglUiNAkNAQMBAQIBAQJtKIU8AQEBBCMKTBACAQYCDgMEAQEoAwI?= =?us-ascii?q?CAh8RFAkIAgQBDQUIgxuBHUwDFYwKm12BL4d8DYIdjD8XgUA/gRGDEoJXgmC?= =?us-ascii?q?CUoJXAotChAKGWopsMwkCjjGDKiCBX4hQhy6JTYEGhQeKDAIRFIEnHziBVnA?= =?us-ascii?q?VO4JsgicXEo4LQTGMGiqBBIEfAQE?=
X-IronPort-AV: E=Sophos;i="5.56,377,1539648000"; d="scan'208,217";a="495689061"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 15:43:05 +0000
Received: from XCH-RCD-008.cisco.com (xch-rcd-008.cisco.com [173.37.102.18]) by alln-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id wBKFh5IF011837 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 20 Dec 2018 15:43:05 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-008.cisco.com (173.37.102.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 20 Dec 2018 09:43:04 -0600
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1395.000; Thu, 20 Dec 2018 09:43:04 -0600
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Alvaro Retana <aretana.ietf@gmail.com>, "Acee Lindem (acee)" <acee@cisco.com>, Suresh Krishnan <suresh@kaloom.com>
CC: "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, The IESG <iesg@ietf.org>, "Ketan Talaulikar (ketant)" <ketant@cisco.com>, "draft-ietf-lsr-isis-rfc7810bis@ietf.org" <draft-ietf-lsr-isis-rfc7810bis@ietf.org>
Thread-Topic: Suresh Krishnan's No Objection on draft-ietf-lsr-isis-rfc7810bis-04: (with COMMENT)
Thread-Index: AQHUmBSG6Rzyix0Lm0yLgi4C8qB8xaWHCCqggAAVv4CAALblgIAAFwwA///UpMA=
Date: Thu, 20 Dec 2018 15:43:04 +0000
Message-ID: <0b95b1e0145b4542b703b9e5adc10bf3@XCH-ALN-001.cisco.com>
References: <154527669905.1822.11138986536679857134.idtracker@ietfa.amsl.com> <fdce9dee40c1440587f87618e9accd0d@XCH-ALN-001.cisco.com> <A63B8724-C84D-4A92-A747-865B377A6AD8@kaloom.com> <F68B4FEA-46A3-47EF-AEBA-E7978A29AA7C@cisco.com> <CAMMESsztOLQT_7JMb-Sk-zWTT+Qh27zk7q7kDjeZB98mwxVTpw@mail.gmail.com>
In-Reply-To: <CAMMESsztOLQT_7JMb-Sk-zWTT+Qh27zk7q7kDjeZB98mwxVTpw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.154.131.23]
Content-Type: multipart/alternative; boundary="_000_0b95b1e0145b4542b703b9e5adc10bf3XCHALN001ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.18, xch-rcd-008.cisco.com
X-Outbound-Node: alln-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/HRmh8KXOfA57le7k5nPLQWvgixU>
Subject: Re: [Lsr] Suresh Krishnan's No Objection on draft-ietf-lsr-isis-rfc7810bis-04: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 15:43:10 -0000

Folks –

Here is the relevant paragraph from the Appendix - some emphasis added.

“As a means of interoperating with implementations which do not
   conform to the corrections defined in this document, implementers may
   wish to consider temporarily supporting sending and/or receiving the
   form of the sub-TLVs using a length of 5 and including the RESERVED
   field.  However, the intent of this revision is to specify one and
   only one normative behavior.  Any existing implementations which
   encode the sub-TLVs using a length of 5 are expected to be revised to
   conform to the normative behavior specified in this document.”

Several things of note regarding this paragraph:

1)It was put in in response to a review comment from the Document shepherd:

<snip>
Hi All,

I was reviewing this draft as the Shepherd. It is a fairly simple and straightforward bis update to RFC7810 to fix an encoding error.

There is one point that I would like the authors and WG to consider.

The draft in the appendix talks about two interpretations of the erroneous sub-TLVs and from the conversation on the list I get the impression that there are at least two implementations out there which did different interpretations. Do we want to consider putting in a suggestion (i.e. not normative perhaps) that implementations updated to this specifications accept the sub-TLV with the Reserved field included and size 5? So they don't consider such an encoding as error or malformed on reception?

Thanks,
Ketan

<end snip>

I agreed with Ketan’s comment and so the text was added.

2)The text is very careful to comply with RFC 8174. It uses lowercase “may” – therefore clearly non-normative.  It also unambiguously states that implementations written using a length of 5 “are expected to be revised”.

3)If you read this from the POV of someone who implements the protocol extensions, I think this text is useful in providing context for what interoperability issues might be encountered in the field. Even though the implementation we know of that used a length of 5 has been fixed – there are still older versions of that code deployed.  It suggests – but clearly does NOT require - what could be done (at the implementer’s discretion) to deal with the non-conformant implementations.

I fail to see how this is in any way confusing.

I think the document is better off as is – but if you folks insist I will remove the text – though clearly I disagree with this choice.

    Les



From: Alvaro Retana <aretana.ietf@gmail.com>;
Sent: Thursday, December 20, 2018 4:01 AM
To: Acee Lindem (acee) <acee@cisco.com>;; Les Ginsberg (ginsberg) <ginsberg@cisco.com>;; Suresh Krishnan <suresh@kaloom.com>;
Cc: lsr-chairs@ietf.org; lsr@ietf.org; The IESG <iesg@ietf.org>;; Ketan Talaulikar (ketant) <ketant@cisco.com>;; draft-ietf-lsr-isis-rfc7810bis@ietf.org
Subject: Re: Suresh Krishnan's No Objection on draft-ietf-lsr-isis-rfc7810bis-04: (with COMMENT)

On December 20, 2018 at 5:38:51 AM, Acee Lindem (acee) (acee@cisco.com<mailto:acee@cisco.com>) wrote:

We only know of one implementation that has the wrong encoding and we have fixed that one.

I then see no harm in removing the “generosity” paragraph.  As Suresh suggests, it will make the document even clearer.

Thanks!

Alvaro.