Re: [Lsr] Genart last call review of draft-ietf-ospf-yang-23
"Acee Lindem (acee)" <acee@cisco.com> Tue, 30 July 2019 00:42 UTC
Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5403B120026; Mon, 29 Jul 2019 17:42:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Jw0tnUOn; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Bnq74lWZ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id frGI4HoXR6p2; Mon, 29 Jul 2019 17:42:54 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33DEB120019; Mon, 29 Jul 2019 17:42:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2350; q=dns/txt; s=iport; t=1564447374; x=1565656974; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Gh0a7w5M/6GaEf9svdWixWUoLD2f1hy5RsxMegcuNE0=; b=Jw0tnUOn23FripM8Z8KL8PSWH3RMk4/ShUEKzsjh8leZC7Ilaw2dp+Pm vfRWCXHh/MFWUzQb5xUDyUDTtqqj78pQRMSx4OcqYA1DzW2CB/U2k45Oe 44ObHzQnyiOvJ+6BigeRgNJV4tSlcoTj6DGrAwOYVnMfVWRusaagdOhyG c=;
IronPort-PHdr: 9a23:JODoBR2TtHeOzG3JsmDT+zVfbzU7u7jyIg8e44YmjLQLaKm44pD+JxGCt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8TgZdYBUERoMiMEYhQslVceOBEDTJ//xZCt8F8NHBxdo
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AIAADzkT9d/40NJK1mGgEBAQEBAgEBAQEHAgEBAQGBUwUBAQEBCwGBQ1ADbVUgBAsqhB6DRwOEUogygjYll1OBLoEkA1QJAQEBDAEBIwoCAQGEQAIXglUjNAkOAQMBAQQBAQIBBm2FHgyFSwIBAxIREQwBATcBDwIBCA4GBgImAgICMBUQAgQBDQUigwABgWoDHQECDKFjAoE4iGBxgTKCegEBBYUOGIITAwaBDCgBi18XgX+BEScME4JMPoJhAoRsMoImjFaCKJt9CQKCGoZbiUaDcxuCLocljjuNO4dKkAwCBAIEBQIOAQEFgVA4gVhwFWUBgkGCQgwXg06FFIU/coEpjHIBAQ
X-IronPort-AV: E=Sophos;i="5.64,324,1559520000"; d="scan'208";a="607072831"
Received: from alln-core-8.cisco.com ([173.36.13.141]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 30 Jul 2019 00:42:52 +0000
Received: from XCH-ALN-007.cisco.com (xch-aln-007.cisco.com [173.36.7.17]) by alln-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id x6U0gq5t012771 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 30 Jul 2019 00:42:52 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by XCH-ALN-007.cisco.com (173.36.7.17) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 29 Jul 2019 19:42:51 -0500
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 29 Jul 2019 20:42:50 -0400
Received: from NAM01-SN1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 29 Jul 2019 19:42:50 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOIam5TfxGR3/pzkuhJwg6CxP9n6Tz9QsOlIZS1znWjZvw0t47R4NC/JWeGvokN5rMGHMJgTuiieMTD0ZNrTxXoRVdcQltYhuKWJhM7AQnUmBitZFe16A1LcwciR3ZBACJ0nWFQOc+5hNIQYAVuSC0b6y/ksE3TP4h2bbQ2RiCsgvjLSMhHUZbr/VicgLXMLXpuq4Y5odr8g1ajYMe8c9FvrK6/bvwnSichzvwvkWwr13LVflVwEIvEsgKyuT/7GKenCWaH5FqPgk+JL9B6oFKOHCRp4hBQUvo6y9EnqfvvT9nDBAgmYunReyKxelUjghVZZ7r5wxd7+UuDMI0sRbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gh0a7w5M/6GaEf9svdWixWUoLD2f1hy5RsxMegcuNE0=; b=TME0zWCXkX69sgQYAWhF4S3iCRsX+inUc93b2KbDqasDjblKKWdNKmGdu29NzSsGOir0DtV0D5wGZkUNfJTb7wKXz/++MBDV5OHEPUF3+LHZKDIH0YivCSOkfjM/dCFKc+lZorLl6G/H3HsMU0pyO8qBL4mlbOrgzfa5+KpekuCOVAWYsP0oo6p4wq/eTTKBiDn9aKPL1nS7nd4U7YUADIZgIe/0aHcbjx9kXwJBSD5lG6ryAbIlosaOoiEgreS+YgB1BHQPiF5pi/ILBjofIBInDJ47J/6eUo+DFyMvnGNE4rZx5m0fBwgo30Bm6YSrpQiLWDi0l5Iq6KHsCLJmGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cisco.com;dmarc=pass action=none header.from=cisco.com;dkim=pass header.d=cisco.com;arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gh0a7w5M/6GaEf9svdWixWUoLD2f1hy5RsxMegcuNE0=; b=Bnq74lWZG1od/FG700YxzIQF/QmvmmdDTF+lMi9nuzRlChzQ06rAbFO06VKPO42UttFqHgs2kIn8sbb+YypVWZsKgyZom0EHjq0jmfyMxIPs77BBykEOkXA2t7ObLQrrxNwgXtRgO+1yZnyLbZyKbrtotpFqIc+ZgUcqFoiaHm4=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB3582.namprd11.prod.outlook.com (20.178.251.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 30 Jul 2019 00:42:49 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0%3]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 00:42:49 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Erik Kline <ek@google.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-ospf-yang.all@ietf.org" <draft-ietf-ospf-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-ospf-yang-23
Thread-Index: AQHVPPR6mHQXeGvFVUKDIlXhTUf+DabiInWA
Date: Tue, 30 Jul 2019 00:42:49 +0000
Message-ID: <0C3EBAA4-3A40-4207-AC63-752E4D82EA16@cisco.com>
References: <156340486027.25730.15500316030505591807@ietfa.amsl.com>
In-Reply-To: <156340486027.25730.15500316030505591807@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1003::98]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d041d880-9ba7-463b-198a-08d71486d92a
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB3582;
x-ms-traffictypediagnostic: MN2PR11MB3582:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB358274EDB09EB027E59CD878C2DC0@MN2PR11MB3582.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0114FF88F6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(51914003)(189003)(199004)(53936002)(25786009)(8676002)(102836004)(229853002)(81156014)(99286004)(81166006)(6486002)(7736002)(5660300002)(446003)(8936002)(305945005)(4326008)(6306002)(6436002)(6512007)(46003)(54906003)(110136005)(316002)(478600001)(11346002)(186003)(6506007)(2906002)(68736007)(76176011)(486006)(14454004)(36756003)(6116002)(71190400001)(2616005)(476003)(86362001)(71200400001)(33656002)(256004)(66946007)(6246003)(64756008)(66556008)(66446008)(76116006)(2501003)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3582; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: vLtRwJgC8Aidk0yHguy7XbmS/xfJFhlam7rshn+rNqo4np+goc4N3/j/g7ZJzUUMucbLFTlqcnrIBQvqIhOq3Eq3AkKRhtT0NNjvzdywzHsLnRF/V2VO0ax/jb/ia0kgAoHGelmZRTpt4CD45F6K/Op1hJaKRjMuzw5ssXYHDPA803O5hLnS4WduscXU5SPjC65Xu4CweNrFBJoYGVEKmrzwtmTYyEeN9eETg0sfiGLdL6awXxFaPxy+Okjs4IM+RU91tYkOF3Dn4B4/u01/lEoj3hpngTo3N9tRnqDt/sr0tRt8IHRk2GcvZe8Xte6d5im1ExPi9jRPC1oFGKp575trEFn9ZzfkTCv8P12JKGiIqxDCgimQdGRSbOmz3uV5lG0kA7ijDsGUKBTzgN2jnePalgm6sG+QE5n1Lr2WykM=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4032236B3BAF47458C6BC8AED52FDBA6@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d041d880-9ba7-463b-198a-08d71486d92a
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 00:42:49.6203 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: acee@cisco.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3582
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.17, xch-aln-007.cisco.com
X-Outbound-Node: alln-core-8.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/HwVswOOv66gLLeMxKtw7Bo3S2vI>
Subject: Re: [Lsr] Genart last call review of draft-ietf-ospf-yang-23
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jul 2019 00:42:57 -0000
Hi Erik, Thanks for the review. The nits will be fixed in the -24 version. Thanks, Acee On 7/17/19, 7:08 PM, "Erik Kline via Datatracker" <noreply@ietf.org> wrote: Reviewer: Erik Kline Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-ospf-yang-?? Reviewer: Erik Kline Review Date: 2019-07-17 IETF LC End Date: 2019-07-17 IESG Telechat date: Not scheduled for a telechat Summary: Major issues: Minor issues: I feel like the "version" text in 2.3 was confusing. The first thing I did was glance back up the overview where I (a) didn't see "version" mentioned and (b) initially thought that "af" was maybe a proxy for "version". But then later on it seems that "version" is only a mandatory property of the LSA. I'm not sure that I have concretely useful suggestions for improving this text, and in fact it might well be that for expected readers of the document this is in fact a non-issue. Just thought I'd relay my experience. Nits/editorial comments: Page 25: NMDA RFC is 8342, not 8242. Page 81: references draft-ietf-bdf-yang-xx.txt. This is referenced elsewhere in the doc (correctly), so I think just remove the -xx may be fine?
- [Lsr] Genart last call review of draft-ietf-ospf-… Erik Kline via Datatracker
- Re: [Lsr] Genart last call review of draft-ietf-o… Acee Lindem (acee)