IETF Logo Mail Archive

Re: [Lsr] Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Fri, 16 August 2019 19:33 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F236F120815; Fri, 16 Aug 2019 12:33:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=YgoGQ4pX; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=mxBSVxx/
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QXLGnmCB-aOW; Fri, 16 Aug 2019 12:33:13 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A8491200EB; Fri, 16 Aug 2019 12:33:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3326; q=dns/txt; s=iport; t=1565983993; x=1567193593; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8R/JEEZ0izfQOWfDs/rnVqw26bn+SotT6fwjFTrsExc=; b=YgoGQ4pX/0YPReSpsqWHXOZtdn5rHQ/x7X/J60qJuYzvzWa52OmQz08D BklT6fdiol2PPnVke5D/0hXzVAWVZbjjm/mdEwQ8hg1f/oNREJJ3nVlQw pm1YYQIxgJt1yiwiQe6w6lBcrvpRXmvqf1cFbSwJIjRIdKFv8bstjvPvj U=;
IronPort-PHdr: 9a23:q5I0UhdDpCMAyxbtGqcpG8xRlGMj4e+mNxMJ6pchl7NFe7ii+JKnJkHE+PFxlwGQD57D5adCjOzb++D7VGoM7IzJkUhKcYcEFnpnwd4TgxRmBceEDUPhK/u/YC08B85PTlBN9HCgOk8TE8H7NBXf
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CqAACJA1dd/5tdJa1lGgEBAQEBAgEBAQEHAgEBAQGBZ4FFUANtVSAECyqEH4NHA4p5glyXY4JSA1QJAQEBDAEBIwoCAQGEPwIXgwMjOBMCBQEBBAEBAQIBBgRthScMhUoBAQEBAgESEREMAQE3AQQHBAIBCBEDAQEBAwImAgICMBUICAIEAQ0FCBqDAYFqAw4PAQIMn0cCgTiIYXOBMoJ6AQEFhQMYghQJgQwoi2kXgUA/gRFGgkw+glYLAoFjgwkygiaMbIIpnEAJAoIdhmSJWoQQgjFthkOOYY1Yh2GQJwIEAgQFAg4BAQWBZyGBWHAVgycJgjmDcoUUhT9yAYEojHMBAQ
X-IronPort-AV: E=Sophos;i="5.64,394,1559520000"; d="scan'208";a="311847325"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 16 Aug 2019 19:33:09 +0000
Received: from XCH-RCD-009.cisco.com (xch-rcd-009.cisco.com [173.37.102.19]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id x7GJX9gf014166 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 16 Aug 2019 19:33:09 GMT
Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-RCD-009.cisco.com (173.37.102.19) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Aug 2019 14:33:09 -0500
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Aug 2019 14:33:08 -0500
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 16 Aug 2019 15:33:08 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=erdznRsFcsLFTCvyhlfiL8q1TS6gCvhdxe/1aXqs9QyITm7kg8R2LqjaGtd1UDalUO3ZNvYcsTvbxN9cWMFLNaXcwWz0s/Lgc9p4pciDXvcKqpJ7jKf/2eKH8VmR6AtICp5PjUg8fWnLeQ6cJ99kwV0491qLIS6qpG2TXgRLgpszRZROdMbMZwfVAa/AuscCbOhCtjETKmcfS65DW+OlWG6pP6DoE6EmkejbBAzxvBfcIZtetlNES+V5TYiNQX9wuVkF3oe1ajF9EKolwua+nSIL1u2HWkBzQTzyOUTCUMyvtw0OkMnA90W5Sg6+cWIwav+++fA7GSFWiw1GXquDNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R/JEEZ0izfQOWfDs/rnVqw26bn+SotT6fwjFTrsExc=; b=OhmiGA+Ax6cNNzGHNCIALveB4Nh/a+m+flHMeLXWqoj7lb8POZrCatrvtNFULlPs5KBamDpBEtv7i+nltpmoaLMwcMgGRdsLlby1aq7D4YT+S1ELXJ7sPRgHy9OT4+akmdlRVm0NNYOof7adNX5utIZeYdq+sWHV/Ga/QSiJBybAOJlXCYM1Z5sr38Cqx9PmWecr1y1cV9D/lvkJy8J7w0XKXCfbhmDqv4/gb1L0Dg6fUn3XgAxCwjamXqjae2Iznnn9dvSXic6Ldxp9fK86zZKGzy1nFKhsAIm1YmVZ6BZsXvkozvaFOjajebJRmKtCf5znP/nBjQFbEk6Gyshr5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R/JEEZ0izfQOWfDs/rnVqw26bn+SotT6fwjFTrsExc=; b=mxBSVxx/0zU4HmGq9ZKqFcuGD+10UbopoNOLjv75XXIVs9cYrgmDglrMoOpbvsYp4Majnkud7xW3Bf3RRVnaHorl9f28ZlKUBPML7ZVaP+4haavOVBDfT0HBEzd3KEDOsKUBni8bCQQbwSlR6Yci10F4EXa2Qrp1myTgeEnSHy8=
Received: from BYAPR11MB3638.namprd11.prod.outlook.com (20.178.237.19) by BYAPR11MB3141.namprd11.prod.outlook.com (20.177.228.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.16; Fri, 16 Aug 2019 19:33:07 +0000
Received: from BYAPR11MB3638.namprd11.prod.outlook.com ([fe80::d8d2:7e49:1687:aab2]) by BYAPR11MB3638.namprd11.prod.outlook.com ([fe80::d8d2:7e49:1687:aab2%3]) with mapi id 15.20.2157.022; Fri, 16 Aug 2019 19:33:07 +0000
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Russ Housley <housley@vigilsec.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-lsr-isis-rfc5306bis.all@ietf.org" <draft-ietf-lsr-isis-rfc5306bis.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04
Thread-Index: AQHVU7G7hfFajj9iuUa6bDDXlDuzz6b+Kb1g
Date: Fri, 16 Aug 2019 19:33:07 +0000
Message-ID: <BYAPR11MB3638E9D9F2CE8D0D9092DAE6C1AF0@BYAPR11MB3638.namprd11.prod.outlook.com>
References: <156590505334.15902.14295595773952354164@ietfa.amsl.com>
In-Reply-To: <156590505334.15902.14295595773952354164@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ginsberg@cisco.com;
x-originating-ip: [2001:420:c0c8:1003::46b]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0bc0e58b-db40-4488-7458-08d7228090bf
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR11MB3141;
x-ms-traffictypediagnostic: BYAPR11MB3141:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <BYAPR11MB31410007BEA81006E41424D3C1AF0@BYAPR11MB3141.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0131D22242
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(13464003)(189003)(199004)(53546011)(9686003)(76176011)(2501003)(99286004)(52536014)(256004)(53936002)(5660300002)(46003)(7696005)(102836004)(66556008)(74316002)(11346002)(14444005)(6506007)(476003)(446003)(229853002)(66946007)(54906003)(71200400001)(486006)(55016002)(71190400001)(186003)(66476007)(66446008)(76116006)(66574012)(110136005)(6436002)(6306002)(86362001)(64756008)(25786009)(2906002)(6246003)(81156014)(8936002)(478600001)(305945005)(316002)(6116002)(33656002)(7736002)(8676002)(81166006)(4326008)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR11MB3141; H:BYAPR11MB3638.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: xhkoFLhonx2OzkTqDam/tsTMwYk2xKpBz2MYoTIvFfhTFugyps0ZS2pM4NsXO1ijlew7yInUyjFjCDOmj1uTe17jAsfn1QFHCZEbwnLolR4W2DI3GWjwYEv62kgMPlG5GzecdezSidinpSl/rfaoOAf/K9ikHuJc8iUnbEVZXrDoMonfuZaYrYSZx1IwmZluv3enQK3sEFquXpUdZHTKzG6XnA0eak+OBAx4KxzuOavAkHlTy/nxsHT7o5HaCxTmOZJ70jAOcdqwpucihYr6kVHvGL+bhes/4VcN5RYdM82JsmkvgrZEMLPv8aiNF8q65rNw+l9g/YiuBSDKf8OzjKJbGc4e9dKgijQFv1O5LBAhLNzN+jGQdf24oL8gGc4sHRAP/UJWPpurcnyYSe67K7TnmW8Q9b3RbDvTm4F80Xs=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc0e58b-db40-4488-7458-08d7228090bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2019 19:33:07.3360 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4XcqfHiX6jsa90J9wvmrIoGxEf6bJXQvw5H81eLJtt4rjFK+DB306DB6EiNFbhgVIyGCF9ANGq8eHf5lVVHIDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3141
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.19, xch-rcd-009.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/IxMAE7PZR4xVj7b6E1M0wJSUrqI>
Subject: Re: [Lsr] Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Aug 2019 19:33:16 -0000

Russ -

Thanx for the careful review.
I have uploaded V5 of the draft which addresses your comments subject to my responses inline.


> -----Original Message-----
> From: Russ Housley via Datatracker <noreply@ietf.org>
> Sent: Thursday, August 15, 2019 2:38 PM
> To: gen-art@ietf.org
> Cc: draft-ietf-lsr-isis-rfc5306bis.all@ietf.org; ietf@ietf.org; lsr@ietf.org
> Subject: Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04
> 
> Reviewer: Russ Housley
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lsr-isis-rfc5306bis-04
> Reviewer: Russ Housley
> Review Date: 2019-08-15
> IETF LC End Date: 2019-08-27
> IESG Telechat date: Unknown
> 
> Summary: Ready with Nits
> 
> Major Concerns:
> 
> None
> 
> 
> Minor Concerns:
> 
> None
> 
> 
> Nits:
> 
> Section 3.2.3: The lettered paragraphs at the top of the section
> begin with lower case letters, but the lettered paragraphs at the
> top of the section begin with upper case letters.  Please be
> consistent.
> 
[Les:] Done

> Section 3.2.3: s/time after which the adjacency will now expire/
>                 /time after which the adjacency will expire/
> 
[Les:] I left this unchanged.  The text is identical to text in Section 3.2.1 regarding the RA bit. The point of using "now expire" is to emphasize that the expiration time has been adjusted as a result of the RR/PR request.
Hope this is OK with you.

> Section 3.2.3 says:
> 
>    ... It
>    is therefore useful to signal a planned restart (if the forwarding
>    plane on the restarting router is maintained) so that ...
> 
> I suggest:
> 
>    ... If
>    the forwarding plane on the restarting router is maintained, it
>    is useful to signal a planned restart so that ...

[Les:] I rewrote this paragraph. The term "restart" has been defined in Section 2 to be associated with a control plane restart which involves maintenance of the forwarding plane - so some of the text was redundant. 
I hope the revised text is both more readable and more precise.

   Les

v2.23.0 | Report a Bug | By Email