[Lsr] Genart last call review of draft-ietf-ospf-ospfv2-hbit-10

Mohit Sethi via Datatracker <noreply@ietf.org> Thu, 31 October 2019 08:08 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: lsr@ietf.org
Delivered-To: lsr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CC47A120844; Thu, 31 Oct 2019 01:08:39 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Mohit Sethi via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: last-call@ietf.org, draft-ietf-ospf-ospfv2-hbit.all@ietf.org, lsr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.108.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Mohit Sethi <mohit.m.sethi@ericsson.com>
Message-ID: <157250931972.30364.14155530538589367259@ietfa.amsl.com>
Date: Thu, 31 Oct 2019 01:08:39 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/PUv7mXhMOyo8GoZijv7o6e6LXzA>
Subject: [Lsr] Genart last call review of draft-ietf-ospf-ospfv2-hbit-10
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2019 08:08:40 -0000

Reviewer: Mohit Sethi
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-ospf-ospfv2-hbit-10
Reviewer: Mohit Sethi
Review Date: 2019-10-31
IETF LC End Date: 2019-11-07
IESG Telechat date: Not scheduled for a telechat

Summary:
This document uses a bit in the link state advertisement (LSA) sent from
routers to indicate that they are hosts which will not forward transit traffic.
The document is READY for publication.

Major issues:

Minor issues:
I think the document would benefit from some more discussion on what happens if
a router that is repelling traffic is on the only path to some destinations?
How is this handled? Is it fair to say that H-bit is only a best effort way of
repelling traffic and does not guarantee that the transit traffic is actually
interrupted?

Any reason that this is only done for OSPFv2 and not v3? Are there ways of
achieving this functionality (of repelling transit traffic) already in v3?

Nits/editorial comments:
- Please expand acronyms like NSSA and LSAs on first usage.
- Abstract has stray " symbol.
-  The list in the acknowledgements section could benefit from an Oxford comma:
Abhay Roy, David Ward, Burjiz Pithawala, and Michael Barnes for their comments.