Re: [Lsr] RtgDir review: draft-ietf-ospf-segment-routing-msd

Jeff Tantsura <jefftant.ietf@gmail.com> Fri, 24 August 2018 20:42 UTC

Return-Path: <jefftant.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21723130DDF; Fri, 24 Aug 2018 13:42:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wh6eTrpM6mTR; Fri, 24 Aug 2018 13:42:05 -0700 (PDT)
Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D20B130DC0; Fri, 24 Aug 2018 13:42:05 -0700 (PDT)
Received: by mail-pg1-x52a.google.com with SMTP id m4-v6so4271446pgv.12; Fri, 24 Aug 2018 13:42:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :references:in-reply-to:mime-version; bh=eOp797ImhtMnH3QyqNz2IuIqUn7JD5WweKc+FeOOPuU=; b=Ipssr5XR9WyGmsWwZ4Hf1/AthTOf9rai1jHn9SO0VlVS6Fj/RsjPJSYnTRjqOMKi/z h+t9E0324Q7vrXMSQ37sUfWp8Q221KOEYzy7n4PfZ38hMDLHLKb74kZ7ytbrTKpCeJ6/ doqu9KaO8P2XK3lFOtvV4ADqJXjT2/Z/lpqogJ9d/OApQiUArUS8y3FV24Pg8hHkXDQ5 UIucFUwejhdSaAqS20PJYO/uVknu+YoYFNViF4/8/vpsFori5QBskWqhAkFtq3E2j7U2 v9vE5LUZ7y6oQoNLQakKnDS31fJF7WjJXzSZA4Dfn//61LIdhOYJFa317Bm/1Sk6PaEk JTSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:date:subject:from:to:cc:message-id :thread-topic:references:in-reply-to:mime-version; bh=eOp797ImhtMnH3QyqNz2IuIqUn7JD5WweKc+FeOOPuU=; b=i5qGIz+iwNS4l4lJ7AqqPvVQhic67/7TW2UT/H07H7AI3bv9rD0YCavUoABi2DYjiU i4R5NsWFNk2FOUEADBQ672x4E/sKwi+FVhuNzGii5lTEVByFfc4s4s4ytXy0SxPfg6Um lyXUsj/FfWpC0TZQlKGwKAWp9h4CbSWMsXIEolJA3F2HY41fueElebOwoDtJ3V4od3+B 2qfaHEYX3SWmLL1SALKC+utOt6xMrYd/nqVJXv0Rmgdgt24qkqHDii4EFEChnyBBF83d Z9LzK35tBrEVNmgQ9OHmI0QIFnKOmZokrvk7V8r80xo/yG9MxouAMfZU1Sa21TU2Hu8l Rllw==
X-Gm-Message-State: APzg51D5jzXDt+KRCkE/I1ZMgBumfQvL8xLHZiUJUVff4aTvP/QAbfVk Y+m2bJ5MT2iEjz97m89HSuYEEcZr
X-Google-Smtp-Source: ANB0VdYpQC0u8EDoDVKYOe3w9b6ln1Y77TzqZrJY6HztzcixnRsFB1ZAyVx2QjhmRIeyKKH0KXtNPw==
X-Received: by 2002:a62:2119:: with SMTP id h25-v6mr3547079pfh.112.1535143325101; Fri, 24 Aug 2018 13:42:05 -0700 (PDT)
Received: from [10.11.12.179] ([66.201.62.254]) by smtp.gmail.com with ESMTPSA id v26-v6sm6568936pfe.57.2018.08.24.13.42.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Aug 2018 13:42:04 -0700 (PDT)
User-Agent: Microsoft-MacOutlook/10.10.0.180812
Date: Fri, 24 Aug 2018 13:42:02 -0700
From: Jeff Tantsura <jefftant.ietf@gmail.com>
To: Tal Mizrahi <tal.mizrahi.phd@gmail.com>, rtg-ads@ietf.org, draft-ietf-ospf-segment-routing-msd@ietf.org, lsr@ietf.org, ospf-chairs@ietf.org
CC: rtg-dir@ietf.org, "Yemin (Amy)" <amy.yemin@huawei.com>
Message-ID: <9E1D268F-B397-4911-8939-9A540CB65F5D@gmail.com>
Thread-Topic: RtgDir review: draft-ietf-ospf-segment-routing-msd
References: <CABUE3XmKSCV91K_YcLrp+xs-HoPeCDqBDDpZEFAt=-veBexN3A@mail.gmail.com>
In-Reply-To: <CABUE3XmKSCV91K_YcLrp+xs-HoPeCDqBDDpZEFAt=-veBexN3A@mail.gmail.com>
Mime-version: 1.0
Content-type: multipart/alternative; boundary="B_3617962923_404399167"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/Zy5p4kHVPdEHflVWJ-EfNwzgUSQ>
Subject: Re: [Lsr] RtgDir review: draft-ietf-ospf-segment-routing-msd
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Aug 2018 20:42:08 -0000

Hi Tal,

 

Many thanks for your comments.

Updated draft has been published for your review.

 

Cheers,

Jeff

 

From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Monday, August 20, 2018 at 23:45
To: <rtg-ads@ietf.org>, <draft-ietf-ospf-segment-routing-msd@ietf.org>, <lsr@ietf.org>, <ospf-chairs@ietf.org>
Cc: <rtg-dir@ietf.org>, "Yemin (Amy)" <amy.yemin@huawei.com>
Subject: RtgDir review: draft-ietf-ospf-segment-routing-msd
Resent-From: <alias-bounces@ietf.org>
Resent-To: Jeff Tantsura <jefftant.ietf@gmail.com>, <uma.chunduri@huawei.com>, <aldrin.ietf@gmail.com>, <ppsenak@cisco.com>
Resent-Date: Mon, 20 Aug 2018 23:45:53 -0700 (PDT)

 

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-ospf-segment-routing-msd 
Reviewer: Tal Mizrahi 
Review Date: 21-Aug-2018 
Intended Status: Standards Track

Summary: 

This document is basically ready for publication, but has a couple of minor issues and nits that should be resolved prior to publication.

Minor Issues:
Figure 1 seems to indicate that the MSD-Type and the MSD-Value are 2 octets long each, whereas according to the text afterwards each of the two fields is 1 octet long.
Figure 2 – same comment.
Nits:
“provisioned..” --> “provisioned.” (extra period)
“Acknowledgements” --> “Acknowledgments”
“capabilites” --> “capabilities”
“the the” --> “the”