Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-yang-isis-reverse-metric-01

"Acee Lindem (acee)" <acee@cisco.com> Wed, 16 December 2020 13:13 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 747043A0AEE; Wed, 16 Dec 2020 05:13:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.59
X-Spam-Level:
X-Spam-Status: No, score=-9.59 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_TEMPERROR=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=cNWBJN3p; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=RTSYN0N5
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dlIrSBz7e0St; Wed, 16 Dec 2020 05:13:00 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E57D43A0AE6; Wed, 16 Dec 2020 05:12:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2402; q=dns/txt; s=iport; t=1608124380; x=1609333980; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=cxF1kIXSF2MASeCkA1YKdfLhvVxQkNT3q7OmHl3znDU=; b=cNWBJN3pMIcT+1GUCbSPA7ska/8bScyC4Rjtki+Q+TXkS6yHypxSkkwq GyNcGttXUHxU1ZughVM3i3o1pxOFXU2Z79mFnObrY6b/VYzt3hC6OSt0l LvaMTEsURrBkcL0s033F04MoHXFnC4Gq2gFeudgkDYUmcN66jmVPic0Z0 s=;
X-IPAS-Result: =?us-ascii?q?A0DSAgDcBtpfkIMNJK1iHAEBAQEBAQcBARIBAQQEAQFAg?= =?us-ascii?q?U+BUlGBVy8uCoQ1g0gDjTYlmQ2CUwNUCwEBAQ0BAS0CBAEBhEoCF4FZAiU4E?= =?us-ascii?q?wIDAQEBAwIDAQEBAQUBAQECAQYEFAEBAQEBAYY4DIVzAgQSEREMAQE3AQ8CA?= =?us-ascii?q?QgaAiYCAgIwFRACBAENBSKDBIJWAy4BoX8CgTyIaXaBMoMEAQEFhSwYghAJg?= =?us-ascii?q?Q4qgnWDeoY2JhuCAIE4DBCCVj6EPoMXM4IKIoFZgVJDLwJdYgYTFpM7pQ0Kg?= =?us-ascii?q?nSWM4UYAx+DJoomlHGUBaEoAgQCBAUCDgEBBYFtIYFZcBVlAYI+UBcCDY4hG?= =?us-ascii?q?oNXilh0NwIGAQkBAQMJfIg0AYEQAQE?=
IronPort-PHdr: =?us-ascii?q?9a23=3A8sxevhHDraDyc596BdRBoJ1GYnJ96bzpIg4Y7I?= =?us-ascii?q?YmgLtSc6Oluo7vJ1Hb+e401A+bW4TQrflW2KLasKHlDGoH55vJ8HUPa4dFWB?= =?us-ascii?q?JNj8IK1xchD8iIBQyeTrbqYiU2Ed4EWApj+He2Yk5UE4D1dQ6arni79zVHHB?= =?us-ascii?q?L5OEJ8Lfj0HYiHicOx2qiy9pTfbh8OiiC6ZOZ5LQ69qkPascxFjA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.78,424,1599523200"; d="scan'208";a="615174834"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 16 Dec 2020 13:12:59 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id 0BGDCwAi013485 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 16 Dec 2020 13:12:58 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Dec 2020 07:12:58 -0600
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Dec 2020 08:12:57 -0500
Received: from NAM04-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 16 Dec 2020 08:12:57 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwP5W94TlmX5VewDawTo3gmeSA7IZti/mtDTDYDYhDSkIwHBrm83LTuiL1uwjyq2HviZDkXxm9FpOXIV0lDIuB48y9IOMMCEC6h89zSb54UGPW/JkXxx9NBOp2ynAStvYe3TxRABfVBNtKeFB1ZRsXlHO2L+YX4IQ06mLU21MeNlN2+McTIulFfdP17r+S1IertOhhrAdPXOtY5XrCuZRBfEOeoOYm1msSpSnN11K0N/UtZ5TugYGZ7XYRkdzYHsGxgOA0LKp9wcPmZWTb1b96cue7GVSZZfJfHVzbrCEpZLKwFczgOStvtAWg3j7foLaVT4nb8xW281oUTsx0nefQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxF1kIXSF2MASeCkA1YKdfLhvVxQkNT3q7OmHl3znDU=; b=hNf/4Fq9tug8yLLOEjPLVDoEXr4/c4+g564GKmR4a2xEgtp9UNt9GvgUz3QFE7xV3HMGe3Z1luZakr8YtTv9pqvNBfru2JkmvE5HX972EN9Oh6Qa/yuFfymPx/WaULhvsIl03fesdYGR6mmE3O9F2rdnejG9QW4sqzLvi7v9RJDD6R8K4GDV4m4W6QcoEt2N/BbZU6S5sv7PRDSPG+SMRFb9iubjJMaD6j1T9G2Fmd95Glcqk+yYU53Ymz+ihRZ5AurhYkAqNeN3z7WXEs1fAnb7j501NVz9cu5iaUlJ3xGAwbVmj2umvL/arAOZ2k9YKpv/qKTo3u6ZahTB/xe7nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxF1kIXSF2MASeCkA1YKdfLhvVxQkNT3q7OmHl3znDU=; b=RTSYN0N58QaIkestEIMybFVt4B/ho8Z9L766OAWactu8Wt3l+F9nf6/R2u9oQ06wtdFZQxTRaJDTrszX4e+h8NaPZxphMjYyD4rjrKc6n+TLoAfgOaSHmLyyfQQTOukJOCnjcWCr6wxioo3URIwo9PhmOSlxrYZXZLK8Wc1wuP0=
Received: from BYAPR11MB2887.namprd11.prod.outlook.com (2603:10b6:a03:89::27) by SJ0PR11MB5070.namprd11.prod.outlook.com (2603:10b6:a03:2d5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.20; Wed, 16 Dec 2020 13:11:41 +0000
Received: from BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::65a7:2fad:a960:2557]) by BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::65a7:2fad:a960:2557%3]) with mapi id 15.20.3654.024; Wed, 16 Dec 2020 13:11:41 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Ladislav Lhotka <ladislav.lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, Christian Hopps <chopps@chopps.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-lsr-yang-isis-reverse-metric.all@ietf.org" <draft-ietf-lsr-yang-isis-reverse-metric.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-lsr-yang-isis-reverse-metric-01
Thread-Index: AQHW06TO1PTCcvxf7EisAEUaBQ3RJqn5XuAA
Date: Wed, 16 Dec 2020 13:11:41 +0000
Message-ID: <43DC8391-20E5-4518-8B0F-C3ED2A51FF4D@cisco.com>
References: <160812077773.23729.6946762665789150965@ietfa.amsl.com>
In-Reply-To: <160812077773.23729.6946762665789150965@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.43.20110804
authentication-results: nic.cz; dkim=none (message not signed) header.d=none;nic.cz; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [136.56.133.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 73d02fd8-5cda-49a2-91a9-08d8a1c42141
x-ms-traffictypediagnostic: SJ0PR11MB5070:
x-microsoft-antispam-prvs: <SJ0PR11MB507058E014FBC97738A54763C2C50@SJ0PR11MB5070.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1468;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: oUdikxQuWR0bhttfePBGEo2glQsjMWMsFutLe8Bs+tdaFMo6pH5MghqZzMvFZfsG10/cMA/UGmIq2kzCehRDLi0MU174pyP5oLEwHbCEYvFcb4M0SBeddEvO655RKQHyUsQWx81L1YqKtjWb9TI2MFCDdwEOQHde5QLqeZACehUirU/9FxOg42dxZD0+ZSjgc64vgF7Z78aqOKLjrpwt69lW39iYvnQ9Bhf84ckinCtLnDAj5vuwipI8Y1QXOL7ohB1SjX9ZcWgcN3V5lwLzEJjdOm+2kpXdvBdUgJQDjAnpXnDT/rQ+IXkahq9mJX2EjSvKhY8/pTWoEcCPVfxA5jAu6YlfK73qAhWVFZN8K6bJan74cQxjZ2qp7BXQaTk8
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2887.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(366004)(346002)(136003)(39860400002)(110136005)(33656002)(8676002)(6512007)(316002)(86362001)(4326008)(76116006)(66476007)(66946007)(6506007)(66446008)(36756003)(2906002)(8936002)(66556008)(64756008)(478600001)(186003)(6486002)(5660300002)(2616005)(71200400001)(54906003)(26005)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?utf-8?B?TUlUTTltWFJnc1UzME5hcHNjQ3AxZlpaeE1mdEs5VHhzM3FlbTltK0p2SmRN?= =?utf-8?B?bHlCU2hVTFBUMDh1U3Q3OUJQWXdaU1ZUOFhzclc2UWFqdzJhN2dkUGs1dlRk?= =?utf-8?B?V2h6b3hLdlZRbW4rQWxLQk96bU5zY1RsWjhhRVFMenB4aEVndlFLNkQvRzB6?= =?utf-8?B?K0M3Z01FeVZWTVNtK1FKK3FEdGhxNFdvd05kd2xXb2REWmovWjhhQlpKU0pw?= =?utf-8?B?VWNZZ0JoU1dDZ1lUQm12eWltMVBqZ1FwVFI3OHR1WGplZjAycWRESWJETDVq?= =?utf-8?B?dmR6eFlCdCtOU2EzV1k0MUhUQ2JTa1hrUlB5NzFNaUkzVEdqK1FVeEYzN3Jn?= =?utf-8?B?TVZQdGxTZGpWMmNsMnBiSmNMWXduZTg4ckJLMzI2aDVRR0hHWEZqTXc1ZURS?= =?utf-8?B?TnlLdk5MMHhTckZYZnpuNFhnY2RwWldPRmpXYzNCWWU4M1N1TEZHZE5rOXZp?= =?utf-8?B?aDJUQmlybDlEMW40S1NsaCsrT0lOZVA1cWlaNFRrYXNVOEFZbWFOWTYwOFNu?= =?utf-8?B?M1lHcURLMk5VaVZ6S2p2aDR0dml6Y1ZoWFNNaFNaczRBUEg1ZmU5ZEdZS1B6?= =?utf-8?B?NU9CRkN5R2hqYk1JY3hLQWNTTm1oZC9ncFZkQ1BaSzZUT1h3SVVaaHR1em80?= =?utf-8?B?WFV5TDlmVEFMUWoxM3FCNEZYVVNpZ0I1dFREVms1MFdSdFNqbGxzOUJ4QlUy?= =?utf-8?B?R1dvN3dQc3F1VUs5bWNaNzRrclI2UHp2OFBvcGIvRXVRS2t5eDRhcHpzTVhx?= =?utf-8?B?TmV3R25Ia3NlS09qa2Rod3B4RGVUSUhUeG9UQUNuUGdyd2RmWGFBa2RjN2No?= =?utf-8?B?bjlRWlM2Y1ZxanVNaysrYmFQdG9NTW0yQUxKRmsxcTMzVXB3NUs4YWhjNnY1?= =?utf-8?B?S1ZOL01tcitxQmQ0elNwU3RoeEpyUHJwYTIvdTJwTzhzdVlmSTlIZzVrNHd6?= =?utf-8?B?aEt5WHRCRFFPYUpxK2tBaVlPbmJsdGNhSVNIaWZBVis3QmtqWGpUMU1oVGlQ?= =?utf-8?B?SEQ1UlBmdi9RbVd3K2djc2lHWHZhRVlQTU1CVG5ZTWVmd2pHeWxRZVlRUzFv?= =?utf-8?B?Y2FwdWF3aFM3QTB6d0plVkQrU1BiaTE5S3QzOTc3WnZybXJvWXlUWWdMemMy?= =?utf-8?B?RXF4TloyUG5hYmptZ1M5c0tIdmtUWU4xOG8rbk9QWllER0I1VjVIK0hlZVFN?= =?utf-8?B?Ukh3UUR2RVNXdGJHMytJYmQxa01KeHZVd2g1N25FdGpwbmtaKzJZa1JCQkFu?= =?utf-8?B?TmhWTVRPcGJ0MFJiRGcyZ0NjNVhNbWRYT2l6YkVmR0ExcFdkUVVVM0g1SW5K?= =?utf-8?Q?aRjiPeWS3PE+7DPRcPbg6PLVMpqpjO7nNd?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <F5746775B2EAB347934276C73E2FD4B4@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2887.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73d02fd8-5cda-49a2-91a9-08d8a1c42141
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2020 13:11:41.5712 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MHptT8SsI+pgg1VDAdVPZvDwkpWNr6jD0W9EXDPRomxjdh29YVFd5aww2oDTK6Dd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5070
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: alln-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/bWtUGR14hOjPCTb4N4-TNhIXTYc>
Subject: Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-yang-isis-reverse-metric-01
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2020 13:13:06 -0000

Hi Lada, 
Thanks for your prompt and thorough review. 

Hi Chris, 
Please address the comments.
Thanks,
Acee

On 12/16/20, 7:13 AM, "Ladislav Lhotka via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Ladislav Lhotka
    Review result: Ready with Issues

    **** General comments

    - YANG module "ietf-isis-reverse-metric" is in a good shape except for
      one issue described below.
    - I appreciate the three examples of instance data in appendices (two
      in XML representation, one in JSON).

    **** Specific comments

    - In three places, the module uses "when" expressions with plain
      string equality test applied to identityref values, such as:

         when "../rt:type = 'isis:isis'"

      This is known to be fragile, which can demonstrated on the JSON
      example in appendix A.3: It has

         "type": "ietf-isis:isis"

      which makes the "when" expression false because of the different
      prefix, and the corresponding augment doesn't happen.

      The above "when" expression should use the XPath function
      "derived-from-or-self" that is defined in RFC 7950:

         when "derived-from-or-self(../rt:type, 'isis:isis')"  

    - The "tlv16-reverse-metric" grouping is used only once in the
      module. Unless it is expected to be used elsewhere, I would
      recommend to remove this grouping and use its contents directly.

    - The phrase "YANG XML data" is somewhat misleading, although it is
      probably often used in informal discussions. I would suggest "XML
      instance data" instead.

    **** Nits

    - Abstract & Introduction: s/routeing/routing/

    - Appending A.3: s/YANG XML data/JSON instance data/