Re: [Lsr] Adam Roach's No Objection on draft-ietf-isis-yang-isis-cfg-40: (with COMMENT)

"Acee Lindem (acee)" <acee@cisco.com> Mon, 07 October 2019 16:44 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68387120802; Mon, 7 Oct 2019 09:44:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=hNlZy+e1; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=BOX4gwl9
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DPoma02ACI7A; Mon, 7 Oct 2019 09:44:32 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA102120169; Mon, 7 Oct 2019 09:44:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4332; q=dns/txt; s=iport; t=1570466672; x=1571676272; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9ovnMlSNTrnSzlTrA0hVA4ESihZ+DAoOeMDohKctTP4=; b=hNlZy+e1AjG8SBGRwknBohjBiR/eva69Snb5wsAQTptI7us4O994NxxP /aa5kvaoe0wgL1I7d8jtoDGcCaqab1nUYxbTlvpJ6hy6rKnM5Ht/wwYPU tSiLmZYCHhu9VF25Y0hGtr3GztGVp+M89/GVr+GkEBANb8IFGwWCekXvE Y=;
IronPort-PHdr: =?us-ascii?q?9a23=3AjUObihCxdU+qVVzWvS4OUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qgw3kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMdRXUg?= =?us-ascii?q?Mdz8AfngguGsmAXETwIfPCZC0hF8MEX1hgrDm2?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DZAQAYaptd/5FdJa1mGwEBAQEDAQE?= =?us-ascii?q?BDAMBAQGBZ4FLUANtViAECyqEI4NHA4pKgjcll3yBQoEQA1QJAQEBDAEBIwo?= =?us-ascii?q?CAQGEQAIXgkUjOBMCAwkBAQQBAQECAQUEbYUtDIVMAQEDARIREQwBATcBDwI?= =?us-ascii?q?BCBoCJgICAjAVEAIEAQ0FIoMAAYFqAw4PAQIMpB8CgTiIYXWBMoJ9AQEFgUh?= =?us-ascii?q?BgnwYghcDBoEMKIwOGIF/gTgME4JMPoJhAgECAYEqARIBH4MNgliNB4IvN51?= =?us-ascii?q?TCoIihwmKDIQDG4I6h06PN44siCGREQIEAgQFAg4BAQWBaSJnWBEIcBU7KgG?= =?us-ascii?q?CQVAQFIFPOIM7hRSFP3QBgSiNfoJFAQE?=
X-IronPort-AV: E=Sophos;i="5.67,268,1566864000"; d="scan'208";a="339464710"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 07 Oct 2019 16:44:31 +0000
Received: from XCH-ALN-020.cisco.com (xch-aln-020.cisco.com [173.36.7.30]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id x97GiVRi014634 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 7 Oct 2019 16:44:31 GMT
Received: from xhs-aln-003.cisco.com (173.37.135.120) by XCH-ALN-020.cisco.com (173.36.7.30) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 7 Oct 2019 11:44:30 -0500
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 7 Oct 2019 11:44:30 -0500
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 7 Oct 2019 11:44:29 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRsnmFPQbsD8b5pfAPV1oxjlVhmV/vHZVz2thftBKUgOL+RxcY8aJgcnyaNETCBP3FLQBVGIPkXpu2F1AOYlD6SvHgEmZ+isEQDv5tGQcUYf4siS+T439U8ndbtw117z0W+6BC1Kz88rwYY0nN16wSE/iT0j5axLXnhC0YdVA/3HU9WzqmrWNYiSNPkYElpkgi+kXgX3Fv37TgOlH3uUe4SCA8YxMQGO8e8hciJ1rnQRwkNNgQDHrxv2A7p3JRVLTrZe+ugjfm2wz8jrtJh1yBfodiYTvkPa//iTvQa31DC617s21RAJLMKqgS68X7Cp5+CGRzX761EFviwbv3vvAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ovnMlSNTrnSzlTrA0hVA4ESihZ+DAoOeMDohKctTP4=; b=c/RjQp9dQ9keyGiGdiJTHYvYA2k9HfO1LykSAeA1yI3Wir6vHsX8MH/XQ3tLuUF47+OgjQA9UH7z5njWfhHze2v1ctKzNgokR77LUn7WvIh1ow5yvHK932RBbGLoUSS90pbeLzrFcNvBn1sx0xJ5NRzN4vnheQaeajsnknt1HEbvZ8io1w3oMuFiyY2HWkTL3Wi8A30wzVki3m3RV0W47lYf4Okf9xZDIAPV1Ob3GWpKqZJUp0kFeDnIH39pV2LswzW/7P9YIp+TBfljOn1H+Hck/mbXoWVKUYpKXSCKNciN2yVKhgAsc7/SbJxrYRo2g60oQx7gSx2sn7SJcJstoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ovnMlSNTrnSzlTrA0hVA4ESihZ+DAoOeMDohKctTP4=; b=BOX4gwl94MB6dRk6O+kQeMBtJ8QUcBu30IjAEWXcWU45oyqJZQ527ISe7KiGOplDixs2wAvvyE1fd+4cULqU01LNMOIv7zW0EXrVWCNBg81E/+wJ01o9QoBxD9KxlF0aCvrfDqm1JrNpxPKMFI1Ls3kYHUwLJKOsHJKDGiLQ03g=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB4016.namprd11.prod.outlook.com (10.255.181.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Mon, 7 Oct 2019 16:44:28 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56%4]) with mapi id 15.20.2327.023; Mon, 7 Oct 2019 16:44:28 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Adam Roach <adam@nostrum.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-isis-yang-isis-cfg@ietf.org" <draft-ietf-isis-yang-isis-cfg@ietf.org>, Yingzhen Qu <yingzhen.ietf@gmail.com>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Adam Roach's No Objection on draft-ietf-isis-yang-isis-cfg-40: (with COMMENT)
Thread-Index: AQHVeXEftTY4y0fTr0qQyxFBAZyTBadPJwaA
Date: Mon, 7 Oct 2019 16:44:28 +0000
Message-ID: <D52B6B66-3601-4E35-805F-164635009754@cisco.com>
References: <157005547716.8852.9437110159615855482.idtracker@ietfa.amsl.com>
In-Reply-To: <157005547716.8852.9437110159615855482.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1006::11f]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8a16994f-866a-4298-35dc-08d74b459eaa
x-ms-traffictypediagnostic: MN2PR11MB4016:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <MN2PR11MB401664C56AE672AD06A2BF9EC29B0@MN2PR11MB4016.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01834E39B7
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(189003)(199004)(51914003)(8676002)(229853002)(33656002)(6436002)(8936002)(6116002)(966005)(478600001)(6306002)(14454004)(6512007)(316002)(81166006)(110136005)(54906003)(76176011)(66446008)(64756008)(66556008)(99286004)(81156014)(25786009)(256004)(6246003)(66476007)(66946007)(76116006)(6486002)(2906002)(186003)(4326008)(71200400001)(71190400001)(102836004)(7736002)(86362001)(305945005)(46003)(36756003)(446003)(2616005)(476003)(11346002)(486006)(6506007)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4016; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5r+/W02DyFh+Ei5Pd4OEsJ6ECGGjcqUSjEN4uHwm/BJ/eRWXlS77/viHxRq9EU0bL5WSIhNOxRQAHhJsejFAU61hAMYLZRKWmYp1t8Gw/Qw2MVvzwpnF1fzthbnOO+LJ/3nVGFOv95fMO07g8PFJ0AjzlbdI95DfrGnzNLfn47DDDSGIoXf9UX3z+m2QoDoSppSo7PlnEQjiPLf2iiwvKYvDbT3KfoUmdqCFAcqOJUFGsQY8gpwycf84nue94HT6m+afw+ui2kBZ5VF8jf0vn9epP+dnGF2/Up2OFrH88qtui/jIoHg7eKRvNspPHd0QfFTAufAvDxA30M6LZJqcInxI2e1Y+hXzT7JShCXFRSZAEHi3netoGzL/EPMsnyydWZShTSFleoJGmBsBcaqGFRyD549j5XpfZ7z+xxoqgtS6mC7sD2eypb1smzod+2t3JKxknJp5tnUbACq9UA6FkQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <3A920AD455F42E48B59598574EA7F98C@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a16994f-866a-4298-35dc-08d74b459eaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2019 16:44:28.1896 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vOseUvDuAZmikxo6kOYUjpwPhTk57lPhuJqozIYt+92Lic3SKRxpdHKhokLOHn0J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4016
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.30, xch-aln-020.cisco.com
X-Outbound-Node: rcdn-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/dA_bvyIbGFblFVGYxstF6micrhI>
Subject: Re: [Lsr] Adam Roach's No Objection on draft-ietf-isis-yang-isis-cfg-40: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Oct 2019 16:44:35 -0000

Hi Adam, 

Thanks for review. 

´╗┐On 10/2/19, 6:31 PM, "Adam Roach via Datatracker" <noreply@ietf.org>; wrote:

    Adam Roach has entered the following ballot position for
    draft-ietf-isis-yang-isis-cfg-40: No Objection
    
    When responding, please keep the subject line intact and reply to all
    email addresses included in the To and CC lines. (Feel free to cut this
    introductory paragraph, however.)
    
    
    Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
    for more information about IESG DISCUSS and COMMENT positions.
    
    
    The document, along with other ballot positions, can be found here:
    https://datatracker.ietf.org/doc/draft-ietf-isis-yang-isis-cfg/
    
    
    
    ----------------------------------------------------------------------
    COMMENT:
    ----------------------------------------------------------------------
    
    
    Thanks for the work that went into this model. I have only a handful
    of minor issues I found when reading through the module.
    
    ---------------------------------------------------------------------------
    
    >    grouping spf-parameters {
    >      container spf-control {
    >          leaf paths {
    >            if-feature max-ecmp;
    >            type uint16 {
    >              range "1..32";
    >            }
    
    Why is this a uint16 rather than a uint8?

It definitely could be uint8. 
    
    ---------------------------------------------------------------------------
    
    >      leaf-list tag {
    >        type uint32;
    >        description
    >          "List of 32-bit tags associated with the IPv4 prefix.";
    >      }
    >      leaf-list tag64 {
    >        type uint64;
    >        description
    >          "List of 32-bit tags associated with the IPv4 prefix.";
    >      }
    
    I think this second description is meant to say "64-bit" rather than "32-bit".

Fixed and will be in the -41 version. 
    
    ---------------------------------------------------------------------------
    
    >      leaf reason {
    >        type string {
    >          length "1..255";
    >        }
    >        description
    >          "The system may provide a reason to reject the
    >           adjacency. If the reason is not available,
    >           an empty string will be returned.
    >           The expected format is a single line text.";
    >      }
    
    This description is inconsistent with the definition: it calls for an empty
    string, while the definition requires that at lest one character be present. If
    you want to keep the description as-is, you need to adjust the length to be
    "0..255". Alternately, you might indicate that the field is simply to be
    omitted rather than empty, which appears to be the intention for other
    "reason" fields in this model.

Actually, I think the intension was to return a string consisting solely of the EOL character ('\0'). However, I think not returning a string is a better alternative. 

Thanks
Acee