[Lsr] Secdir last call review of draft-ietf-lsr-isis-srv6-extensions-14

Yaron Sheffer via Datatracker <noreply@ietf.org> Mon, 03 May 2021 12:56 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: lsr@ietf.org
Delivered-To: lsr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C3B403A102D; Mon, 3 May 2021 05:56:13 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Yaron Sheffer via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: draft-ietf-lsr-isis-srv6-extensions.all@ietf.org, last-call@ietf.org, lsr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.28.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <162004657373.13851.8347166444632264802@ietfa.amsl.com>
Reply-To: Yaron Sheffer <yaronf.ietf@gmail.com>
Date: Mon, 03 May 2021 05:56:13 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/fKnXXQxUGVSaWn9TCqznc8qpKcY>
Subject: [Lsr] Secdir last call review of draft-ietf-lsr-isis-srv6-extensions-14
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 May 2021 12:56:14 -0000

Reviewer: Yaron Sheffer
Review result: Ready

This document specifies extensions (TLVs, sub-TLVs etc.) to IS-IS in support of
Segment Routing on IPv6.

The document states that the security considerations are a union of security
considerations from a bunch of predecessor document. This seems reasonable to
me.

Details:

* The first sentence of the Abstract is missing a word, perhaps "architecture".

* Introduction: typo: "This documents".

* Capabilities: to allow for future extensibility, you should probably add
"Implementations receiving this TLV MUST ignore any other bits that may be set
in the Flags field".