Re: [Lsr] Opsdir last call review of draft-ietf-ospf-lls-interface-id-06

Peter Psenak <ppsenak@cisco.com> Wed, 10 October 2018 14:24 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E6B5C130F47; Wed, 10 Oct 2018 07:24:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.502
X-Spam-Level:
X-Spam-Status: No, score=-14.502 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zb_G7c-wXeC1; Wed, 10 Oct 2018 07:24:00 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40771130F61; Wed, 10 Oct 2018 07:23:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1375; q=dns/txt; s=iport; t=1539181435; x=1540391035; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=nt9fCCAdeHKIAbp2TvajOGfXIEGssJPvRkjIEKQBu8A=; b=ZDWhzjJE1L0mUzkYaMCTXNZM1g/CBSnbULtNQW3dF3vttKCf/6Z+tpMB C+i/i1Q/FmsDA2ooGzJFfG8x6gom1U5bz7NqDYY+fDzxgHW3FdD2Dgfht reE9z4TYtXFxAmnvgyxAm+bJxakdV5Hh9v/4petfe6JzjgiR+mNpiBpyF c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0A9AACxCr5b/xbLJq1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBZYNZEoQdiHSNY5h4DYRsAoRxOBYBAwEBAgEBAm0ohTo?= =?us-ascii?q?BBSMVQRALGAICBSECAg8CRgYBDAEHAQGFH6R5gS6EeIUcgQuKR4FBP4ESgxK?= =?us-ascii?q?Hf4JXAo5xjxUJkFEXiSKGaZYMgVkhQYEUMxoIGxWDKJBWPY0OAQE?=
X-IronPort-AV: E=Sophos;i="5.54,364,1534809600"; d="scan'208";a="7078637"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2018 14:23:53 +0000
Received: from [10.149.12.14] (dhcp-10-149-12-14.cisco.com [10.149.12.14]) by aer-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id w9AENqYW023099; Wed, 10 Oct 2018 14:23:52 GMT
Message-ID: <5BBE0B78.10609@cisco.com>
Date: Wed, 10 Oct 2018 16:23:52 +0200
From: Peter Psenak <ppsenak@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Sheng Jiang <jiangsheng@huawei.com>, ops-dir@ietf.org
CC: lsr@ietf.org, draft-ietf-ospf-lls-interface-id.all@ietf.org, ietf@ietf.org
References: <153914324720.10676.17623408848748308339@ietfa.amsl.com>
In-Reply-To: <153914324720.10676.17623408848748308339@ietfa.amsl.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Outbound-SMTP-Client: 10.149.12.14, dhcp-10-149-12-14.cisco.com
X-Outbound-Node: aer-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/kAC1ugwhCy4KvxhCoVABOLqd5LU>
Subject: Re: [Lsr] Opsdir last call review of draft-ietf-ospf-lls-interface-id-06
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2018 14:24:11 -0000

Hi Sheng,

posted a new version that addresses your comments.

thanks,
Peter

On 10/10/18 05:47 , Sheng Jiang wrote:
> Reviewer: Sheng Jiang
> Review result: Has Nits
>
> Hi, OPS-DIR, Authors,
>
> I have reviewed this document as part of the Operational directorate's ongoing
> effort to review all IETF documents being processed by the IESG. These comments
> were written with the intent of improving the operational aspects of the IETF
> drafts. Comments that are not addressed in last call may be included in AD
> reviews during the IESG review. Document editors and WG chairs should treat
> these comments just like any other last call comments.
>
> This standard track document defines a new option Local Interface Identifier in
> OSPF Hello and Database Description (DD) packets as an extensions to OSPF
> link-local signalling. This document is short and well written. It is READY
> with a couple of Nits, which should be easily fixed.
>
> Major issue: no.
>
> Minor issue: no.
>
> Nits:
>
> Unused Reference: 'RFC8379'. There is no relevant text. Either some text should
> be added or this reference should be deleted.
>
> In the IANA section,  "18 - Local Interface Identifier TLV". Normally the value
> that is actually assigned should be left to IANA. Here, it should be TBD as a
> draft.
>
> Regards,
>
> Sheng
>
> .
>