Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29

Ladislav Lhotka <lhotka@nic.cz> Wed, 23 January 2019 09:09 UTC

Return-Path: <lhotka@nic.cz>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65C0E130E63; Wed, 23 Jan 2019 01:09:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7
X-Spam-Level:
X-Spam-Status: No, score=-7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nic.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C9dKxIMb10Q0; Wed, 23 Jan 2019 01:09:01 -0800 (PST)
Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47688123FFD; Wed, 23 Jan 2019 01:09:00 -0800 (PST)
Received: from birdie (unknown [IPv6:2001:718:1a02:1::404]) by mail.nic.cz (Postfix) with ESMTPSA id 892946338C; Wed, 23 Jan 2019 10:08:57 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1548234537; bh=R65fWPMrhzOHvVVCDpxa1h/eexjk4AAbvtz8CgK5P6M=; h=From:To:Date; b=sUp9rHz1seIsA374bnnDz+dG+hRMoeiIBvwa4WKBcQCB1YWJqh+NZeyPEeR9YucVE H93Qia8EJ2UjUnXVFGWD4IrL7BeCMnub52bWWsiFcsyd76NU4iHHvHZLteI+YkM8/T yM2gC0eJn/Z518SB+6x1HAz6jSgNK9VLVlQWHGlk=
Message-ID: <74815665dee940dddf16eb14c5c98170435aafd9.camel@nic.cz>
From: Ladislav Lhotka <lhotka@nic.cz>
To: stephane.litkowski@orange.com, tom petch <ietfc@btconnect.com>, "Acee Lindem (acee)" <acee@cisco.com>, Yingzhen Qu <yingzhen.qu@huawei.com>, "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-isis-yang-isis-cfg@ietf.org" <draft-ietf-isis-yang-isis-cfg@ietf.org>
Date: Wed, 23 Jan 2019 10:08:57 +0100
In-Reply-To: <14660_1548173928_5C474268_14660_472_1_9E32478DFA9976438E7A22F69B08FF924B791E9B@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
References: <594D005A3CB0724DB547CF3E9A9E810B011230B1@sjceml521-mbx.china.huawei.com> <56F6AF71-F733-40E4-8C46-08C2803A3F90@cisco.com> <03aa01d4b250$9139d040$4001a8c0@gateway.2wire.net> <14660_1548173928_5C474268_14660_472_1_9E32478DFA9976438E7A22F69B08FF924B791E9B@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
Organization: CZ.NIC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.4
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: clamav-milter 0.99.2 at mail
X-Virus-Status: Clean
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/l1YEoqDPQgjHG113r9KjEgCoGSQ>
Subject: Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 09:09:04 -0000

Hi Stéphane,

the problem is in the source of the "ietf-isis" module inside <artwork>: the
chevrons enclosing email addresses should be encoded as XML entities &lt; and
&gt; but what I see there is &amp;lt; and &amp;gt;

Lada

On Tue, 2019-01-22 at 16:18 +0000, stephane.litkowski@orange.com wrote:
> Hi Tom,
> 
> This is plaintext. You can see it in the XML source of the draft, there is no
> link in the YANG module.
> Is your concern coming from the "[" "]" characters ? Just a copy/paste from
> the text version of the boilerplate, but there is no link behind.
> 
> 
> -----Original Message-----
> From: Lsr [mailto:lsr-bounces@ietf.org] On Behalf Of tom petch
> Sent: Tuesday, January 22, 2019 13:48
> To: Acee Lindem (acee); Yingzhen Qu; lsr@ietf.org; 
> draft-ietf-isis-yang-isis-cfg@ietf.org
> Subject: Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-
> 29
> 
> -32 has the RFC2119 boilerplate in the YANG module - thank you - but...
> YANG modules must be plain text and
> 
>          "are to be interpreted as described in BCP 14 [RFC2119]
>           [RFC8174] when, and only when, they appear in all capitals, as
>           shown here."
> 
> looks rather like XML/HTML anchors and not plain text.
> 
> Time idnits learnt what a YANG module looks like!
> 
> Tom Petch
> 
> ----- Original Message -----
> From: "Acee Lindem (acee)" <acee@cisco.com>
> To: "Yingzhen Qu" <yingzhen.qu@huawei.com>; <lsr@ietf.org>;
> <draft-ietf-isis-yang-isis-cfg@ietf.org>
> Sent: Monday, January 21, 2019 9:07 PM
> Subject: Re: [Lsr] Shepherd review comments on
> draft-ietf-isis-yang-isis-cfg-29
> 
> 
> > Hi Yingzhen,
> > All the idnits warnings are fixed in the -32 version of the drafts.
> > Thanks,
> > Acee
> > 
> > From: Yingzhen Qu <yingzhen.qu@huawei.com>
> > Date: Friday, January 18, 2019 at 5:35 PM
> > To: "lsr@ietf.org" <lsr@ietf.org>,
> "draft-ietf-isis-yang-isis-cfg@ietf.org"
> <draft-ietf-isis-yang-isis-cfg@ietf.org>
> > Subject: Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
> > Resent-From: <alias-bounces@ietf.org>
> > Resent-To: Stephane Litkowski <stephane.litkowski@orange.com>, Derek
> Yeung <derek@arrcus.com>, Acee Lindem <acee@cisco.com>, Jeffrey Zhang
> <zzhang@juniper.
> 
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org
> https://www.ietf.org/mailman/listinfo/lsr
> 
> ______________________________________________________________________________
> ___________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce
> message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou
> falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged
> information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete
> this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.
> 
-- 
Ladislav Lhotka
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67