Re: [Lsr] I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt

<stephane.litkowski@orange.com> Fri, 07 June 2019 08:03 UTC

Return-Path: <stephane.litkowski@orange.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15C4E1200FD for <lsr@ietfa.amsl.com>; Fri, 7 Jun 2019 01:03:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6dWZzhKDT5c for <lsr@ietfa.amsl.com>; Fri, 7 Jun 2019 01:03:24 -0700 (PDT)
Received: from orange.com (mta239.mail.business.static.orange.com [80.12.66.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D1C4120071 for <lsr@ietf.org>; Fri, 7 Jun 2019 01:03:24 -0700 (PDT)
Received: from opfedar04.francetelecom.fr (unknown [xx.xx.xx.6]) by opfedar24.francetelecom.fr (ESMTP service) with ESMTP id 45Kw560WCTz5y3N; Fri, 7 Jun 2019 10:03:22 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.45]) by opfedar04.francetelecom.fr (ESMTP service) with ESMTP id 45Kw555V9Kz1xp3; Fri, 7 Jun 2019 10:03:21 +0200 (CEST)
Received: from OPEXCAUBMA3.corporate.adroot.infra.ftgroup ([fe80::90fe:7dc1:fb15:a02b]) by OPEXCAUBM42.corporate.adroot.infra.ftgroup ([fe80::1c8e:403e:fbea:5835%21]) with mapi id 14.03.0439.000; Fri, 7 Jun 2019 10:03:21 +0200
From: <stephane.litkowski@orange.com>
To: tom petch <ietfc@btconnect.com>
CC: "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt
Thread-Index: AQHVHIkXcoadz4AtdU6MtGdBBgFG+6aP1Qmg
Date: Fri, 7 Jun 2019 08:03:20 +0000
Message-ID: <6446_1559894601_5CFA1A49_6446_332_1_9E32478DFA9976438E7A22F69B08FF924C24C247@OPEXCAUBMA3.corporate.adroot.infra.ftgroup>
References: <155201267223.5419.13285476509262180235@ietfa.amsl.com> <018e01d51c88$8022ec40$4001a8c0@gateway.2wire.net>
In-Reply-To: <018e01d51c88$8022ec40$4001a8c0@gateway.2wire.net>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/lRZK2lKrZdZi9cddpx0l21XJspk>
Subject: Re: [Lsr] I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jun 2019 08:03:26 -0000

Hi Tom,

Thanks for your feedback.
Pls find some comments inline

Stephane

-----Original Message-----
From: tom petch [mailto:ietfc@btconnect.com] 
Sent: Thursday, June 06, 2019 18:59
To: LITKOWSKI Stephane OBS/OINIS
Cc: lsr@ietf.org
Subject: Re: I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt

Stephane

The YANG module has RFC5307 in a description clause but I do not see
this in the References of the I-D

[SLI] That's a mistake, I will fix it


I commented before on the lack of  a conditional when on
     augment "/if:interfaces/if:interface"
so every interface will get this object; is that intended?

[SLI] It looks good to me, if a device supports the ISIS model, all the interfaces should get the clns-mtu config statement.

In the example, is the system-id one reserved for documentation?
[SLI] No, but I'm personally not aware of system IDs reserved for documentation as we could have for IP addresses. If someone from the WG knows about it, I will be happy to change it.



Tom Petch

----- Original Message -----
From: <internet-drafts@ietf.org>;
To: <i-d-announce@ietf.org>;
Cc: <lsr@ietf.org>;
Sent: Friday, March 08, 2019 3:37 AM
Subject: I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt


>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Link State Routing WG of the IETF.
>
>         Title           : YANG Data Model for IS-IS Protocol
>         Authors         : Stephane Litkowski
>                           Derek Yeung
>                           Acee Lindem
>                           Jeffrey Zhang
>                           Ladislav Lhotka
> Filename        : draft-ietf-isis-yang-isis-cfg-35.txt
> Pages           : 111
> Date            : 2019-03-07
>
> Abstract:
>    This document defines a YANG data model that can be used to
configure
>    and manage IS-IS protocol on network elements.
>
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-isis-yang-isis-cfg/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-isis-yang-isis-cfg-35
> https://datatracker.ietf.org/doc/html/draft-ietf-isis-yang-isis-cfg-35
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-isis-yang-isis-cfg-35
>
>
> Please note that it may take a couple of minutes from the time of
submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.