Re: [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis

Donald Eastlake <d3e3e3@gmail.com> Wed, 03 March 2021 18:32 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7326B3A184C; Wed, 3 Mar 2021 10:32:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.848
X-Spam-Level:
X-Spam-Status: No, score=-1.848 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVuhXQm9wCho; Wed, 3 Mar 2021 10:32:38 -0800 (PST)
Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 789573A1854; Wed, 3 Mar 2021 10:32:38 -0800 (PST)
Received: by mail-il1-x129.google.com with SMTP id c10so22324560ilo.8; Wed, 03 Mar 2021 10:32:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YQqOc1obAJSqQJTP66A6TG2xXGfvPnvMCUvn8iK2YZo=; b=HMI7E7YWBMPl9L3ho9p9EZsy3tQKWxW6jc1efJcxeNI2rPRMflZc5VLEpBX+rjlL+P kizabRaE5E0q+dS5ANiYozRlZc5FVNyMcEoAghO1BxiatD/RQDn8FUpvPTiAB+0SI/zp WJj1txEA/hD1hDdA7KXsoW9hNDcw1H6FMvEy7nzkgDT3DLc4yXWen0DM4/pW/rIL5tvN 746dvxxvp5XBMK+2wR0nLI32a2LVrnsu6P2IkXSpc7Vt8YjaaX2DDSfa/cNsYCErbS3B O7GdlXIJmCCHndOmuzzbvz7H26Ay4IU5+xDijoWwiNfcMvn6n9i0fW61FslRVoWnnQKY aPJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YQqOc1obAJSqQJTP66A6TG2xXGfvPnvMCUvn8iK2YZo=; b=tkHzHJhp+D71H+xaF87EXOIIBxpVnDBdsLEPAn6YGV1qNT7E/4NAN3wf9kQ91ppV72 9w5beeDeIaFRh11I310NEjfQJwh+LkM1nA7V2aw790GoIdupj8bdQHJ+Bo9z1a8SZZN0 65o1Mi1bqoFNMil4o44lHbbxhAHJkRzDQOm95Fq5Kg82Hr2RsVheiT4ZrcOJKDs4lWUr sh+TpD23FTwci10i8CeNbu46zSVRcVMFTKw+i1Z0IIY2j+GElyGA7cfc+LLfk/zLPGXU Y42Iiweh34vdSMjxhOeoqBDSD0UduRe3roMJPo9kQ7tV4wYrha5TTKuGLP3jYVWSvv4D Uw3A==
X-Gm-Message-State: AOAM533B+BQXmHM5nhrSvzOLuqbrLlQqNq/geLbrGYwHJ5BtC1c4hzrf Z4oYVv+1j/U+ybMTqiG93ReiMrw0qOwcGcteC1YQYcHmSKzb3w==
X-Google-Smtp-Source: ABdhPJwNYYosJQj/1ngUdOJQiTJ7OYIHHNuySWz8aQnpX14sZ3D+U86JJ2SoXM7qCj4g5B3OKHYieLVGd6ASuyZaVcU=
X-Received: by 2002:a05:6e02:ef4:: with SMTP id j20mr495936ilk.199.1614796356785; Wed, 03 Mar 2021 10:32:36 -0800 (PST)
MIME-Version: 1.0
References: <A31F6308-B1A4-4CD7-AC71-BB6722CAC1A7@chopps.org>
In-Reply-To: <A31F6308-B1A4-4CD7-AC71-BB6722CAC1A7@chopps.org>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 3 Mar 2021 13:32:25 -0500
Message-ID: <CAF4+nEHc=ZsLMAijh94PFg8C23_BSYP2VtJNPmFLAxst8K9P-g@mail.gmail.com>
To: Christian Hopps <chopps@chopps.org>
Cc: lsr@ietf.org, teas-chairs@ietf.org, teas-ads@ietf.org, teas@ietf.org, lsr-chairs@ietf.org, lsr-ads@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/p8w6uHFKodSjy9F3v_2StSpW7-Q>
Subject: Re: [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 18:32:46 -0000

Hi,

I have a few comments. Sorry to send these so late in the process. I
support publication of this draft regardless of whether any action is
taken on my comments.

1. Since there are non-allocation actions, I suggest that the first
sentence of Section 6 be more like "IANA is requested to take the
following actions."

2. It should be called out as an explicit IANA action to replace all
References to "[RFC5316]" on the IANA IS-IS TLV Codepoints web page
with References to "[this document]".

3. Use of "new" throughout the document for codepoints that were
assigned for RFC 5316 more than a decade ago should be eliminated.

4. I generally think it is better for implementation requirements to
be in the main text rather than the IANA Considerations, so I suggest
moving "Note that all four sub-TLVs SHOULD NOT appear in TLVs 22, 23,
25, 222, or 223 and MUST be ignored if they are included in any of
these TLVs." up to near the end of Section 3.1.

2. I like diagrams and enjoy doing ASCII art, so I suggest replacing
the prose table at the beginning of 3.1 with the following. In any
case note that the usual IETF admonition regarding the reserved bits,
that they MUST be sent as zero and ignored on receipt, seems to be
missing in the document.

    0                   1                   2                   3
    0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
   |   Router ID                                     (4 octets)    |
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
   |   default metric                              | (3 octets)
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
   |S|D| Rsvd      |                                 (1 octet)
   +-+-+-+-+-+-+-+-+
   |sub-TLVs length|                                 (1 octet)
   +-+-+-+-+-+-+-+-+-+-+-+-
   | sub-TLVs ...                                    (0-246 octets)
   +-+-+-+-+-+-+-+-+-+-+-+-

     - S, D: Flooding-scope and up/down information discussed below.
     - Rsvd: 6 reserved bits that MUST be sent as zero and ignored
             on receipt.
     - sub-TLVs length: gives the total number of octets of sub-TLVs,
             which is variable from zero to 246 octets, as an unsigned
             integer. sub-TLVs are structured as shown below. sub-TLVs
             with an unknown type MUST be ignored. If the value of the
             sub-TLVs length field is larger than 246, or the last
             sub-TLV extends beyond the sub-TLVs length, the TLV is
             malformed and MUST be ignored.

   +-+-+-+-+-+-+-+-+
   | sub-type      |                                 (1 octet)
   +-+-+-+-+-+-+-+-+
   | sub-TLV length|                                 (1 octet)
   +-+-+-+-+-+-+-+-+-+-+-+-
   | sub-TLV value ...                               (variable)
   +-+-+-+-+-+-+-+-+-+-+-+-


Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com

On Wed, Feb 17, 2021 at 10:30 AM Christian Hopps <chopps@chopps.org> wrote:
>
> Hi LSR and TEAS,
>
> This begins a joint WG last call for:
>
>   https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-rfc5316bis/
>
> Please discuss any issues on the LSR mailing list. The WGLC will end March 3, 2021.
>
> Authors, please indicate wether you are aware of any IPR related to this document to the list.
>
> Thanks,
> Chris, Acee, (Lou and Pavan).