Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29

Yingzhen Qu <yingzhen.qu@huawei.com> Mon, 21 January 2019 21:28 UTC

Return-Path: <yingzhen.qu@huawei.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CE4112950A; Mon, 21 Jan 2019 13:28:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aZnZvUytO9_3; Mon, 21 Jan 2019 13:28:43 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C04112D4E9; Mon, 21 Jan 2019 13:28:42 -0800 (PST)
Received: from lhreml704-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 0EA6ED0CC8F86F68565F; Mon, 21 Jan 2019 21:28:40 +0000 (GMT)
Received: from SJCEML703-CHM.china.huawei.com (10.208.112.39) by lhreml704-cah.china.huawei.com (10.201.108.45) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 21 Jan 2019 21:28:39 +0000
Received: from SJCEML521-MBX.china.huawei.com ([169.254.1.96]) by SJCEML703-CHM.china.huawei.com ([169.254.5.115]) with mapi id 14.03.0415.000; Mon, 21 Jan 2019 13:28:35 -0800
From: Yingzhen Qu <yingzhen.qu@huawei.com>
To: "Acee Lindem (acee)" <acee@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-isis-yang-isis-cfg@ietf.org" <draft-ietf-isis-yang-isis-cfg@ietf.org>
Thread-Topic: Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
Thread-Index: AdSvfV6+mHVGNqpKR26/bX73rx4nrACT/+eAAACxfNA=
Date: Mon, 21 Jan 2019 21:28:34 +0000
Message-ID: <594D005A3CB0724DB547CF3E9A9E810B01131EC4@sjceml521-mbx.china.huawei.com>
References: <594D005A3CB0724DB547CF3E9A9E810B011230B1@sjceml521-mbx.china.huawei.com> <56F6AF71-F733-40E4-8C46-08C2803A3F90@cisco.com>
In-Reply-To: <56F6AF71-F733-40E4-8C46-08C2803A3F90@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.209.216.155]
Content-Type: multipart/alternative; boundary="_000_594D005A3CB0724DB547CF3E9A9E810B01131EC4sjceml521mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/rNOyZHbDPckMPaU04xOPtybB7ZI>
Subject: Re: [Lsr] Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jan 2019 21:28:47 -0000

Great. Let me double check and upload the shepherd write-up to data tracker.

Thanks,
Yingzhen

From: Acee Lindem (acee) [mailto:acee@cisco.com]
Sent: Monday, January 21, 2019 1:08 PM
To: Yingzhen Qu <yingzhen.qu@huawei.com>;; lsr@ietf.org; draft-ietf-isis-yang-isis-cfg@ietf.org
Subject: Re: Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29

Hi Yingzhen,
All the idnits warnings are fixed in the -32 version of the drafts.
Thanks,
Acee

From: Yingzhen Qu <yingzhen.qu@huawei.com<mailto:yingzhen.qu@huawei.com>>
Date: Friday, January 18, 2019 at 5:35 PM
To: "lsr@ietf.org<mailto:lsr@ietf.org>" <lsr@ietf.org<mailto:lsr@ietf.org>>, "draft-ietf-isis-yang-isis-cfg@ietf.org<mailto:draft-ietf-isis-yang-isis-cfg@ietf.org>" <draft-ietf-isis-yang-isis-cfg@ietf.org<mailto:draft-ietf-isis-yang-isis-cfg@ietf.org>>
Subject: Shepherd review comments on draft-ietf-isis-yang-isis-cfg-29
Resent-From: <alias-bounces@ietf.org<mailto:alias-bounces@ietf.org>>
Resent-To: Stephane Litkowski <stephane.litkowski@orange.com<mailto:stephane.litkowski@orange.com>>, Derek Yeung <derek@arrcus.com<mailto:derek@arrcus.com>>, Acee Lindem <acee@cisco.com<mailto:acee@cisco.com>>, Jeffrey Zhang <zzhang@juniper.net<mailto:zzhang@juniper.net>>, Ladislav Lhotka <lhotka@nic.cz<mailto:lhotka@nic.cz>>
Resent-Date: Friday, January 18, 2019 at 5:35 PM

Hi Authors,

Here are some comments I have based on draft version 29.

Here are the warnings from “idnits”. To resolve those unused reference issue, I’d suggest to use what’s done in the ospf model draft, beginning of Section 3.

idnits 2.16.01

/tmp/draft-ietf-isis-yang-isis-cfg-29.txt:
/tmp/draft-ietf-isis-yang-isis-cfg-29.txt(273): Line has weird spacing: '...-method    str...'
/tmp/draft-ietf-isis-yang-isis-cfg-29.txt(733): Line has weird spacing: '...-family    ian...'
/tmp/draft-ietf-isis-yang-isis-cfg-29.txt(1238): Code start at 1238: <CODE BEGINS> file "ietf-isis@2018-12-27.yang<mailto:ietf-isis@2018-12-27.yang>".
/tmp/draft-ietf-isis-yang-isis-cfg-29.txt(5568): Line has weird spacing: '... system  recei...'
/tmp/draft-ietf-isis-yang-isis-cfg-29.txt(5671): Code end at 5671: <CODE ENDS>.


  Checking boilerplate required by RFC 5378 and the IETF Trust (see
  https://trustee.ietf.org/license-info):
  ----------------------------------------------------------------------------

     No issues found here.

  Checking nits according to https://www.ietf.org/id-info/1id-guidelines.txt:
  ----------------------------------------------------------------------------

  == The page length should not exceed 58 lines per page, but there was 7
     longer pages, the longest (page 6) being 63 lines


  Checking nits according to https://www.ietf.org/id-info/checklist :
  ----------------------------------------------------------------------------

     No issues found here.

  Miscellaneous warnings:
  ----------------------------------------------------------------------------

  == The copyright year in the IETF Trust and authors Copyright Line does not
     match the current year

  -- The document date (December 27, 2018) is 15 days in the past.  Is this
     intentional?


  Checking references for intended status: Proposed Standard
  ----------------------------------------------------------------------------

     (See RFCs 3967 and 4897 for information about using normative references
     to lower-maturity documents in RFCs)

  == Unused Reference: 'RFC5130' is defined on line 5236, but no explicit
     reference was found in the text
     '[RFC5130]  Previdi, S., Shand, M., Ed., and C. Martin, "A Policy Con...'

  == Unused Reference: 'RFC5305' is defined on line 5246, but no explicit
     reference was found in the text
     '[RFC5305]  Li, T. and H. Smit, "IS-IS Extensions for Traffic Enginee...'

  == Unused Reference: 'RFC5306' is defined on line 5250, but no explicit
     reference was found in the text
     '[RFC5306]  Shand, M. and L. Ginsberg, "Restart Signaling for IS-IS",...'

  == Unused Reference: 'RFC5880' is defined on line 5258, but no explicit
     reference was found in the text
     '[RFC5880]  Katz, D. and D. Ward, "Bidirectional Forwarding Detection...'

  == Unused Reference: 'RFC5881' is defined on line 5262, but no explicit
     reference was found in the text
     '[RFC5881]  Katz, D. and D. Ward, "Bidirectional Forwarding Detection...'

  == Unused Reference: 'RFC6119' is defined on line 5272, but no explicit
     reference was found in the text
     '[RFC6119]  Harrison, J., Berger, J., and M. Bartlett, "IPv6 Traffic...'

  == Unused Reference: 'RFC6232' is defined on line 5276, but no explicit
     reference was found in the text
     '[RFC6232]  Wei, F., Qin, Y., Li, Z., Li, T., and J. Dong, "Purge Ori...'

  == Unused Reference: 'RFC7794' is defined on line 5299, but no explicit
     reference was found in the text
     '[RFC7794]  Ginsberg, L., Ed., Decraene, B., Previdi, S., Xu, X., and...'

  == Unused Reference: 'RFC7810' is defined on line 5304, but no explicit
     reference was found in the text
     '[RFC7810]  Previdi, S., Ed., Giacalone, S., Ward, D., Drake, J., and...'

  == Unused Reference: 'RFC7917' is defined on line 5309, but no explicit
     reference was found in the text
     '[RFC7917]  Sarkar, P., Ed., Gredler, H., Hegde, S., Litkowski, S., a...'

  == Unused Reference: 'RFC8405' is defined on line 5355, but no explicit
     reference was found in the text
     '[RFC8405]  Decraene, B., Litkowski, S., Gredler, H., Lindem, A., Fra...'

  ** Downref: Normative reference to an Informational RFC: RFC 5443


     Summary: 1 error (**), 0 flaws (~~), 13 warnings (==), 1 comment (--).



Nits:

·        The draft title “protocol” should start with capital letter P.

·        I don’t think the word “container” is needed here:

420        The IS-IS configuration container is divided in:



422        o  Global parameters.



424        o  Per interface configuration (see Section 2.4).


·        Should be “raised”

978         if-state-change: raise when the state of an interface changes.

·        “the system finds”

980         corrupted-lsp-detected: raised when the system find that an LSP

981         that was stored in memory has become corrupted.

·        I’d suggest change it to “isis” container, instead of configuration container. Or maybe change it to “isis module” to be consistent with the next following paragraph.

1033        The "isis" configuration container augments the "/rt:routing/

·        Repetition of section 2.5
1049        The modules defined in this document use some groupings from ietf-
1050        keychain [RFC8177].

·        I’d suggest to change to “This YANG module” to be consistent with the beginning of the description.
1154        This YANG model conforms to the Network Management

·        Typo
4888     For IS-IS authentication, configuration is supported vua the

·        In IANA consideration, the registrant contact should be “The IESG”

4914                URI: urn:ietf:params:xml:ns:yang:ietf-isis

4915                Registrant Contact: IS-IS WG

4916                XML: N/A, the requested URI is an XML namespace





Thanks,

Yingzhen