Re: [Lsr] I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt

tom petch <ietfc@btconnect.com> Fri, 07 June 2019 10:33 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6407C1201F2 for <lsr@ietfa.amsl.com>; Fri, 7 Jun 2019 03:33:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.248
X-Spam-Level:
X-Spam-Status: No, score=0.248 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vKOozG001E8I for <lsr@ietfa.amsl.com>; Fri, 7 Jun 2019 03:33:54 -0700 (PDT)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20130.outbound.protection.outlook.com [40.107.2.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 470341201F1 for <lsr@ietf.org>; Fri, 7 Jun 2019 03:33:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l4J9yIqjdHpKDG9Gj9rrpvJsQXy4Ug4Eqb5Ee6rUwF8=; b=fIwP7lXGLLTgLCkJ9c9ny288doVLGQfV3iFbhfZD00GEJ/DRSFGptUKkYs2jaInWOWs3NsVl2Hq4M0Vvu75aDyb3c4DrnvhdPcf283cZstnaXfejqYhCppSnSE+f7hojOWHV0nQkJtQ98hCxNdZml+W2rj4KmVBFNyeLy7xIZfY=
Received: from VI1PR07MB3118.eurprd07.prod.outlook.com (10.175.242.156) by VI1PR07MB4638.eurprd07.prod.outlook.com (20.177.57.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.5; Fri, 7 Jun 2019 10:33:51 +0000
Received: from VI1PR07MB3118.eurprd07.prod.outlook.com ([fe80::7537:44ee:88c1:dd6d]) by VI1PR07MB3118.eurprd07.prod.outlook.com ([fe80::7537:44ee:88c1:dd6d%7]) with mapi id 15.20.1987.004; Fri, 7 Jun 2019 10:33:51 +0000
From: tom petch <ietfc@btconnect.com>
To: "stephane.litkowski@orange.com" <stephane.litkowski@orange.com>
CC: "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt
Thread-Index: AQHVHIkXcoadz4AtdU6MtGdBBgFG+w==
Date: Fri, 7 Jun 2019 10:33:50 +0000
Message-ID: <019701d51d1b$e7223980$4001a8c0@gateway.2wire.net>
References: <155201267223.5419.13285476509262180235@ietfa.amsl.com> <018e01d51c88$8022ec40$4001a8c0@gateway.2wire.net> <6446_1559894601_5CFA1A49_6446_332_1_9E32478DFA9976438E7A22F69B08FF924C24C247@OPEXCAUBMA3.corporate.adroot.infra.ftgroup>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::35) To VI1PR07MB3118.eurprd07.prod.outlook.com (2603:10a6:802:20::28)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.215.234]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 46853bce-0dd6-4c6e-6431-08d6eb33a19b
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:VI1PR07MB4638;
x-ms-traffictypediagnostic: VI1PR07MB4638:
x-ms-exchange-purlcount: 6
x-microsoft-antispam-prvs: <VI1PR07MB463852DA9320C2DB13D222F2A0100@VI1PR07MB4638.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1728;
x-forefront-prvs: 0061C35778
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(376002)(346002)(39860400002)(136003)(13464003)(189003)(199004)(61296003)(26005)(86362001)(186003)(4720700003)(2501003)(71190400001)(4326008)(6916009)(25786009)(6246003)(316002)(62236002)(44716002)(478600001)(14454004)(71200400001)(966005)(2351001)(3846002)(6116002)(256004)(14444005)(5024004)(486006)(446003)(476003)(84392002)(68736007)(2906002)(66066001)(66574012)(102836004)(6506007)(386003)(8676002)(52116002)(229853002)(81166006)(81156014)(76176011)(81816011)(81686011)(64756008)(66556008)(66476007)(66946007)(66446008)(305945005)(7736002)(73956011)(1556002)(14496001)(8936002)(50226002)(5640700003)(6306002)(6512007)(9686003)(6486002)(99286004)(44736005)(53936002)(5660300002)(6436002)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB4638; H:VI1PR07MB3118.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: aAaIUF/o7Jiqy8WWVJxeVyuuIpqDi6Ij/t25m3NT8gxy5lDHSt4CVhQV5TfXtKQMZssnR+5D8ny5/BjpmEdQhJVbMtV8TmfL/oD49fggzZr4XfIKHqnG4CRksUoPn0n7IxYWfSHrFaL9lBzFLNTb+pplXIIFwYsR3SVzvw2gTpz7ILrULhGU2u59s5ypDDrW1R8fsgoYr4g06XUbTREwydXFkbC+KXF1l3Syft2PWJO5XTK/jDShBaDnrnvV+tB616mo51Bkm6pXwIc222x+sk7ifaKsmTfREp3id/mfv7TX7WPE7xFZ48XcCAmh90595U24JzqEGpwTRPT96pPI09+QbdM0i8JylFUEsFlyF5eERHe0uCxBrG1XBNC0tpEh8qwNSbE9bMo+RrCkot8P3jgBMVWKKt32WCjMZjtrNiQ=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <A30161776530F74ABEA4B901EEEDABCF@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46853bce-0dd6-4c6e-6431-08d6eb33a19b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2019 10:33:51.0326 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ietfc@btconnect.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB4638
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/u4DjmCfcugVClT8Oy_a515LndNk>
Subject: Re: [Lsr] I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jun 2019 10:33:56 -0000

<inline>

---- Original Message -----
From: <stephane.litkowski@orange.com>;
Sent: Friday, June 07, 2019 9:03 AM

Hi Tom,

Thanks for your feedback.
Pls find some comments inline

Stephane

-----Original Message-----
From: tom petch [mailto:ietfc@btconnect.com]
Sent: Thursday, June 06, 2019 18:59

Stephane

The YANG module has RFC5307 in a description clause but I do not see
this in the References of the I-D

[SLI] That's a mistake, I will fix it


I commented before on the lack of  a conditional when on
     augment "/if:interfaces/if:interface"
so every interface will get this object; is that intended?

[SLI] It looks good to me, if a device supports the ISIS model, all the
interfaces should get the clns-mtu config statement.

<tp>

Well, yes, the server will understand what the definition is but a user
might be surprised to find the object present on an ospf passive
interface or a LAN interface running RIP - I do not see that as a big
problem but thought I would ask.

In the example, is the system-id one reserved for documentation?
[SLI] No, but I'm personally not aware of system IDs reserved for
documentation as we could have for IP addresses. If someone from the WG
knows about it, I will be happy to change it.

<tp>
I did look and there are identifiers reserved for documenation for all
sorts of things but not AFAICT for system-id; I wondered if there was
any convention in the ISO documents.  I am twitchy about using
potentially real identifiers in documentation ever since I encountered
an organisation which had to renumber everything because the engineer
who had set up the organisation's network had been on a course to learn
how to do it, the course has used real addresses and the engineer had
then used these real addresses for his organisation's network thinking
that that was what everyone had to do - oh dear.

Tom Petch

----- Original Message -----
From: <internet-drafts@ietf.org>;
To: <i-d-announce@ietf.org>;
Cc: <lsr@ietf.org>;
Sent: Friday, March 08, 2019 3:37 AM
Subject: I-D Action: draft-ietf-isis-yang-isis-cfg-35.txt


>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Link State Routing WG of the IETF.
>
>         Title           : YANG Data Model for IS-IS Protocol
>         Authors         : Stephane Litkowski
>                           Derek Yeung
>                           Acee Lindem
>                           Jeffrey Zhang
>                           Ladislav Lhotka
> Filename        : draft-ietf-isis-yang-isis-cfg-35.txt
> Pages           : 111
> Date            : 2019-03-07
>
> Abstract:
>    This document defines a YANG data model that can be used to
configure
>    and manage IS-IS protocol on network elements.
>
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-isis-yang-isis-cfg/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-isis-yang-isis-cfg-35
> https://datatracker.ietf.org/doc/html/draft-ietf-isis-yang-isis-cfg-35
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-isis-yang-isis-cfg-35
>
>
> Please note that it may take a couple of minutes from the time of
submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt


________________________________________________________________________
_________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez
recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme
ou falsifie. Merci.

This message and its attachments may contain confidential or privileged
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and
delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have
been modified, changed or falsified.
Thank you.