Re: [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis

"Acee Lindem (acee)" <acee@cisco.com> Wed, 03 March 2021 18:42 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7F30D3A182C; Wed, 3 Mar 2021 10:42:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.62
X-Spam-Level:
X-Spam-Status: No, score=-9.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=P7B9dLY7; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=dFK7mBwt
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3xVWlgCKUWb2; Wed, 3 Mar 2021 10:42:17 -0800 (PST)
Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BEC813A182B; Wed, 3 Mar 2021 10:42:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5694; q=dns/txt; s=iport; t=1614796937; x=1616006537; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Mj7XelqaqIqrEA0hctfoR61p9LOaH53aNpWy8lGQzbE=; b=P7B9dLY7ifPFjhuu3zEM/J1vseevSzc4Rwp1TIGt9K1yCSdkPH25G2Sh ZjuWQdZ3pNI4j550hKjl/S4w4H3LLfE4FwSIcajVxypY41+ZcqYGv+a9C OxSqzcNzlUSR1UQoUOcOCyIBs+Hy1mewKJHk8FtXHeNRDhLgfeM/3wMhx E=;
IronPort-PHdr: 9a23:/8DNDRexaQpYeW+u+PS1gyInlGMj4e+mNxMJ6pchl7NFe7ii+JKnJkHE+PFxlwaQAdfU7vtFj6zdtKWzEWAD4JPUtncEfdQMUhIekswZkkQmB9LNEkz0KvPmLklYVMRPXVNo5Te3ZE5SHsutaFjbo3n05jkXSV3zMANvLbHzHYjfx828y+G1/cjVZANFzDqwaL9/NlO4twLU48IXmoBlbK02z0jE
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CqBgDu1z9g/4YNJK1fAxwBAQEBAQEHAQESAQEEBAEBQIFPgVMjLgd2WjYxCgGENoNIA4U5iDAlA4okjn2CUwNUCwEBAQ0BASgKAgQBAYRNAheBYwIlOBMCAwEBCwEBBQEBAQIBBgRxhWENhkUBBR0GEQwBASwLAQ8CAQgOCgICJgICAh8RFRACBAENBYJwAYJVAy8BDqMTAooldoEygwQBAQaBR0GDHA0LghIDBoEOKoJ2g3cRglKDcyYcgguBEAEnDBCCVz6CGkICAwGBXBcKJoJPNIIrgU91agRTImNHZZNZQaUMWwqCfIk/jTWFLAMfgzeKT5VQlFWLPYMCjxgOhDgCBAIEBQIOAQEGgWsjgVdwFRohKgGCPlAXAg2OH4NvhRSFRXM1AwIGAQkBAQMJfIoIAYEOAQE
X-IronPort-AV: E=Sophos;i="5.81,220,1610409600"; d="scan'208";a="854937193"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 03 Mar 2021 18:41:57 +0000
Received: from mail.cisco.com (xbe-aln-002.cisco.com [173.36.7.17]) by alln-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id 123IfhZi000800 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=OK); Wed, 3 Mar 2021 18:41:57 GMT
Received: from xfe-rcd-005.cisco.com (173.37.227.253) by xbe-aln-002.cisco.com (173.36.7.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 3 Mar 2021 12:41:57 -0600
Received: from xfe-rcd-005.cisco.com (173.37.227.253) by xfe-rcd-005.cisco.com (173.37.227.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 3 Mar 2021 12:41:54 -0600
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (72.163.14.9) by xfe-rcd-005.cisco.com (173.37.227.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3 via Frontend Transport; Wed, 3 Mar 2021 12:41:54 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAmJ96BJaKVMo/1cc8dlh/NRMdpXL2zlAm8tDYRE6Bg+Wnxd9mcmX2WKuaZx5obQ9K5k0akbHI9iGHhXi6bpsa4M2ZaDd3EQfrFejC6sz2AYJNYCDsVbRHSvSRQf/jFeJ/yOw6PfRi5DhguNpAyLMKq8UpctbsHRT9HADVavZ+3lGo4I8Fs9+LH2sZm4QX1SQJV93F5keU9PDgOMUk6MHZSSmmYQj/Mrt5iJFPnvh2e8jVWdIw3N9gyBp/LrwU5bv54MQQ23HDz96+jNRJvqJWV51MLGgM6hsIVX3tCeTvOyRxfNJXYAMsUbH+XIryvxdohzSzSJqAkO7pOpk5YbIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mj7XelqaqIqrEA0hctfoR61p9LOaH53aNpWy8lGQzbE=; b=ixLZmoM6I2zwFqQMQaCJOMnJtDzHVzxZNjyMC+tgn4CSw21DqmpxdthdP2m+vdI54v0HxpY/1sDgk7OHx9QeF2Pqp+luvKZnEJWLwwI5hOyp1nGIyhooYDnEe/BndScurKIqTeEMWPMrNMQDtVOWmULwWXGaHhKlnetJJ5UWwFHaVbfLTWTHyzd6ETp9M2IP98Nd8dNysnWfER1lc8xjouZ6906ko0NUIgE780nm+FS7aMSRxLVB+mKZ/XcZkHIrlscPsEqUKHJDSGrJIC9eNNO5yW+e0/HwV9+Ap42AQ7qw1LO+9BAGza9ywkY41Kc9ZCRYa/Ba4/w3LLV52LuCwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mj7XelqaqIqrEA0hctfoR61p9LOaH53aNpWy8lGQzbE=; b=dFK7mBwtHZFKZL4QQD0QLaNmWO+WftDJ1WEcTDWgblQzc1ju6ibK4aAj7OOEtTgv4w8BuNpKvMMTzaoaDS5ge4Thz6s17n+uMqoNsIxuonkgcEjqoCWXKWY031yPnjS8N4hgZ1r2MskeUjhwjKp32BOw5nRIH2vqYLLWPwDM2kI=
Received: from BYAPR11MB2887.namprd11.prod.outlook.com (2603:10b6:a03:89::27) by BYAPR11MB3800.namprd11.prod.outlook.com (2603:10b6:a03:f5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Wed, 3 Mar 2021 18:40:39 +0000
Received: from BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::a053:fad0:cf70:98b6]) by BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::a053:fad0:cf70:98b6%4]) with mapi id 15.20.3890.028; Wed, 3 Mar 2021 18:40:38 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Donald Eastlake <d3e3e3@gmail.com>, Christian Hopps <chopps@chopps.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "teas-chairs@ietf.org" <teas-chairs@ietf.org>, "teas-ads@ietf.org" <teas-ads@ietf.org>, "teas@ietf.org" <teas@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr-ads@ietf.org" <lsr-ads@ietf.org>
Thread-Topic: [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis
Thread-Index: AQHXBUHkdZ0zTo9oxEyYq8qttkKtiKpyrJmA//+udwA=
Date: Wed, 03 Mar 2021 18:40:38 +0000
Message-ID: <6A65C69B-6810-4913-BF25-AB578E8E9180@cisco.com>
References: <A31F6308-B1A4-4CD7-AC71-BB6722CAC1A7@chopps.org> <CAF4+nEHc=ZsLMAijh94PFg8C23_BSYP2VtJNPmFLAxst8K9P-g@mail.gmail.com>
In-Reply-To: <CAF4+nEHc=ZsLMAijh94PFg8C23_BSYP2VtJNPmFLAxst8K9P-g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.46.21021202
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [136.56.133.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 60b158b3-9d09-48e5-4684-08d8de73d76d
x-ms-traffictypediagnostic: BYAPR11MB3800:
x-microsoft-antispam-prvs: <BYAPR11MB38006232DC9C3ECEFF2D919DC2989@BYAPR11MB3800.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: kw7mia6sWpFHyZzz+hfYXxSDxdnsOmV4QGmKCCxzqUAJHpNI58U6AJKg2VbcxoTdXowUqXTcDy3vXlfoUaMJvO+2Mqwft3ExhobxeKT7xlun/y2vUBVdIDej6DE0+nHnOXSWIyFIojnnQw4Wtv5F2KpGjKEbz/sqzE/DAeEiqaLDvFYEkRA7TQTFu+WSKt0VOl5rn+mlzEfDYXyf4jOfxYTuuv18B6vCXOUz7Ra/wAY4+EPYYB/X3AFuwoASoJB4Dzyt+JsgcOi9Mfj652DyStg3zPRfg9zpPJ+biDniptaXHG4QcesZK8ibPTPHyIRqdnMP4N5Uf+/dFsYm9Fh8VqD70JWvSWBXsAAkhOTSC+KqOkH247AchMkSjSzvf5+H8qn1fi3Lb3tWMOZYEKNYbpPK+BEHVrSwv/7rYQlw3imLhJWy2ddB8/3vr0dSbHKtecZP4dYE+riIvg3VNQy05o+3qMjPbO7eU+iQ4KzciOZdaMALgauFuQNciZVRPHeyMXCYM7RGiXtwCa4JfpeRvQEag2kx8iz7t7/V4Gasu2AJ+aj54DEcae+GJjP2j4KEE/+ifOglhOhbN5eCCUtiUWpVVQfwPTIFrrWPTNxzOiUyeMVRm0hGc3NOMN2reUkSGqWocdIOOGTSx6gb9L37+g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2887.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(396003)(346002)(376002)(366004)(91956017)(6486002)(76116006)(4326008)(66446008)(316002)(2906002)(66556008)(6512007)(66476007)(66946007)(83380400001)(64756008)(2616005)(186003)(8936002)(478600001)(5660300002)(86362001)(8676002)(71200400001)(26005)(54906003)(966005)(110136005)(36756003)(66574015)(53546011)(6506007)(33656002)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: QX/zRc5sfrdeb3T5DbnYiBLDw+ZJAIAQfXwvfPQuZCpxN9tkHpo8IrlVYDcy7U1SKh2ViFUGhaC8u1XcHzZQyw0Cck2C+w6B3k0pxLdLpbViUx8wI6zYpQF5bMDrIZP4Y/1acJZwy2l1Sce9vel6HSzm6FGWD2dF02V84UKcZdIGxe7fK0iXpB48JDpnGKEH5CFosDzecuvRsYLgs32Qv5vc3UD3fEVrot0ZYicysHhOOnmzavtEHKSWtLVeCyhNptRv2S2H2gMkL2tw7qz6OoAzM2KT1MCV1nQDdKwv2pqa52agPnz84v/6+E0JuusCvi+JpjLQnw2FT4EHMxnbMTbkvRCc8F3Khzh6vh+penLVK9TD9D/dtqfbDUqrvV0VGNGkBJB1lrAWb4gaHYemLUqc+YHbeYP73GFa4tzTsGmXzdWlzTW/iBstKTfyJRG6gf6NnuVehqR/SuICwvLsWDTdBSU3BShYS237GlbfaWH12TtleGmJu1nU8B2BKul25ZBgvBzbXqRtnYT5LN0/VemBSzGCm5p7Rc+Ea110iGQT++OJB2O9VuhgZFDXDkDoayWALbAZcOtbFdrzIM0Y0QHDzlkzjFySSCr/Ft4CxOPba5OJWzXmZQ31yN7BTeq61LTYuppxRKh76AVMJYZ5DSaSre+MOWJxJ8rUmj53+etlN0tFyPeMbOla3dhbSU6dif9Zf2NdBlJcTBAffaxqxaqBnFqbs7/v8wWIpe0RJFqdGOn9pHBKXYLKpVd2hrZSQ783PLAavR9bxRM/Dp2nQFgdizHCcqWQDGqqr9FQiFUzvucX29ZnSdhocTaP0/kO/MyiPRzemTV6u0CbZPg2Js6TnSfIe4E+ch+za5zp6Xk1VgjaqEXFQI/FEOsecqOkXOyM+NQwJn2XPImSb19FC7MGNxRzqZ3ze+4jPl/xgTPgrPTUHOsgYPjklbLcViCVLyQJoKAJwWFql3hDNScMcwOVIJsVOUjyr3BFFoUDqwaxWcqut6VIFZ1mE2QzVPhlJndhG/QqkomPh4Q7FoS3/SrLrCPrxbORw4JgN3GQrIf4m7mDBqWRDSkQ5S7wlandCcpDWJSIXfNYEZpLBAsaB0yARvxRXonqFWP2AXa4Hwv4CuhPtqQAJawjSx/8Q9whRVFE6OZ7NlAG1gqlZ3uxzcxlmMbSH4Xwl/8rb5DgZ+afzyAZOV4XMYq/Ju6FWWX19+ZcfhdoPV7Y70WWR2sQ5JVrnQSYPXQf+whCnNXIwTP4wu+LqaN8rOfHbSDu95wCB3KwfG12rjwndh2VYsO7dNi0/K90ZyMAA7iV/2FPwsYyGkVUQtDNIA6zWspbT+iXKs3mSlQm44yIAA+Y2xCiPg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <33721A0D2A0D52489AE05452411057B8@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2887.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60b158b3-9d09-48e5-4684-08d8de73d76d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2021 18:40:38.8184 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9MN1AQPSbmdmPaM8DR0HIjmmGOgcG4l3c0W4vJOyMw6wT/tF4IL1MmjXE0l5a8Js
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3800
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.17, xbe-aln-002.cisco.com
X-Outbound-Node: alln-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/vuXdeN9YDewyHn2c619xtZF2hUc>
Subject: Re: [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 18:42:20 -0000

Speaking as WG member:

As long as we are revising, I'd suggest changing "ISIS" in the title and several times in the text to "IS-IS" consistent with other IS-IS RFCs (at least the newer ones). 
Thanks,
Acee

On 3/3/21, 1:32 PM, "Donald Eastlake" <d3e3e3@gmail.com> wrote:

    Hi,

    I have a few comments. Sorry to send these so late in the process. I
    support publication of this draft regardless of whether any action is
    taken on my comments.

    1. Since there are non-allocation actions, I suggest that the first
    sentence of Section 6 be more like "IANA is requested to take the
    following actions."

    2. It should be called out as an explicit IANA action to replace all
    References to "[RFC5316]" on the IANA IS-IS TLV Codepoints web page
    with References to "[this document]".

    3. Use of "new" throughout the document for codepoints that were
    assigned for RFC 5316 more than a decade ago should be eliminated.

    4. I generally think it is better for implementation requirements to
    be in the main text rather than the IANA Considerations, so I suggest
    moving "Note that all four sub-TLVs SHOULD NOT appear in TLVs 22, 23,
    25, 222, or 223 and MUST be ignored if they are included in any of
    these TLVs." up to near the end of Section 3.1.

    2. I like diagrams and enjoy doing ASCII art, so I suggest replacing
    the prose table at the beginning of 3.1 with the following. In any
    case note that the usual IETF admonition regarding the reserved bits,
    that they MUST be sent as zero and ignored on receipt, seems to be
    missing in the document.

        0                   1                   2                   3
        0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
       |   Router ID                                     (4 octets)    |
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
       |   default metric                              | (3 octets)
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
       |S|D| Rsvd      |                                 (1 octet)
       +-+-+-+-+-+-+-+-+
       |sub-TLVs length|                                 (1 octet)
       +-+-+-+-+-+-+-+-+-+-+-+-
       | sub-TLVs ...                                    (0-246 octets)
       +-+-+-+-+-+-+-+-+-+-+-+-

         - S, D: Flooding-scope and up/down information discussed below.
         - Rsvd: 6 reserved bits that MUST be sent as zero and ignored
                 on receipt.
         - sub-TLVs length: gives the total number of octets of sub-TLVs,
                 which is variable from zero to 246 octets, as an unsigned
                 integer. sub-TLVs are structured as shown below. sub-TLVs
                 with an unknown type MUST be ignored. If the value of the
                 sub-TLVs length field is larger than 246, or the last
                 sub-TLV extends beyond the sub-TLVs length, the TLV is
                 malformed and MUST be ignored.

       +-+-+-+-+-+-+-+-+
       | sub-type      |                                 (1 octet)
       +-+-+-+-+-+-+-+-+
       | sub-TLV length|                                 (1 octet)
       +-+-+-+-+-+-+-+-+-+-+-+-
       | sub-TLV value ...                               (variable)
       +-+-+-+-+-+-+-+-+-+-+-+-


    Thanks,
    Donald
    ===============================
     Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
     2386 Panoramic Circle, Apopka, FL 32703 USA
     d3e3e3@gmail.com

    On Wed, Feb 17, 2021 at 10:30 AM Christian Hopps <chopps@chopps.org> wrote:
    >
    > Hi LSR and TEAS,
    >
    > This begins a joint WG last call for:
    >
    >   https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-rfc5316bis/
    >
    > Please discuss any issues on the LSR mailing list. The WGLC will end March 3, 2021.
    >
    > Authors, please indicate wether you are aware of any IPR related to this document to the list.
    >
    > Thanks,
    > Chris, Acee, (Lou and Pavan).