Re: [Lsr] more feedback on draft-ietf-lsr-isis-srv6-extensions-04

Peter Psenak <ppsenak@cisco.com> Wed, 05 February 2020 11:13 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 096E612006D for <lsr@ietfa.amsl.com>; Wed, 5 Feb 2020 03:13:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.502
X-Spam-Level:
X-Spam-Status: No, score=-14.502 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i4fl2hvttphn for <lsr@ietfa.amsl.com>; Wed, 5 Feb 2020 03:13:57 -0800 (PST)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89F84120018 for <lsr@ietf.org>; Wed, 5 Feb 2020 03:13:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2126; q=dns/txt; s=iport; t=1580901236; x=1582110836; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=cbi/Ncdorg1oLWuo0uNGIlINFGQgcxgkb0WEHX6+hNs=; b=f4uVABIExWHyo99jKBD5L1VSp8m5JvHu8fMXartJ5tnOexd5lGflhvsF OYr+OaaBiBQPngB10NsvTFeLMetGEtElaZ+ryZ3VG22fC0RFOJjXaC07u bmzlRde9rNVCI82SCaQn0Z/9D1JuYdcD2r/rExvMTUsZ0mdtc3dcM2gUY g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CXAwDYojpe/xbLJq1lHAEBAQEBBwEBEQEEBAEBgXuDaiAShD+JA4gcmzsJAQEBDi8BAYRAAoJdOBMCAw0BAQQBAQECAQUEbYVDhWYBAQEBAgEjDwEFLyILGAICJgICVwYBDAgBAYMiglwgqyB1gTKFSoM+gT6BDiqKT4FtgUE/gREngmw+hEuDEIJeBI06oiyCRIJOikKJLQYbjneMEY5im0WBaSKBWDMaCBsVgyhPGA2OKReOJEADjmsBAQ
X-IronPort-AV: E=Sophos;i="5.70,405,1574121600"; d="scan'208";a="22985893"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 05 Feb 2020 11:13:52 +0000
Received: from [10.147.24.41] ([10.147.24.41]) by aer-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id 015BDqJT011985; Wed, 5 Feb 2020 11:13:52 GMT
To: Chris Bowers <chrisbowers.ietf@gmail.com>, lsr@ietf.org
References: <CAHzoHbv8PwaKZ9uvFhoGpkxaKApdCndM_kQt4JYsTUFn1Cng1Q@mail.gmail.com>
From: Peter Psenak <ppsenak@cisco.com>
Message-ID: <7d115b05-03df-6cbd-167b-37d4aff8a0ad@cisco.com>
Date: Wed, 05 Feb 2020 12:13:49 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <CAHzoHbv8PwaKZ9uvFhoGpkxaKApdCndM_kQt4JYsTUFn1Cng1Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.147.24.41, [10.147.24.41]
X-Outbound-Node: aer-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/zwNxPKO6td2pYA3w00fIB4-FkRA>
Subject: Re: [Lsr] more feedback on draft-ietf-lsr-isis-srv6-extensions-04
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 11:13:59 -0000

Hi Chris,

On 05/02/2020 00:27, Chris Bowers wrote:
> LSR,
> 
> I have some more feedback on draft-ietf-lsr-isis-srv6-extensions-04 that 
> I am putting in a separate thread so as not to confuse the other thread 
> related to N and A flags.
> 
> =======
> The end of Section 5 points out several issues that can result in 
> forwarding not working correctly.  The reader might think that the next 
> section is going to discuss protocol mechanisms to avoid these issues.  
> Since this is not the case, I think it would be helpful to add some text 
> near the end of Section 5 like:
> 
> "In order to ensure correct forwarding, network operators should take 
> steps to make sure that this requirement is not compromised."

##PP
sure.

> 
> 
> =========
> 
> In section 6, I think it would be useful to explicitly state the 
> following requirement for SRv6 Locator TLVs and their associated SRv6 SIDs:
> 
> 
> "When anycast SRv6 Locator TLVs for the same prefix are advertised by 
> different nodes, the SRv6 Locator TLVs MUST all advertise identical sets 
> of SRv6 SIDs."

##PP
here's the proposed text:

All the nodes advertising the same anycast locator MUST instantiate the 
exact same set of SIDs under such anycast locator.

> 
> 
> Section 3.3 of RFC 8402 has similar text: "Within an anycast group, all 
> routers in an SR domain MUST advertise the same prefix with the same SID 
> value."  That text only refers to a single SID value, so it seems 
> somewhat open to interpretation text in the context of an SRv6 locator 
> that carries multiple SRv6 SIDs. I think it would be better to avoid any 
> potential ambiguity by using the text proposed above in this document.
> 
> =========
> 
> In section 12.1.2. "Revised sub-TLV table" it might avoid an extra 
> interaction with IANA to add a line for the flex-algo prefix metric 
> (currently 6) indicating "n" for TLV#27.

##PP
flex-algo prefix metric is not defined in this draft, so I don't believe 
we can mention it here.

thanks,
Peter

> 
> ==========
> 
> Thanks,
> 
> Chris
> 
> 
>