Re: [Lsvr] Tsvart early review of draft-ietf-lsvr-l3dl-03

[Joerg Ott <[e-mail]>]

On 07.05.20 01:41, Rob Austein wrote:
> On Wed, 06 May 2020 18:40:52 -0400, Randy Bush wrote:
>>
>>> I also assume that the pseudo code on p.11 would benefit from a leader
>>> '0' in 0xffffffff -> 0x0ffffffff, otherwise expansion to 64 bits might
>>> fill the high order bits with '1's, which is clearly not intended.
>>
>> ok, but what kinky compiler are you using?  :)
>>
>>       result = (result >> 32) + (result & 0x0FFFFFFFF);
>>       result = (result >> 32) + (result & 0x0FFFFFFFF);
> 
> Last I checked, the pedantic C syntax would be 0xFFFFFFFFU.
> But pseudo-code means whatever we define it to mean :)
> 

Just leave it as is.

If my dim memory on this serves me somewhat well, the issue arose with
different compilers at some time in the past.  Just checked and it seems
fine for XCode now.  I came across this multiple times, which is
probably why it stuck.

Jörg