Re: [Lsvr] Tsvart early review of draft-ietf-lsvr-l3dl-03

Rob Austein <sra@hactrn.net> Wed, 06 May 2020 23:40 UTC

Return-Path: <sra@hactrn.net>
X-Original-To: lsvr@ietfa.amsl.com
Delivered-To: lsvr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B5373A0C56; Wed, 6 May 2020 16:40:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FBcjSZlO2ybV; Wed, 6 May 2020 16:40:53 -0700 (PDT)
Received: from khatovar.hactrn.net (khatovar.hactrn.net [198.180.150.30]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2EC9A3A0C54; Wed, 6 May 2020 16:40:52 -0700 (PDT)
Received: from minas-ithil.hactrn.net (c-73-47-196-134.hsd1.ma.comcast.net [73.47.196.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "nargothrond.hactrn.net", Issuer "Grunchweather Associates" (not verified)) by khatovar.hactrn.net (Postfix) with ESMTPS id A9A25139A0; Wed, 6 May 2020 23:40:49 +0000 (UTC)
Received: from minas-ithil.hactrn.net (localhost [IPv6:::1]) by minas-ithil.hactrn.net (Postfix) with ESMTP id 8BB3C2014E48DE; Wed, 6 May 2020 19:41:03 -0400 (EDT)
Date: Wed, 06 May 2020 19:41:03 -0400
From: Rob Austein <sra@hactrn.net>
To: Randy Bush <randy@psg.com>
Cc: =?ISO-8859-1?Q?J=F6rg?= Ott <ott@in.tum.de>, tsv-art@ietf.org, draft-ietf-lsvr-l3dl.all@ietf.org, lsvr@ietf.org
In-Reply-To: <m2sggclma3.wl-randy@psg.com>
References: <158870511665.7532.2079643708622987385@ietfa.amsl.com> <m2sggclma3.wl-randy@psg.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Message-Id: <20200506234103.8BB3C2014E48DE@minas-ithil.hactrn.net>
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsvr/hgzPtP9JFRDdbMQznrf0uV5FWd8>
X-Mailman-Approved-At: Thu, 07 May 2020 00:32:12 -0700
Subject: Re: [Lsvr] Tsvart early review of draft-ietf-lsvr-l3dl-03
X-BeenThere: lsvr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Vector Routing <lsvr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsvr>, <mailto:lsvr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsvr/>
List-Post: <mailto:lsvr@ietf.org>
List-Help: <mailto:lsvr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsvr>, <mailto:lsvr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 May 2020 23:40:55 -0000

On Wed, 06 May 2020 18:40:52 -0400, Randy Bush wrote:
> 
> > I also assume that the pseudo code on p.11 would benefit from a leader
> > '0' in 0xffffffff -> 0x0ffffffff, otherwise expansion to 64 bits might
> > fill the high order bits with '1's, which is clearly not intended.
> 
> ok, but what kinky compiler are you using?  :)
> 
>      result = (result >> 32) + (result & 0x0FFFFFFFF);
>      result = (result >> 32) + (result & 0x0FFFFFFFF);

Last I checked, the pedantic C syntax would be 0xFFFFFFFFU.
But pseudo-code means whatever we define it to mean :)