Re: [Lsvr] Tsvart early review of draft-ietf-lsvr-l3dl-03

"Van De Velde, Gunter (Nokia - BE/Antwerp)" <gunter.van_de_velde@nokia.com> Wed, 06 May 2020 09:13 UTC

Return-Path: <gunter.van_de_velde@nokia.com>
X-Original-To: lsvr@ietfa.amsl.com
Delivered-To: lsvr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3330D3A0538; Wed, 6 May 2020 02:13:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uNGxBVH7QCkC; Wed, 6 May 2020 02:13:20 -0700 (PDT)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2106.outbound.protection.outlook.com [40.107.22.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43D1D3A0486; Wed, 6 May 2020 02:13:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V3U55jBGzvz4o7C/dJT0oyYSCDXapq/sJ1AYEUQTkdseFOVmK0EI3hYrrsXJQeXd23F8bOUtfk7WlaU1f6T9ReYvoumvc/3+ErQQRqtNqMdWi7tFq2M2Zfr/F1OrRZP7L8OaD7EHMK2eZH2TS6itZhxGfNzJMiy3uy1cnazqnyxbPyp4XA3duoPwWS+8ratR8q8S5ALZGXZVOxeeJ/VCDoawQPkq+sWt2chfovOT1W1HSL2sk+BIjE279ZKRD+bDswXaBFZMjDxflLoTlS5PBjNHIonIs+zgvXYuCPCLDv5C+mo/l9NYMySKLO8Trerj6mN89U3D9f2D4orBu5VV2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7rZXtZ4/in9jOG6kaqdfei3W+ZpgSdMjhrAixt6iH8=; b=JNO7xCCcqlTe0qnYWHw1jFG04gZ7tOVn1n5hxNXFXlKO6fqdGlKEeZuF18V10OV0kwfAYui5MOpFzy5ZcMB7CY6EZypuW8ubEXOldDPmRCVoBU/EcYndPrgeN+QFYTbRMODD5K9XrrIVfoV6yweT70OsVk7+NUnB0YtUs8L+BuVn+kncbRneGtINWs/nvwXwvT+3gXUbu90nee7rWVdPUkgJz/vrY3MZtbLCt/kd5bzbLormAGZQOtVT7B3TEd1WPn0C13V/FIO9KVwWaLIR1KtwGZAFNlzT2qHzH37hLLz3+gWQtE71IHppzRGYr6KKy/NlrEmLpbP7ZSS5vqfa3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7rZXtZ4/in9jOG6kaqdfei3W+ZpgSdMjhrAixt6iH8=; b=dABSe1qWhVHBRYpcQDgPISOHtcUGG6FwtbklmhhghcPfVjR+loI2PLth8bFNUw3uI1QNEdLm3Pvf/vNMU4Vqm28UqpL/SEYq19nabDn2CY33mFsd/t0eFacNgymp9bFmnWlzaxOtX1Dzpm+ORJaM2amx+Ft8sNPhVHxq8Ys/7Xs=
Received: from AM0PR07MB6386.eurprd07.prod.outlook.com (2603:10a6:20b:144::23) by AM0PR07MB4801.eurprd07.prod.outlook.com (2603:10a6:208:e8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.23; Wed, 6 May 2020 09:13:16 +0000
Received: from AM0PR07MB6386.eurprd07.prod.outlook.com ([fe80::9ca9:ed1d:36b4:b0e9]) by AM0PR07MB6386.eurprd07.prod.outlook.com ([fe80::9ca9:ed1d:36b4:b0e9%5]) with mapi id 15.20.2979.027; Wed, 6 May 2020 09:13:16 +0000
From: "Van De Velde, Gunter (Nokia - BE/Antwerp)" <gunter.van_de_velde@nokia.com>
To: Randy Bush <randy@psg.com>
CC: "tsv-art@ietf.org" <tsv-art@ietf.org>, "draft-ietf-lsvr-l3dl.all@ietf.org" <draft-ietf-lsvr-l3dl.all@ietf.org>, "lsvr@ietf.org" <lsvr@ietf.org>, Joerg Ott <ott@in.tum.de>
Thread-Topic: Tsvart early review of draft-ietf-lsvr-l3dl-03
Thread-Index: AQHWIw8xqnCpL7nU/E2odVm75LUBb6iaF4qAgACtwjA=
Date: Wed, 6 May 2020 09:13:16 +0000
Message-ID: <AM0PR07MB63866E893A3E03BF806A1AF2E0A40@AM0PR07MB6386.eurprd07.prod.outlook.com>
References: <158870511665.7532.2079643708622987385@ietfa.amsl.com> <m2lfm6m26i.wl-randy@psg.com>
In-Reply-To: <m2lfm6m26i.wl-randy@psg.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: psg.com; dkim=none (message not signed) header.d=none;psg.com; dmarc=none action=none header.from=nokia.com;
x-originating-ip: [2a02:a03f:4efb:7600:b5ca:18af:f844:a2fe]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: be22cb88-2142-4467-65d7-08d7f19db63a
x-ms-traffictypediagnostic: AM0PR07MB4801:
x-microsoft-antispam-prvs: <AM0PR07MB4801EE53A7E3082AB5044C79E0A40@AM0PR07MB4801.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 03950F25EC
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: YdZMT+M9dNY3oqZKI/FcajyrvuiijdUTVrOC5f6v/fWkPIZo3O42uLdxDrbg39uUDOpJnVwJ2DRaP89OZAkwV1ZpKeAOabSEVv6rt7WuKCOFHiicywLzVn6YdD5ogeQdlEdQIjWBEqALvcgdUtubS83qoDiPb7eGZX5BGZl0uUZ9wMyYbI+22MStr7dGBG5bCOfUnRfJgsG3hobfYTbPjqRPA1/TQE228xuTcmfouepX8pVLsJHYMT6Wyk/3wAAy3bpQd7ur0A3S5WfYe7W3Ixljao/1WWHR5Y8ZhghhRSlTMYAb39e+//kKkEoJclXmvk5vGXTJo41UGmK2s+6pJOLKfdx9kaSy0EFRNnv5YRHNBru0aiSX9yzkPDqMO0w28QiPCgLGplkYa/3xFBE+vsIzZXz1xTGkTLGcEACn8uRz6qL+FwXCSK3iX4Jg7NVdePV47Yk4UIggk527OdbGDkYefsT/GYSK6ALHGzldqdwwaBrMfcxrWPrVO8HnPUHUb4O/f7tIGUH4UFEoVhn9EQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR07MB6386.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(33430700001)(8676002)(8936002)(4326008)(71200400001)(6916009)(66446008)(9686003)(64756008)(66476007)(66946007)(86362001)(52536014)(55016002)(478600001)(76116006)(66556008)(33656002)(2906002)(54906003)(186003)(53546011)(6506007)(316002)(33440700001)(7696005)(5660300002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: fOIqcxMycPhGEoYKpy9JzN4z11N2qmQTrF3uyMP5fhdFWGWuwjWlTn3WHkwmw23qFYCZlLtDLAwZ25BnDZEWj9DHCpGwAd/nn2wx4pF/h5tdfKfiur8XBbh7Qgl0lA8GjpByR15Q8KTozGtfP5JqS+BugF3oCG+bMoF6bCLO2u64J3KWGpzf1RX2ZKAtFWyTIRfKk4q7QRsHAMl/v9a2hDnmauJBuqOSSjqp+AHmqnKbWrg4LGcSyUbijhh0S7VIObzY6/58emx2zi9cAwWnbuX4ZVD5PPDnPIFGJClkGd8oyP7u1QOYLhWqaDiGNSBMVKvlpeBwRhT/d0+z/uKdfSIqWObRTUBGuN3cJIYo6De4WrCkHhmKRyuvYWLDBE2HGsM4Mcy5r6ACT98h5C8y6mmA3GsEpkZAuFcP7rScu2b1eoFP7ntAdsBk7S2movKiuWjWK5cf+dG57eLcGIDgGnM4lYiZuE+Hy4FjYw9gSOylxwRO5XN40msth0llwRccZYUgtkBfuqxItnTrzJmsQrzPzXXCgOVJ6S2gjs2s0+Jb+KNEUe4ewLoMxXujlyDzLe8iGbqXJBubcmlgmkSGG+GzPnyb6yq58XJ8ZeRXzAm3TY3apd9ZcWwE4YN7Iv0IL8IU0lAv7tR+nFCAHtHGHr0VO6GN/u2qaRU/YjV/tQYT7Xz3StyEX0FhXm/0HP/KOppojpcK6PXV0KB11iX3x8Mr4QJvN9mHe2XHec1PvCpwlAjRK6WqQoWvBLyc/ix3reYnnGKpPhzeR501nPKu9OK8hPK1OJx0aRgnSOlZab4LKHULQBQMk5YZjUcPopHfPIWOrkz4P5p9yUCAHWJatHiwyexBrweaKENy1V3huWAZhhUlGcAvyLFZcZM+sKJp
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be22cb88-2142-4467-65d7-08d7f19db63a
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 09:13:16.4280 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ufygBkWU7Fdv3imyXkxp8du1RN3ddBJChJgofJOjIdx2uTX8bC9GSK0GpaLTfo8VzLtOivWuoC0p+NU0X1NVzjejlEuTf3gY1eig96V7gRY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB4801
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsvr/BGgnK5imI5cDQ2rR638MkP4b4R0>
Subject: Re: [Lsvr] Tsvart early review of draft-ietf-lsvr-l3dl-03
X-BeenThere: lsvr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Vector Routing <lsvr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsvr>, <mailto:lsvr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsvr/>
List-Post: <mailto:lsvr@ietf.org>
List-Help: <mailto:lsvr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsvr>, <mailto:lsvr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 May 2020 09:13:22 -0000

Hi Randy,

Wake-up call received. 

Can you refresh the draft-ietf-lsvr-l3dl-03 document and I'll launch WGLC on that document.

Can you refresh " draft-ymbk-lsvr-l3dl-signing " and " draft-ymbk-lsvr-l3dl-ulpc" and we'll launch a WG adoption call.

Brgds,
G/

-----Original Message-----
From: Randy Bush <randy@psg.com> 
Sent: Wednesday, May 6, 2020 00:45
To: Joerg Ott via Datatracker <noreply@ietf.org>
Cc: tsv-art@ietf.org; draft-ietf-lsvr-l3dl.all@ietf.org; lsvr@ietf.org
Subject: Re: Tsvart early review of draft-ietf-lsvr-l3dl-03

wow!  thanks!  great review.

unfortunately the wg has gone dormant, so we have let the l3dl drafts expire.  should it ever wake up, i will happly merge in your excellent suggestions.

again, thank you!

randy

> Reviewer: Joerg Ott
> Review result: Ready with Issues
> 
> The draft describes a peer/neighbour discovery mechanisms for 
> large-scale L2/L3 topologies in data centres. The aim is provide a 
> protocol by means of which the involved nodes can learn about other 
> nodes connected to their (broadcast or
> point-to-point) L2 links and about their respectively support 
> encapsulation schemes, identifiers, L2/L3 addresses, etc. This 
> information is then provided to a higher layer for further processing.
> 
> The document is well written and fairly easy to follow, but could 
> benefit from a bit of extra context and target application domain in 
> the introduction. E.g., explaining explicitly who would talk L3DL to whom.
> 
> >From a transport perspective, I see three potential issues that 
> >deserve
> clarification or reconsideration:
> 
> 1. Section 10 spells out a default HELLO interval of 60 seconds. With 
> a large broadcast domain, this may create quite a bit of traffic. 
> While this may not be an issue in well-provisioned data center 
> networks,  a remark about sensible value ranges and the implications 
> may be worthwhile. Just to provide some guidelines to implementers 
> (who want to offer choices) and operators (who pick them).
> 
> 2. Section 10 also suggest that in response to HELLO messages nodes 
> will issue OPEN PDUs to newly discovered peers. This appears to bear 
> the clear risk of an OPEN implosion when many system come up at the 
> same time. Shouldn't guidance be given to avoid repeated traffic 
> surges and possible losses and thus unnecessary delays? (I noted that 
> other places foresee exponential backoff when retransmitting OPEN and other ACKed PDUs).
> 
> 3. When the protocol applies fragmentation, should there be a note on 
> preventing bursts?
> 
> Other notes:
> Section 7 on the checksum needs more detail. It also talks about a "suggested"
> algorithm but this should be clearly mandated or way to choose one by 
> means of configuration for a complete data centre would need to be 
> made explicit. I also assume that the pseudo code on p.11 would 
> benefit from a leader '0' in 0xffffffff -> 0x0ffffffff, otherwise 
> expansion to 64 bits might fill the high order bits with '1's, which is clearly not intended.
> 
> Section 11, p.17, second to last para ("If a properly 
> authenticated...").  From the text, it is unclear what is meant by an 
> "OPEN with the Serial Number of the last data received".
> 
> I am curious about the error code, providing 16 bits for additional 
> explanation. Why not a text field? Also wondering if repeated retries 
> (due to failure, not lost packets) could yield fast repeated transmissions.
> 
> Section 15, should the KEEPALIVE interval have suggested (lower) bounds?
> At the top of p.26, it says "One per second is the default", the 
> previous page at the bottom refers to the inter-KEEPALIVE interval of 
> ten seconds. Not sure if the two are the same, I suppose so. If they are, the numbers should match.
> If they are not, we'll need some extra text to explain the difference.
> 
> Nits:
> There are two spellings of "Encapsulation", capitalised and lower 
> case. Use one consistently. p10, first para: comprise -> comprising
> 
> 
>