Re: [manet] DLEP pause extension

Lou Berger <lberger@labn.net> Tue, 20 March 2018 12:52 UTC

Return-Path: <lberger@labn.net>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8CEE712EA54 for <manet@ietfa.amsl.com>; Tue, 20 Mar 2018 05:52:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (768-bit key) header.d=labn.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Eq9Q3IlK6goK for <manet@ietfa.amsl.com>; Tue, 20 Mar 2018 05:52:27 -0700 (PDT)
Received: from gproxy8-pub.mail.unifiedlayer.com (gproxy8-pub.mail.unifiedlayer.com [67.222.33.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9934412D958 for <manet@ietf.org>; Tue, 20 Mar 2018 05:52:27 -0700 (PDT)
Received: from cmgw4 (unknown [10.0.90.85]) by gproxy8.mail.unifiedlayer.com (Postfix) with ESMTP id 2B2531AB059 for <manet@ietf.org>; Tue, 20 Mar 2018 06:52:27 -0600 (MDT)
Received: from box313.bluehost.com ([69.89.31.113]) by cmgw4 with id QCsQ1x0092SSUrH01CsTKx; Tue, 20 Mar 2018 06:52:27 -0600
X-Authority-Analysis: v=2.2 cv=G85sK5s5 c=1 sm=1 tr=0 a=h1BC+oY+fLhyFmnTBx92Jg==:117 a=h1BC+oY+fLhyFmnTBx92Jg==:17 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=v2DPQv5-lfwA:10 a=NEAV23lmAAAA:8 a=lrN0S3_zpDNWIjHyot8A:9 a=BUvJFHYp0l2H12jz:21 a=dvGlOwf1LmUYZ8Y1:21 a=QEXdDO2ut3YA:10
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version :Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xhtsyOK4gy47+56O70m1PEr9z4Yty/UKADIGDiyNW/U=; b=C51+erR1uTLIzYbFRzlFezmUL4 azWUdw13nuNFdGrUh+6QgtmXGCKoGzvIJjFhjMDXFYVY69WFAq2jy/i+/TLj8vi6b6fFaEbMfiE7O t51Gsbh05+2dRRLgXSJQdymvu;
Received: from pool-100-15-86-101.washdc.fios.verizon.net ([100.15.86.101]:36044 helo=[IPv6:::1]) by box313.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from <lberger@labn.net>) id 1eyGkZ-000dL5-S8; Tue, 20 Mar 2018 06:52:24 -0600
To: Rick Taylor <rick@tropicalstormsoftware.com>, "manet@ietf.org" <manet@ietf.org>
References: <1521546068.17989.44.camel@tropicalstormsoftware.com>
From: Lou Berger <lberger@labn.net>
Message-ID: <0a13a821-d40c-e450-34bf-ab7dc617d644@labn.net>
Date: Tue, 20 Mar 2018 12:52:21 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1521546068.17989.44.camel@tropicalstormsoftware.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - box313.bluehost.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - labn.net
X-BWhitelist: no
X-Source-IP: 100.15.86.101
X-Exim-ID: 1eyGkZ-000dL5-S8
X-Source:
X-Source-Args:
X-Source-Dir:
X-Source-Sender: pool-100-15-86-101.washdc.fios.verizon.net ([IPv6:::1]) [100.15.86.101]:36044
X-Source-Auth: lberger@labn.net
X-Email-Count: 9
X-Source-Cap: bGFibm1vYmk7bGFibm1vYmk7Ym94MzEzLmJsdWVob3N0LmNvbQ==
X-Local-Domain: yes
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/0BnTS_TqriyZ-fyEt-0CFUQ7J38>
Subject: Re: [manet] DLEP pause extension
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 12:52:32 -0000

Rick,

     This all seems reasonable.  Any interest/willingness to do a pull 
request?  The repo can be found at 
https://github.com/louberger/dlep-extensions

Thanks!
Lou

On 3/20/2018 11:41 AM, Rick Taylor wrote:
> Hi Lou,
>
> I'm also having a re-read of the latest pause extension draft.
>
> In general I like it, and think it's almost ready, but I have a couple
> of comments:
>
> * Section 3.1 Queue Parameters.  There seems to be a lot of reserved
> space to align fields within the data item.  Is this strictly
> necessary?  This sounds like an optimization to try to force sub-tlvs
> to 8 byte alignment.  Given the DI is coming over TCP, I think this
> might be a false optimization.  I know it prevents your diagram from
> getting messy, but an arbitrary 28-bits of padding is just a bit weird.
>   Given the large chunk of padding, why not make the scale 8 bits to
> make implementers life a little easier?
>
> * Section 3.1.  Rather than have the order of items be important
> (unlike everywhere else in DLEP), I would prefer to have an explicit
> QID in there somewhere.  The same applies to section 3.1.1 Queue
> Parameter Sub Data Item.  You already introduce the Queue Index, why
> not make it explicit for sanity?
>
> Can I suggest the following DI layout instead, as I think it addresses
> both my comments?
>
>
> The format of the Queue Parameters Data Item could be:
>
>      0                   1                   2                   3
>      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     | Data Item Type                | Length                        |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |   Num Queues  | Scale (8!)    |          Reserved             |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |               Queue Parameter Sub Data Item 1                 |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     :                                ...                            :
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |               Queue Parameter Sub Data Item n                 |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> The format of the Queue Parameter Sub Data Item could be:
>
>      0                   1                   2                   3
>      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |  Queue Id     |             Queue Size Qn                     |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     | Num DSCPs Qn  |  DS Field Qn  |  DS Field Qn  |  ...          :
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     :                          ...                  |  DS Field Qn  |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> Cheers,
>
> Rick