[manet] Review of draft-ietf-manet-dlep-radio-band-02
Donald Eastlake <d3e3e3@gmail.com> Sun, 12 October 2025 23:13 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: manet@mail2.ietf.org
Delivered-To: manet@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 5FCDE721273E for <manet@mail2.ietf.org>; Sun, 12 Oct 2025 16:13:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.849
X-Spam-Level:
X-Spam-Status: No, score=-1.849 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zCKEElEwvCwp for <manet@mail2.ietf.org>; Sun, 12 Oct 2025 16:13:40 -0700 (PDT)
Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id C83347212739 for <manet@ietf.org>; Sun, 12 Oct 2025 16:13:40 -0700 (PDT)
Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-85d02580a07so436340585a.0 for <manet@ietf.org>; Sun, 12 Oct 2025 16:13:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760310814; x=1760915614; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=STlhgsFQY/7mwRXGm5w24697QYur0HuCqeMeWUjz9mg=; b=befLFQthQxyQpM61VkYZI+LLq216WNi3CrGl4z+Ys5UIO6EFt2PuX8+Cc+F8bWXuaC Sssx76vK0eNDLdcXhB+f41r60qeX4+0ycs5Z2XUbVa5g04JO+aZHq87D/iNhkrwGZsSb ooFBXkkn64PV5BqAx+uasv81oubBQ2hd7E7J14tQ05Vu02vZhea4pnhcSfWQjB7VD7tS j6Wry7aZR2DllaJeJuwVOSQ2Uf7yxV/fQQNafguZfi4zCdRqYHiBMy9xhi63sNwlqa2m fuZF/nPEKnmsFRcs/svSJWL0Qw0Ym6is3hOSUeNNfXmDumQHfvdN1OmwIrlgbmPqO70z BGgg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760310814; x=1760915614; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=STlhgsFQY/7mwRXGm5w24697QYur0HuCqeMeWUjz9mg=; b=qNC0cbeE+BOmbPxUqNgJn6FBkYHtY2JJiICnpA2go2u7O08Vxk1jIbrBEI3vbI9FhT TExF8VASu31zlJIyp9Y/qUITtkFSyo+WEVuwk40k6SfCNhoPohZYT08XuWCXhXUaLdtG 0mdYFUCN9fMnLjkvwoabyiFQryJJluz/kGBMlnoxEJ7jmZsiR+X9Ou/6IvVDWBkJZj6O hDGASK4Ij79dTab2ecvL0vBy94fr1ZjhPAC790KT7g36EM+yagFITxAW8sunE0Iee6v6 ctV52aKEx3sabYjG/tnOXmq29U4TH5QsapOz/OPdnZGXTgLYZG7NFecxwo8PqevUmzou dFEQ==
X-Gm-Message-State: AOJu0YzueHvbZP+LNx7g1wrEt9sYTiIftYQbjOJBgFzQpZRKmJ4gppw/ +qWYhj7XB3y39UkRz9m/85kfVhNQEruE5lHgUdbAyJD9By/tx12l2xCa17rBwbHFdQJsw52Y4d0 alwjhZeR6H6lsXiH4CST55qpfI6jMuPElHKkP
X-Gm-Gg: ASbGncuyBNbyO7efdlhpgGuXitIqkG/0+rot2jAuBekCcWLXPATNTjxcUIpW6+rqWMw f0YxbeVfFVMtYc0Ww0TAFXpUP8Clrkvx7hpoyV1ym6p0nhrOnQfh6r2SGvyH7OJ4YeBgGm0ib2a GhuZS3S7Yb0bgi/cEm30Twxc7P+riZ0b1MtB2uJvwH7zzaPgxlFXqC7eQRdkGV7uvQRYgDSmvIB fsRPpFzeOfrKQbTq6IA9KPBDhCZGuU7d2o=
X-Google-Smtp-Source: AGHT+IFhb5i+VDzOxGifdM4DmKuC9o/V0M5caVMErbcD5RWetkBfzHrju5wXx+K8WNFd1u0zYdfDMRo34Mv1yVsmvPU=
X-Received: by 2002:ac8:5801:0:b0:4b7:aa31:3c4c with SMTP id d75a77b69052e-4e6eb068d54mr261354161cf.38.1760310814227; Sun, 12 Oct 2025 16:13:34 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sun, 12 Oct 2025 19:13:23 -0400
X-Gm-Features: AS18NWAFxNaOW3DVNj021a27Dq_Lvod3yzgpbHWI2QnNv-QGmlBf0xeAsJBqDg8
Message-ID: <CAF4+nEEPT1VFrhhGjCgYT_uiQjndzFz62xahSkXdZKO0uD6Ffg@mail.gmail.com>
To: manet <manet@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID-Hash: NSI7QS5R2ACJAXVVFAIJ3JVHP2SSJVHI
X-Message-ID-Hash: NSI7QS5R2ACJAXVVFAIJ3JVHP2SSJVHI
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-manet.ietf.org-0; header-match-manet.ietf.org-1; header-match-manet.ietf.org-2; header-match-manet.ietf.org-3; header-match-manet.ietf.org-4; header-match-manet.ietf.org-5; header-match-manet.ietf.org-6; header-match-manet.ietf.org-7; header-match-manet.ietf.org-8; header-match-manet.ietf.org-9; header-match-manet.ietf.org-10; header-match-manet.ietf.org-11; header-match-manet.ietf.org-12; header-match-manet.ietf.org-13; header-match-manet.ietf.org-14; header-match-manet.ietf.org-15; header-match-manet.ietf.org-16; header-match-manet.ietf.org-17; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [manet] Review of draft-ietf-manet-dlep-radio-band-02
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/JnQFQ3cxMA531gmqWYleOmu64wo>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Owner: <mailto:manet-owner@ietf.org>
List-Post: <mailto:manet@ietf.org>
List-Subscribe: <mailto:manet-join@ietf.org>
List-Unsubscribe: <mailto:manet-leave@ietf.org>
Comments as a WG participant on draft-ietf-manet-dlep-radio-band-02
This is a short draft specifying an extension to the DLEP protocol to
provide information on frequency bands used by a radio.
I do not see any major problems with this draft.
Minor
-----
Abstract: The extension does not actually provide "the frequency bands"
but rather provides "information about the frequency bands".
Section 1: Normally all the information that appears in the Abstract
should also appear in the Introduction. You could just change the last
sentence of Section 1 to "This document defines one such extension to
provide information about the frequency bands used by the radio." or
the like.
Section 1.1 needs to be replaced by the modern required boilerplate as
specified in RFC 8174. At this point the new boilerplate has been
required for more than eight years. It should be incorporated into
most draft templates.
Section 3:
The Figure should have a caption. Could just be "Radio Band Data
Item Format" or something like that.
Presenting a 64-bit field as two sequential 32-bit fields with
identical names is confusing and easy to fix. This was noted in the
early RTGDIR review of this draft
(https://datatracker.ietf.org/doc/review-ietf-manet-dlep-radio-band-01-rtgdir-early-white-2025-05-03/)
If I recall correctly, I also noted this in a review of another DLEP
draft and the reason given was that this was how it was done in earlier
RFCs which I accepted at the time. I now think that was a mistake.
Fixing this and other new documents will, in my opinion, result in
less confusion than sticking with a previously used confusing format.
These fields should be either labeled "upper half" and "lower half" or
the like or merged as was suggested in the RTGDIR review.
The abbreviation "Hz" needs to at least be expanded on first
use. Since it only appears twice, I don't see much need to abbreviate
it at all.
For Reserved, the document needs to also say "ignored on receipt"
unless that is not true in which case it needs to specify what is done
if this field is non-zero on receipt.
Section 6: RFC 8174 will need to be added as a normative reference.
Nits
----
Section 1: I believe "are comprised of" is grammatically erroneous. It
should be "consist of" or "comprise".
Section 3, third paragraph "use" -> "uses"
Sections 5.1 and 5.2: Although I guess it is pretty obvious, it is
normal to provide all the columns present in the IANA registry. So, I
would add a third column to the tables in these sections headed
"Description" with the entry being "[this document]".
Thanks,
Donald
===============================
Donald E. Eastlake 3rd +1-508-333-2270 (cell)
2386 Panoramic Circle, Apopka, FL 32703 USA
d3e3e3@gmail.com
- [manet] Review of draft-ietf-manet-dlep-radio-ban… Donald Eastlake
- [manet] Re: Review of draft-ietf-manet-dlep-radio… Henning Rogge
- [manet] Re: Review of draft-ietf-manet-dlep-radio… Donald Eastlake