[manet] Re: Opsdir last call review of draft-ietf-manet-dlep-da-credit-extension-18

Donald Eastlake <d3e3e3@gmail.com> Tue, 05 November 2024 15:11 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93FE6C1D4CF8; Tue, 5 Nov 2024 07:11:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.858
X-Spam-Level:
X-Spam-Status: No, score=-1.858 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KG5LAAgT6kkf; Tue, 5 Nov 2024 07:11:51 -0800 (PST)
Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 06863C1D4A79; Tue, 5 Nov 2024 07:11:40 -0800 (PST)
Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-46098928354so36957671cf.1; Tue, 05 Nov 2024 07:11:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730819500; x=1731424300; darn=ietf.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s9eFF4uTdEv62JPnPap72fKMonaqS4l4w7m+r50Q9fc=; b=MNyNgfQsXqapTApdMxEUd7RykAnXPclflax7jkNJBZDyXt5koaj/i+gHgNlv1aJjCC P8M+PeH6gAcnBWMgenmz/RHqh1AoSfZniWQV9ZU05b1Db8VTHE0640LSI2yFzMy86nix pVpapkRrcq/xcRpfLrtbw3zbnWtMuGS4DNCwg0xiBGB9+tqVmsZ75/DMkcLvLYAY/4/u YjhDtGBKBOHq7J5yrlbLE9RY62QuuU9qNEEsC5NbrIBYGW0jSmyR7jXPF7Sf9g6ANrxM 20YGvWZ2Gxp69nzR/Wb3DN/Nwhif7FuboVarrWbIY3Abto5J6EONcvSAb+V1g37wpL3L renQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730819500; x=1731424300; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s9eFF4uTdEv62JPnPap72fKMonaqS4l4w7m+r50Q9fc=; b=ACLF1ZMv+WejAYlK4NV66HxYfcn+GK5B+jCnF80rTjFx4J4JzevsYFBQ1jH3MMls4K c6h5crsejnB9gRMWlu5eOukHNiQO0a00cvaBh0s+Vq10rhN1u8hd5evWUDuccJNioRjs PGRvNAHNOqtm2ezBejvMWpsRx2FPBvBiPAaCiFYZTE+2eThnGDmnGUYwEV1JEcExLaAY SSvG20cMZV5EcAYyTtSjzdJ/m9L11FSO8yCnxcHMRKZuhZHjcZObKmua/Ay0K4faXNwJ mhlIJpnwJxdN4mYffw12d9/yW3AfnJm/f45NRjQllv8gYJDRzSFXCz5DP9058O3q1DRq uF9w==
X-Forwarded-Encrypted: i=1; AJvYcCWSCJtyG/K6rSy3LJUqAzVAvyj46bX+a8tObWZjaAHZbg4AM1Uqwbo1cCnYtIlbmM97VT8c1sIyNYwwhnflCQrQ/oqzGzxERFG40/6+FodUe0jqjD/yiNPgm+AFJMM=@ietf.org, AJvYcCXfFs0WnXIMzHpGFvRCt80RWZRO0oKlcm3vk0kiUgujgy7RLPQhmqCxOt4UIVif8w/uIxExBihAOVof@ietf.org, AJvYcCXpIPM0vrF+/d56g77ogNvdrjaE4DIlg0YsYK0je5g0GeIDAClsPfENKx+2T9G9MM7TqM5LuBU=@ietf.org
X-Gm-Message-State: AOJu0Yz1vwLZ3TELaUsy45R6y4tkHIP0pQjaGBaQ4Im1MMzxjoW6GRrL SEmvsbekx1qEkYsP+S222Le65ttvlsftZuV8WFUq3XWMWJ0Abny4cPvCK8IN8G3ATu0gMimpX0T iWAUg5aqShQNu1zZ3u1WtjLhM7qM=
X-Google-Smtp-Source: AGHT+IELQUkMGOesRABIO6wawp6MQEOwETZbwiHANm2zyMqHF0EdkVDE0OFRvVJeL2XQiRCqULrtQlh5LFpHJf19SM8=
X-Received: by 2002:a05:622a:14c6:b0:460:9b2b:e8ac with SMTP id d75a77b69052e-462b8754730mr252881591cf.48.1730819499809; Tue, 05 Nov 2024 07:11:39 -0800 (PST)
MIME-Version: 1.0
References: <172259513189.85249.3446624645016013991@dt-datatracker-6dd76c4557-2mkrj>
In-Reply-To: <172259513189.85249.3446624645016013991@dt-datatracker-6dd76c4557-2mkrj>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 05 Nov 2024 10:11:28 -0500
Message-ID: <CAF4+nEGodwivzp2aL1PcBO-SvNrwUKpzujJuNZS5Q-6dFwnzCQ@mail.gmail.com>
To: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: G4HQ2D3PRPDFIXYWEONVHF2E6CA2MUXD
X-Message-ID-Hash: G4HQ2D3PRPDFIXYWEONVHF2E6CA2MUXD
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-manet.ietf.org-0; header-match-manet.ietf.org-1; header-match-manet.ietf.org-2; header-match-manet.ietf.org-3; header-match-manet.ietf.org-4; header-match-manet.ietf.org-5; header-match-manet.ietf.org-6; header-match-manet.ietf.org-7; header-match-manet.ietf.org-8; header-match-manet.ietf.org-9; header-match-manet.ietf.org-10; header-match-manet.ietf.org-11; header-match-manet.ietf.org-12; header-match-manet.ietf.org-13; header-match-manet.ietf.org-14; header-match-manet.ietf.org-15; header-match-manet.ietf.org-16; header-match-manet.ietf.org-17; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: ops-dir@ietf.org, draft-ietf-manet-dlep-da-credit-extension.all@ietf.org, last-call@ietf.org, manet@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [manet] Re: Opsdir last call review of draft-ietf-manet-dlep-da-credit-extension-18
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/Rq6IgIL6cg-SB30XyaapPZdngk0>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Owner: <mailto:manet-owner@ietf.org>
List-Post: <mailto:manet@ietf.org>
List-Subscribe: <mailto:manet-join@ietf.org>
List-Unsubscribe: <mailto:manet-leave@ietf.org>

Hi,

On Fri, Aug 2, 2024 at 6:38 AM Giuseppe Fioccola via Datatracker
<noreply@ietf.org> wrote:
>
> Reviewer: Giuseppe Fioccola
> Review result: Ready
>
> This document is well written and clear for its scope.

Thanks.

> This I-D, together with draft-ietf-manet-dlep-credit-flow-control and
> draft-ietf-manet-dlep-traffic-classification, specify a DiffServ-aware credit
> window based flow control scheme as a new extension to DLEP (RFC 8175).

We are working on resolving comments and revising all of these drafts.

> From an OPSDIR point of view, the document includes a dedicated section on
> Management Considerations. Since I also looked at the companions
> draft-ietf-manet-dlep-credit-flow-control and
> draft-ietf-manet-dlep-traffic-classification, I think that some details about
> the implementation can be provided. It would be good to mention or give
> examples on how the different parameters can be configured and how the
> information can possibly be exported. This suggestion mainly applies to the
> companion documents, which are normative references for this I-D.

OK.

> As an editorial comment for this I-D, you can consider to include a figure with
> the Extension Data Item or you can simply add a reference to section 13.6 of
> RFC 8175 somewhere.

We will plan to do that.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com