[manet] AD Review of draft-ietf-manet-dlep-latency-extension-04

Alvaro Retana <aretana.ietf@gmail.com> Fri, 21 June 2019 20:07 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 111C2120167; Fri, 21 Jun 2019 13:07:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bt3KjGzCeV78; Fri, 21 Jun 2019 13:07:47 -0700 (PDT)
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3AA55120144; Fri, 21 Jun 2019 13:07:44 -0700 (PDT)
Received: by mail-ed1-x52a.google.com with SMTP id p15so11682324eds.8; Fri, 21 Jun 2019 13:07:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:date:message-id:subject:to:cc; bh=7xKXHmxbSIWjflKvBv0vQXiFWk6EbCIRqAN4Q0K0HAM=; b=gBUpnPpDPIfTZqiSs4Ip4sTSVpI1F/SodrswYr5mvrV2EkbXVEISw0iz0CUozzxXL/ Ye6rswsMPf0XY4UNI+whuBO77g89SgK1p04Jt1K1+UeFaN21GDWJAiL/Y0mmQmZJJSpJ UKNyLC2pdkpo4cKvYaR0XRto0yqkMARj3wQT7Yp3AYHAGS/aXb1foyo0iPaspW2VeIaV 4pclShbS2f3QuYp9Ot2gbwTN62mMNYFfon1Pwe9nAJ+XyZBqqyUAV8pBEkxHBLIgoQLd ZBhXkP41yqW2KgbB7MZDV7tiTMcGthGyKuYxvWtrLr3U6KuuT7VzIVcFsu2umx7tYOAc k7FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to:cc; bh=7xKXHmxbSIWjflKvBv0vQXiFWk6EbCIRqAN4Q0K0HAM=; b=Kwlzj4++SJtb8zA2eiL4LMNymCkHxx0V3lkzI4OizEUs8GhUF8TkJEJbKcbdeXlTto OqXMzno3N3Tzx/Von1QujfH8rpm5Jmdiq19AOGDXSVPaEj7Gw6l/cID8YNozSb5cNHu6 Q+WkDHZYtE9snWJslvJSUsovWLW95SCpTGJbQyjbvMMfgBZAIiM/ySZs6OZ9Fr0PqdFq pBo7M3eUVtBWM1g412Qdz5O3ASm2JYwPxqwtybsuIhHMRReeWI6z9Rvorp2eA+UDTevB 93WNHAXTBjwG1gsr3GMsPPVN11hjSPe2yxp7jgNFjqUkAgQlTSjmwpXDXFsmA1Elwbew M25Q==
X-Gm-Message-State: APjAAAVgWfaWI32U51GW0+9vqaCnOt/z+jQb0zzaUFZT+tWvcxZGD6Nl kVZns3Vsm6kMUwMij6EtY0+FgdDBHn62gOo4+rkJuA==
X-Google-Smtp-Source: APXvYqwYqHhIaZtZR8pWMuhlE7ZgIZ6wzmLrjeCk1tsA0GgyIS8xwBVFQOGb9WCFAZ4tA5yoIbHt13nw3EY1fkBL7Ig=
X-Received: by 2002:aa7:ca45:: with SMTP id j5mr50954927edt.217.1561147662611; Fri, 21 Jun 2019 13:07:42 -0700 (PDT)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 21 Jun 2019 16:07:41 -0400
From: Alvaro Retana <aretana.ietf@gmail.com>
MIME-Version: 1.0
Date: Fri, 21 Jun 2019 16:07:41 -0400
Message-ID: <CAMMESszws1-EVqvq68FuqS2ovaq=TkrHZh5X4d8fiog+Dxj3Fw@mail.gmail.com>
To: draft-ietf-manet-dlep-latency-extension@ietf.org
Cc: Justin Dean <bebemaster@gmail.com>, manet-chairs@ietf.org, manet@ietf.org
Content-Type: multipart/alternative; boundary="000000000000df3822058bdb032f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/T6OW3BkQMfiBA7ssWWCZ7Tt5Qdw>
Subject: [manet] AD Review of draft-ietf-manet-dlep-latency-extension-04
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 20:07:49 -0000

Dear authors:

I just finished reading this document.  Sorry for the processing delay.

I have only one issue.  I'm starting the IETF Last Call because I believe
we can take care of it with other LC comments.

>From §3: "The Latency Range Data Item MAY be carried in any message where
the Latency Data Item [RFC8175] is allowed and is carried as an additional
data item."

There is an exception to the "MAY be carried" part above; rfc8175 §12.6
(Session Initialization Response Message) says:

   All supported metric Data Items MUST be included in the Session
   Initialization Response Message, with default values to be used on a
   session-wide basis.  This can be viewed as the modem "declaring" all
   supported metrics at DLEP session initialization.  Receipt of any
   further DLEP Message containing a metric Data Item not included in
   the Session Initialization Response Message MUST be treated as an
   error, resulting in the termination of the DLEP session between
   router and modem.

   If any optional extensions are supported by the modem, they MUST be
   enumerated in the Extensions Supported Data Item.  If an Extensions
   Supported Data Item does not exist in a Session Initialization
   Response Message, the router MUST conclude that there is no support
   for extensions in the modem.


IOW, the Latency Range MUST be carried in the Session Initialization
Response Message.  Please add text to that effect.

Thanks!

Alvaro.