Re: [manet] RtgDir review of draft-ietf-manet-olsrv2-multipath-12.txt
Loa Andersson <loa@pi.nu> Thu, 11 May 2017 20:51 UTC
Return-Path: <loa@pi.nu>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 389C113149C; Thu, 11 May 2017 13:51:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cfQLh43AkuzP; Thu, 11 May 2017 13:51:44 -0700 (PDT)
Received: from pipi.pi.nu (pipi.pi.nu [83.168.239.141]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1F72F12EBBC; Thu, 11 May 2017 13:46:10 -0700 (PDT)
Received: from [192.168.0.103] (81-236-221-144-no93.tbcn.telia.com [81.236.221.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: loa@pi.nu) by pipi.pi.nu (Postfix) with ESMTPSA id BDC8418014F3; Thu, 11 May 2017 22:46:08 +0200 (CEST)
To: Jiazi Yi <ietf@jiaziyi.com>
References: <1ea04d3a-2446-dcaa-e5b6-21797a3caa57@pi.nu> <BAD130D2-8FE3-4365-BBDB-3A44F197E15E@jiaziyi.com>
Cc: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, manet@ietf.org, draft-ietf-manet-olsrv2-multipath@ietf.org
From: Loa Andersson <loa@pi.nu>
Message-ID: <b99dda5a-89c1-489a-bd03-937709b4a2fb@pi.nu>
Date: Thu, 11 May 2017 22:46:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <BAD130D2-8FE3-4365-BBDB-3A44F197E15E@jiaziyi.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/WUuNZCnip90Ru6SZkWRPhOq8JxI>
Subject: Re: [manet] RtgDir review of draft-ietf-manet-olsrv2-multipath-12.txt
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 May 2017 20:51:47 -0000
Jiazi Inline please On 2017-05-11 16:10, Jiazi Yi wrote: > Hi Loa, > > Thanks a lot for the review. > > I don’t know why the nits tool says > > -- Looks like a reference, but probably isn't: '1' on line 469 > > -- Looks like a reference, but probably isn't: '2' on line 469 line 469 is (i've marked the '1' and '2' 469 (PT_metric, PT_address[1], PT_address[2], ..., PT_address[n]) ~~~ ~~~ My question is really not to the authors, I think your text is fine. RFC Editor might escape the '[' and ']', but I don't really understand why the nits tool does not have a warning for the '[n]' on the same line. I will bring this up witht he tools people. /Loa > > > because there is no ‘1’/‘2’ on line 469 of the draft. May be the RFC > editor could tell us what’s the problem. > > And we will fix the rest of the issues that you raised in the next > revision. > > best > > Jiazi > >> On 11 May 2017, at 10:14, Loa Andersson <loa@pi.nu <mailto:loa@pi.nu>> >> wrote: >> >> Hello, >> >> I have been selected as the Routing Directorate reviewer for this >> draft. The Routing Directorate seeks to review all routing or >> routing-related drafts as they pass through IETF last call and IESG >> review, and sometimes on special request. The purpose of the review is >> to provide assistance to the Routing ADs. For more information about >> the Routing Directorate, please see >> http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir >> >> Although these comments are primarily for the use of the Routing ADs, >> it would be helpful if you could consider them along with any other >> IETF Last Call comments that you receive, and strive to resolve them >> through discussion or by updating the draft. >> >> Document: draft-ietf-manet-olsrv2-multipath-12.txt >> Reviewer: Loa Andersson >> Review Date: 2017-05-11 >> IETF LC End Date: 2015-05-11 (?) >> Intended Status: Experimental >> >> Summary: >> >> This document is basically ready for publication, but has nits that >> should be considered prior to publication. >> >> Comments: >> >> The draft is well written and readable also for someone that does >> not read manet-draft that often. >> >> Major Issues: >> "No major issues found. >> >> Minor Issues: >> >> "No minor issues found." >> >> Nits: >> >> I've looked at the the GenArt review by Peter Yee and the Intdir >> review by Zhen Cao and largely agree with their comments. >> >> In addition: The nits tool picks on something that looks like >> references on line 469 ( [1] and [2] ) but is not. Don't think you'll >> need to fix that, the RFC Editor will fix if necessary. >> >> I'd like to have the Abstract fleshed out a bit, some more context >> given. If you are new to the area and the draft it is very hard to >> find the expected useful info in the abstract. >> >> You use "TC message" already in section 4, but TC (Traffic Control) >> is not expanded until section 6, should be done the first time it is >> used. >> >> The abbreviation "SR" is used (often as part of parameter names), but >> never really expanded, though one can find the expansion kind of >> explained at some places. Could be made clearer. >> >> /Loa >> >> >> -- >> >> >> Loa Andersson email: loa@mail01.huawei.com >> <mailto:loa@mail01.huawei.com> >> Senior MPLS Expert loa@pi.nu <mailto:loa@pi.nu> >> Huawei Technologies (consultant) phone: +46 739 81 21 64 >> >> _______________________________________________ >> manet mailing list >> manet@ietf.org <mailto:manet@ietf.org> >> https://www.ietf.org/mailman/listinfo/manet > -- Loa Andersson email: loa@mail01.huawei.com Senior MPLS Expert loa@pi.nu Huawei Technologies (consultant) phone: +46 739 81 21 64
- [manet] RtgDir review of draft-ietf-manet-olsrv2-… Loa Andersson
- Re: [manet] RtgDir review of draft-ietf-manet-ols… Jiazi Yi
- Re: [manet] RtgDir review of draft-ietf-manet-ols… Loa Andersson