[manet] Review of draft-ietf-manet-dlep-radio-band-01

Donald Eastlake <d3e3e3@gmail.com> Thu, 19 December 2024 03:19 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C57AC14F5EB for <manet@ietfa.amsl.com>; Wed, 18 Dec 2024 19:19:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.857
X-Spam-Level:
X-Spam-Status: No, score=-1.857 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pucuA8oVNEWu for <manet@ietfa.amsl.com>; Wed, 18 Dec 2024 19:19:27 -0800 (PST)
Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 334EBC14F5EA for <manet@ietf.org>; Wed, 18 Dec 2024 19:19:22 -0800 (PST)
Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-6d8f99cb0d9so3257716d6.0 for <manet@ietf.org>; Wed, 18 Dec 2024 19:19:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734578361; x=1735183161; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=EpgoYu5laNlw62BOxIYiXU6RPiLcOq/5n/sK95rvK5U=; b=URUSxUBMXOU/mTN+riFS/79A/oJ9T0M51rjMiHohm/YfbfsSlBaufypgJo2KnWSTtA jT/wi025DjYgLUCmxMO98hr1gL0pAMxJPqovAp+mgmbL0HoVR1Tch8VSEIRA3wxV2IpO 2fVTjqt5m9H2b96SL4Yt6wnxioT4YI5cqg5nZUAD1oPJYN4pkTA/8p/vAteXMPlCA6i9 f4cKbf188vfPbPePE4SghP0BAIGza81n9L8VWvCyU3U30707yiMHU9o+zssxtGegPeRp ChoukagJHoBgnJ0qK7aSQh/bjsxsQhc5i41k3Ap8bIGSVCw5Y5lC/uz7xRkXavSi+MZF cvig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734578361; x=1735183161; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EpgoYu5laNlw62BOxIYiXU6RPiLcOq/5n/sK95rvK5U=; b=L2u7BEG6q9GxztjVyOYk+2l0D+u4SZQPq3y6DQJ+QDZc495k+KJmdNe1vbLM2u6Xux B+hhyV1+zJhONZD4tHABUej0tqwUtdcd/KPY2TvhvANygBtTTIwwleoWqWKZ1M6txBvx TXKFk3Zn0pLdV7lSVbESff7yYYo2l+WbRpx85pK609djzRiXHsN+oRFZ3e+u938nYh0o k8BLWvW4/dfrMh/IyLeyTdkPuszXCXuKuw/PAbhFo0eiXXb+jbNCg2+/hUxvHcb8geJb MGvxoFnYoK4hQwBb0h7dj4Rqc5SNQfeU+viRxf3GxK8zCTKs5+aIx0R6DJW54YEVyoIR 8pBQ==
X-Gm-Message-State: AOJu0YyF/0Cxw1kY44MVUqmoYKHzCNAvpPS3VhvU02Nw0+t8DiGvePZQ HBDv7ywWx6XXZg7vFLQBMCvziC70ARl5qzuzWMxS7QCQYE4B7uueNnGt3YIGs4lB8oJy/qTV4H6 9oLTY/+rtu0Ll1XqIbZsHnKQemtbDCWlK
X-Gm-Gg: ASbGncvXS/Le6QHWyWEbKqsB5ysnN9r+jCks9DkuFisqZKmQloi+gYI9Oxsm1LmetNr bSbjZkyAFpuanQGe5k5puZ2aqsoyPVKxG1/QnAl4=
X-Google-Smtp-Source: AGHT+IFhAti6InXfq1qvHSpSK2biC6LcZBmbDZst2nRC0Y2blrsRJUrO2ejXR8C+EhvvEwvCQbFXR9g//XcwADAfZhE=
X-Received: by 2002:ad4:5f8f:0:b0:6d8:a091:4f5c with SMTP id 6a1803df08f44-6dd09239479mr79211626d6.33.1734578360757; Wed, 18 Dec 2024 19:19:20 -0800 (PST)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 18 Dec 2024 22:19:09 -0500
Message-ID: <CAF4+nEG+xN=Fahywwff1BpLaWQWuJAx=WitwCGrgeB2KnQqbsA@mail.gmail.com>
To: manet <manet@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID-Hash: OYIJCOBOP5Z3NUAMCATCK7B35XWPQ7CU
X-Message-ID-Hash: OYIJCOBOP5Z3NUAMCATCK7B35XWPQ7CU
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-manet.ietf.org-0; header-match-manet.ietf.org-1; header-match-manet.ietf.org-2; header-match-manet.ietf.org-3; header-match-manet.ietf.org-4; header-match-manet.ietf.org-5; header-match-manet.ietf.org-6; header-match-manet.ietf.org-7; header-match-manet.ietf.org-8; header-match-manet.ietf.org-9; header-match-manet.ietf.org-10; header-match-manet.ietf.org-11; header-match-manet.ietf.org-12; header-match-manet.ietf.org-13; header-match-manet.ietf.org-14; header-match-manet.ietf.org-15; header-match-manet.ietf.org-16; header-match-manet.ietf.org-17; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [manet] Review of draft-ietf-manet-dlep-radio-band-01
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/dAe7ghC1hGbGBx2gWPWcv7Pos54>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Owner: <mailto:manet-owner@ietf.org>
List-Post: <mailto:manet@ietf.org>
List-Subscribe: <mailto:manet-join@ietf.org>
List-Unsubscribe: <mailto:manet-leave@ietf.org>

Issues
------

Figure 1 is confusing. Assuming that Carrier Frequency and Bandwidth
are 64-bit quantities, the 32-bit boxes in the Figure should not have
duplicate names. Assuming network byte order, the first should, in
each case, have ", Upper Half" appended to the name in the box and the
second  should have ", Lower Half" appended or a similar change made.

For the text after Figure 1, please reconcile the difference between
"Carrier Frequency" in the Figure and "Center Frequence" in the text.
The text needs to say that the frequency and bandwidth items are 64
bits, assuming that's true. Assuming these 64-bit fields are unsigned,
the draft should say so to avoid ambiguity.

Nits
----
Section 1.:, Requirements language boilerplate is out of date and must
be updated. See RFC 8174.

Section 3, first sentence: "contains information which radio" ->
"contains information about which radio" or "contains information on
which radio"

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com