[manet] Rtgdir last call review of draft-ietf-manet-dlep-latency-extension-04

Carlos Pignataro via Datatracker <noreply@ietf.org> Wed, 03 July 2019 03:27 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: manet@ietf.org
Delivered-To: manet@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E94F12014B; Tue, 2 Jul 2019 20:27:27 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Carlos Pignataro via Datatracker <noreply@ietf.org>
To: <rtg-dir@ietf.org>
Cc: manet@ietf.org, ietf@ietf.org, draft-ietf-manet-dlep-latency-extension.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.98.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Carlos Pignataro <cpignata@cisco.com>
Message-ID: <156212444727.24005.11059998460216924141@ietfa.amsl.com>
Date: Tue, 02 Jul 2019 20:27:27 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/ptFmjBUMhhir2Lzu0wv1IfJjezI>
Subject: [manet] Rtgdir last call review of draft-ietf-manet-dlep-latency-extension-04
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jul 2019 03:27:27 -0000

Reviewer: Carlos Pignataro
Review result: Has Nits

TL;DR:
Reviewer: Carlos Pignataro
Review Result: Ready with Nits

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-manet-dlep-latency-extension-04.txt
Reviewer: Carlos Pignataro
Intended Status: Standards Track

Summary:
This document is basically ready for publication, but has nits that should be
considered prior to publication.

Comments:
This is a well written and straightforward document describing an extension to
RFC 8175's Dynamic Link Exchange Protocol (DLEP). The Data Item and Extension
Type for Latency Range closely follow the specification of the corresponding
Latency information elements from RFC 8175.

Minors/Nits for consideration:
* It would be useful to expand the DLEP acronym in the Title and Abstract.
* Regarding "The use of the Latency Range Extension SHOULD be configurable", an
operational comment: What is the default (enabled or disabled)? In what cases
does this not need be configurable (i.e., is it a MUST)? * Error checking: what
happens if the Latency data item defined in RFC 8175 falls outside the range of
the Latency Range data item herein defined? (i.e., I understand that should not
happen but I may be wrong). And what if Latency Range is included without
Latency being included? * Section 5: s/requests the assignment of 2
values/requests the assignment of two values/

Thanks!

Carlos Pignataro.