Re: [manet] WGLC comments on draft-ietf-manet-dlep-traffic-classification

Lou Berger <lberger@labn.net> Thu, 29 July 2021 22:43 UTC

Return-Path: <lberger@labn.net>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 653AF3A0C44 for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 15:43:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.702
X-Spam-Level:
X-Spam-Status: No, score=-1.702 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f0INfRp57jCP for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 15:43:33 -0700 (PDT)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2127.outbound.protection.outlook.com [40.107.220.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1CCA3A0C39 for <manet@ietf.org>; Thu, 29 Jul 2021 15:43:33 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tqn1xKqAmfOCGbPApYHK9m5wmIdCPGhMDI1C9prFi9T6prA5f04sUpzqSgvb0u0WUEIoZWM+CQadVYryEFF5cKAs9mt2NaDOVB2uOJMHpSVIp+4BG99Bdb12XUM19xeGnlsaBLKKDQisAQl1oGIpA6pppaGW7lunegfACLEivAdVSdoVllYO8GqJ5MmlFvlPVQAa0fzpqiyDDD5i4X2AM53xlFUggBvXrNjYnsmrBf7n+XnKLyFKdE1I4bxxgrWUET2RMLwufHjG4nzzLAyYKBksMHnMlmLM8ZEOyjbQ5oseUH9pzQ8uDfIiHCYrrtat9tNULEMv8Cmy4iO9bMsO1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewzT87e+104B9MucSIwnibbH7/wa3ViPTP49t+gkUbE=; b=BeW0c/STyg5TUSj0ZM0wV5FtydelLvgvHI4Okq9J0IKrT/AmeQFQHY6RqUloRUV+SoHSOFlFkGOaPWETgGPRXQHMzTAlQWozZea8qzPtSdyg7uETHziLfIwRsyV6cxELOvHRvVOD+udniYtrL66l7K1GxAT3SMtHvepHfaIbDJ9677+MIg4Oa9C3jmSXTJFwvr8HFMXisURh8tczDHD1a3awYSXkmi3Mfv2sd1DuVUJdUuxJNIvaeJtrq+7kCMdrodH0Qza9oAlQNgGFIxfe6Df/n9jVi6XVWNleRBa+X8KHVY+P4Fkv36UrXWsVuRBHgM205h7iMq/3ZFwhXUZWNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewzT87e+104B9MucSIwnibbH7/wa3ViPTP49t+gkUbE=; b=JbzedxjaEhBbWkwhBeV73h555hjH7KotVr/hJkFO+4WmzWWxZ4gQEQYlDCnoUdiv3s7M60Uz5G9JmVc1jF/qAU5i1QbAMNOiqlxwObdt4gW411M9Q7zd85iFZVOvsLU1BZ79FVxd/Y3FQSIH1woLGVWzN+9YOjt7fC/NXROG3Vg=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=labn.net;
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24) by BYAPR14MB2837.namprd14.prod.outlook.com (2603:10b6:a03:ab::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20; Thu, 29 Jul 2021 22:43:31 +0000
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792]) by SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792%7]) with mapi id 15.20.4373.020; Thu, 29 Jul 2021 22:43:31 +0000
To: "Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl>, "Wiggins, David - 0665 - MITLL" <David.Wiggins@ll.mit.edu>, Bow-Nan Cheng <bcheng@ll.mit.edu>, "manet@ietf.org" <manet@ietf.org>
References: <5dcbcd28031b4f6a97f3b97697e856b7@tno.nl>
From: Lou Berger <lberger@labn.net>
Message-ID: <2d91b86f-8498-5271-dab9-68fb6440b3bb@labn.net>
Date: Thu, 29 Jul 2021 18:43:28 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0
In-Reply-To: <5dcbcd28031b4f6a97f3b97697e856b7@tno.nl>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-ClientProxiedBy: BLAP220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::22) To SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [127.0.0.1] (100.15.108.238) by BLAP220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20 via Frontend Transport; Thu, 29 Jul 2021 22:43:30 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a9f9ea4-b774-4b69-55ac-08d952e24a1c
X-MS-TrafficTypeDiagnostic: BYAPR14MB2837:
X-Microsoft-Antispam-PRVS: <BYAPR14MB283704C083690BBD0019C558C3EB9@BYAPR14MB2837.namprd14.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: u8nmDxgQAeqXvatqQtaw8yrSpajCzwTh9b1EsiNFCYcwoX777NsBNcHWZshmSGfiA98uPrycOrIG6kvhis5MbVWzeoSzoRbOM+Zh+BSgM24yus5qs9tgwAgaSMU518wZ7fC/31wLZundQTdmrye4e57Lr/Wt/pB87uoNrwcF/uIFRZs1TrA/2RSnsLXllpsrTaxOnV1LEpgJqn7GZd6YsxLDvgmvNuNAMNSX8VNJRuvKeZm5nyAp/325Ut/DO+2scGZxGM6RywRcFp3y2ODnQpvTIGZtE1rRl4tgdCa0t5JK2KbGiypERV68KFaYQo246tBYRkRYP+z5y7q0oCERRNUlK/CTR5rs6edAtUMoJqouzMtn8UbrG0mBc/FwQZPZr+6SgawcyOD1e638cb4/gUG3yR4kvU1jHRgpTS4qRD1rFwjJW1KPQcYS9AAoJ+LyQmZqvku9+zkCrmtbcGumK4kyUDQzve3CH6ReZg0stuFl7cJ8uiWvgPmUWZBryIfLIoIp1gH3WiMjTvZlr3OJ/+kIbOaVx75MC//Ln8jzWzGOSDWJ8J4KeQNtndZIob/n9V05FBh/nQReti8HccyxAShhEAlPC8QHtEk3gwmUhq0YdARWRaFN+dtMEphH8BwW5RdXeFd0kz7FIBNxvZZTTBZ2uW+86neev89fAEr3dAvIuzxadg0kZ/hx7W4cK7vE+rzy8K0NQPKGFMTAM/BRPMZZxDDCSqSM4Dzm/C7Dn8qMLUF56qxLCiRFAkkYaxLxR98+mB8xXciSodf8tp/rWA==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR14MB4792.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(396003)(39830400003)(346002)(366004)(8676002)(2616005)(8936002)(110136005)(16576012)(316002)(956004)(31696002)(2906002)(7126003)(7246003)(478600001)(45640500001)(53546011)(31686004)(36756003)(5660300002)(66476007)(83380400001)(66946007)(38100700002)(186003)(6486002)(52116002)(66556008)(38350700002)(26005)(86362001)(66574015)(43740500002)(45980500001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?nBc18s2z+lsyEJ7TZSq5XWXn86QbgYPCO9q1z7wBufKX2hUc379DnGMI?= =?Windows-1252?Q?Ak5WJ45z1gCH6lP401CbuVCE43oZqILXeZsjncIA5JocZdb5156XBy2n?= =?Windows-1252?Q?fx4fY4tJqEruMuN5BfFn8UUXttkoPDGzNXUoLqwmT+JX5CuPH7zNHtoL?= =?Windows-1252?Q?MV0ahRUwZyofa1xBgdko0wwpjN1Bac+ZHpI5SyVg8ig6Vdl6eCRfx0sE?= =?Windows-1252?Q?Iw4KApmZBQnuScUdNczm+nrc3qdQ7QuZAoVhWIarEokuBAso5GewCkt+?= =?Windows-1252?Q?MBy9bF9D5uRGO7kle+OMO7rJ4vdGxzAsTPulKTYnEAAzwSqp8iQ1Bh4M?= =?Windows-1252?Q?IauHbYnLV8Js3FgnpMaqJB54GByWBFa9Q1YxsqB33DgQqIUN/QgjUD2n?= =?Windows-1252?Q?8xr+qZv7T8sIl8P7R+0KH3lbi5ZKInUQd7wavilWbB0minfEvjyHV65P?= =?Windows-1252?Q?ZHagixjKpr2wesilKokPNaZP3C3C4TX2RKx0WYBFWEl+B84n12iz6JTx?= =?Windows-1252?Q?Ca4FSe0Vcur5e0+apYNiH8qyLDWVTT7f09ACcBXSSjtNGqLPKNtj6pBk?= =?Windows-1252?Q?8fxbvv6A9by7XT5igW9N9mSDC/87heAhde3J0Fv2vSTz2ZepAVobMLch?= =?Windows-1252?Q?+RKQhjhPpDchgkjN/929SKd/L2WqQiSIZ4tHH4UTlZ6pktmMcxxxUkLA?= =?Windows-1252?Q?XzD+jXHjIt8I5nSrtGmj5Fs3gnJ6a6hZfS9p0CMPcK9ZV7emchYR8vAs?= =?Windows-1252?Q?8rss6GHX3DcfvtVOtx9dtnKEIX/sOU7Cl97/c04z2AwrqEY1tpKTXrTr?= =?Windows-1252?Q?cERKYal1btqsgF6yIUtU2graUTG7hTU1UezH39xm2P/OEnxuPdNJ2Yxo?= =?Windows-1252?Q?WGRtDj5c9FnhEjpiTUr1ZhZ2FzY8vUoGiiEYJJYBW+ZU9NInCEU0oRc+?= =?Windows-1252?Q?oVpNsBHTXaEyPOiZrkrakWE2/eIOI5zNP6rQF42F6Q7VA5WiJC+P58gV?= =?Windows-1252?Q?w8JXwWVEcCZOjQW2/juFj8H4b5gBdPUojCMY757ttN4Dk+1frOcxL+SS?= =?Windows-1252?Q?Ja0C8PF3Q7/gjjRJwaylHnw7QUNTM9Egi9AE67ORJn9weHiHKXaeNxgO?= =?Windows-1252?Q?IyeugQbJSEhayHL8F76KBy6/S8PLCtOJ7eLKyiSquOVQhrqqiHEOUW8V?= =?Windows-1252?Q?8Ug0VyCUZxg8NC0LzYtRXZapKm6imewwxCYPqFHc4Vhm5uKRNBoxDSw1?= =?Windows-1252?Q?h7bP6oGhqhvfOHV6fN/vQuhUOeIoribxC+OO55qgaeD4lyNlrmRpPbNq?= =?Windows-1252?Q?5B3jeme7nVvRzqcauWgNy3TzBvgtDgB0zS+JC1WRVxZdTSVgPLklJRdE?= =?Windows-1252?Q?8IXyFja9C2apT2+SLNbYfsIYEvtwTXnhAX5Gd08JqVjMnsTeJq9voeiP?=
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9f9ea4-b774-4b69-55ac-08d952e24a1c
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR14MB4792.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 22:43:31.0278 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qj4nXqri3yWKkiCYAVxAPbEFh3rwuDxzc8bYYwBIfY+Kw27OI9Tm+pcGjsaGNOxCxB34Yr/ply0YmOHz5TtbhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR14MB2837
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/q-vJQFCq0r-ESkICD-oIJwRquwc>
Subject: Re: [manet] WGLC comments on draft-ietf-manet-dlep-traffic-classification
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 22:43:37 -0000

[resend with full distro]

Hi Ronald,

see in line below.

On 7/15/2021 12:54 PM, Velt, R. (Ronald) in 't wrote:

> Hi Authors, MANET WG participants,
>
> Please find below my long overdue comments on
> draft-ietf-manet-dlep-traffic-classification, one of three documents
> related to credit-based flow control that have been in WGLC for a long
> time. (With chair wig off).
>
> Thanks,
>
> Ronald
>
> --
>
> Major Issues
>
> ============
>
> None
>
> Minor Issues
>
> ============
>
> Section 1, Introduction, contains the somewhat puzzling sentence
> "Specifically it enables traffic sent by a router to use traffic flow
> classification information provided by the modem to identify which
> traffic flows." It seems to me that it is the router, as opposed to
> the traffic, that uses the classification information to identify
> flows. The traffic cannot identify itself. Suggest to rephrase and
> clarify.
>
how about:

Specifically it enables a router to use traffic flow classification
information provided by the modem to identify traffic flows.


> It is unclear to me what is meant by "The list of flows contained in
> the Data Item can be used per sender or shared across multiple
> senders." in section 2, Traffic Classification.
>
I think this sentence can be dropped.


> Do Traffic Classification Sub-Data Items within a given Traffic
> Classification Data Item (as specified in section 2.1) all need to be
> of the same type (i.e., all DiffServ or all PCP) or is "mix and match"
> allowed? If the former, I would suggest stating this explicitly.
>
This is based on the extension.  I'll add a sentence on this:

Note that when extensions supporting multiple sub Data Items are
negotiated, these types MAY be combined in a single Data Item.

> Nits
>
> ====
>
> Throughout the document: Replace "sub data item" and "Sub Data Item"
> by "Sub-Data Item", thus following the precedent set by RFC8651. (I
> would personally have preferred "Data Sub-item" or even "Data Item
> Sub-item").
>
>   <
>
sure

> Abstract
>
> "It's use will be mandated  ..." => "Its use will be mandated  ..."
>
ack

> Section 1
>
> 1st para: "Credit windows may be shared or dedicated on a per flow
> basis." Credit windows appear out of the blue here, possibly due to a
> copy-paste error. Suggest deletion of this sentence.
>
yes!!!!

> 1st para: "The Data Item is structured to allow for reuse of the
> defined traffic classification information ..." => "The Data Item is
> structured to allow for use of the defined traffic classification
> information ..." (no other specific use has been mentioned yet)
>
agreed

> 1st para: "... with applications such as credit window control, such
> as found in [I-D.ietf-manet-dlep-da-credit-extension]" => "... with
> applications such as credit window control as specified in
> [I-D.ietf-manet-dlep-da-credit-extension]" (just a style suggestion)
>
sure

> 2nd para:
>
> "... and when combined with applications such as credit window
> control, allows credit windows to be shared across traffic sent to
> multiple DLEP destinations and flows, or used exclusively for traffic
> sent to a particular destination and/or flow." =>
>
> "... and when combined with applications such as credit window
> control, allows credit windows to be shared across traffic sent to
> multiple DLEP destinations and as part of multiple flows, or used
> exclusively for traffic sent to a particular destination and/or
> belonging to a particular flow." (Traffic is not sent TO flows)
>
good change, but you're killing me with visual diff here!

> 2nd para: Replace [I-D.ietf-manet-dlep-pause-extension] by [RFC8651]
>
thanks

> Section 2
>
> last sentence: "The scope of TID and FID values is a modem." => "TID
> and FID values have modem-local scope."
>
sure

> Section 2.3
>
> Definition of Length field:
>
> "... it is equal to four (4) plus the number of octets needed to carry
> the carried Priority fields is indicated by the NumPCPs field." =>
>
> "... it is equal to four (4) plus the number of octets needed to
> accommodate the number of Priority fields indicated by the NumPCPs field."
>
sure

> Definition of Pad field: "... and MIST be ignored on receipt." => "...
> and MUST be ignored on receipt."
>
thanks

> Section 6.2
>
> Replace informative reference I-D.ietf-manet-dlep-pause-extension by
> RFC8651
>
Thank you for another great review.  Upload will be done shortly.

Lou


PS sorry for missing you on the Acks in the previous review -- I'll
correct that in the next rev!


> This message may contain information that is not intended for you. If
> you are not the addressee or if this message was sent to you by
> mistake, you are requested to inform the sender and delete the
> message. TNO accepts no liability for the content of this e-mail, for
> the manner in which you use it and for damage of any kind resulting
> from the risks inherent to the electronic transmission of messages.
>