Re: [manet] comments on draft-berger-manet-dlep-ether-credit-extension

Lou Berger <lberger@labn.net> Thu, 29 July 2021 23:58 UTC

Return-Path: <lberger@labn.net>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 141C43A10B6 for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 16:58:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v1TZ_A_NC38t for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 16:58:31 -0700 (PDT)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2117.outbound.protection.outlook.com [40.107.237.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C75063A10B1 for <manet@ietf.org>; Thu, 29 Jul 2021 16:58:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EwPCL3plAssjxsgd1d0c+sQ3y4vFsCteMUIlM0QkuPgs1Nd8rTIvhBhJ9nE+x22uyjwEURiEV94orXzjdMLyteeZUKvM8mDGFXT5gB8CMfZFykcASrT7ajQ3KRswsfXbOHumuVaUZ+kkMZT3SiQ5ApSczABRaXwGj8z36zOw1b+3wGyKWJrgzOi1n9XT4IOkSYB/nEQthqbPQ5SyQWdOM34ioox54TpIBqJpXNh0SuVv4eKHZaglDseqTku6Lr9aJRsTHMACXMFJHA9FkNMTUqm1WEYJ7CiGO+l1VjTv6hi0whYCiCL77OdwsVXKToHvZo22PLON8QZxvSas6aEUMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtgonRDPsqo8nzwm4rgeUvH251Kq68L7Q5WboftkaxY=; b=GVovjJRf/6kKP5rmSIbu+8YSdQa0l3ZYrkgdDriUA5yAstCifd/A34Cuq93SjQ/d5Mf8gQ4DzuU7LoWP27mMkLWAY/UDVeJ50oQyWPxz1qC85Ph7ziasIq4tkWq9K3dJM8UOu18rIb4DG3IJ2iuF0oHWPo7+Mc3vNSSJ8+i9aTKM5LKTjPY7c5ZhkRvwO7CERgn8SH6Qg1FpstZsAthtoCwV9RbrNISiZNt12m/HTwW8a8UeUJscJXHOXswRvgonI/3QfWJjnfxyOsqKwct4ZQOCrdsSkhWSLtT/EXQD3Io+DVhRvuHWsaNeFOoGpz7ncJdwXgyJf6H8cTjawRIN0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtgonRDPsqo8nzwm4rgeUvH251Kq68L7Q5WboftkaxY=; b=J1QRsTHYWv22D2HeTi6e8SjsTLu9ccN2hbOPmWzUhE3YnnBTnYyDDnlhJp6W1wsIxbVGzzNROuNYdDEKxFmyMtBVXrOM1DqgpYG3Gxn56XJndD5pYP8CJcxclCEwTIep1n9KAk/MDTtpGpL9sYULX7QZN90ZgXOgWgjDcQEi4gA=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=labn.net;
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24) by SJ0PR14MB4645.namprd14.prod.outlook.com (2603:10b6:a03:35a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20; Thu, 29 Jul 2021 23:58:27 +0000
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792]) by SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792%7]) with mapi id 15.20.4373.020; Thu, 29 Jul 2021 23:58:27 +0000
To: "Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl>, "Wiggins, David - 0665 - MITLL" <David.Wiggins@ll.mit.edu>, "manet@ietf.org" <manet@ietf.org>
References: <c3e50cd966444de4ac83d184672344f1@tno.nl>
From: Lou Berger <lberger@labn.net>
Message-ID: <efb57d38-67a5-edcf-a320-a15960be0b1f@labn.net>
Date: Thu, 29 Jul 2021 19:58:24 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0
In-Reply-To: <c3e50cd966444de4ac83d184672344f1@tno.nl>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: BL0PR02CA0012.namprd02.prod.outlook.com (2603:10b6:207:3c::25) To SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [127.0.0.1] (100.15.108.238) by BL0PR02CA0012.namprd02.prod.outlook.com (2603:10b6:207:3c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17 via Frontend Transport; Thu, 29 Jul 2021 23:58:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ce846784-666c-4f46-4891-08d952ecc209
X-MS-TrafficTypeDiagnostic: SJ0PR14MB4645:
X-Microsoft-Antispam-PRVS: <SJ0PR14MB46455C7C0AAA6807A468F92DC3EB9@SJ0PR14MB4645.namprd14.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TQlroDyk7AXBEEEsh7qymlRmnKAG6PWHSNChK8M9r4nHYS/zg2dUkL4j1dbwwvrOUEcDelOYBbMd5OK1Ipp6u1NFFwIJYd7MlrJKdojlmkDqb2F8Hsl+Ja9LSQeRk2F0D+yfjy0YwU0ptVfAzEPvTR9zzhFKbB7ul6CZ+Zmx13Fs0DEb8Osx9yH7rYchTlC7e5XMFJAD1RUdZLJcDnjWw0T9m6bl4rYw7CVp7dHiFjLyWtUq0HffjT8U/mFWsKMp98oVFLBbGiBbrYW7JPLd70q5X27Zczgf93d0QIW4ZfQPqta6hxUnarFTMo7d1Ft8WFjqi6dhcnUCRjeP8z78sFMp/K8lQDVnpSM9rdgwWS51bX2o0/5wRd5By/CyTt4OMakrxumpL73syY1F4A8EBZNTROpmjLYHt79EoArldf87w6BZ6CJrEoiP+RZNAXl/GmsvOLu+BOLo9leKZDPQfVzudnSWlzzcR09TNXQzDNy/m7yXSYneimgIl1bW8tJDa5F6msyP8W40u42e5E97egvISP5bZM2FRuXQnNc+2ZVICID1mVubF0KLCZ7qUCJD0ewjmn8S6LMi0j1uEFtTjnsAMfNDdRjGt5CanK2rWgPyIgFFxmNfNCuZ8Bj2tgwGBHCMeM4oHuOADyXEtX3rb9LeDYJQT2rOW54NiacabQBUOC9kBVkyz5DDut/J6XYGwZX13UGDNh2s2otU1Iug+k03h8C3O++U8khKZ3aTpm7NEH0eWFp2uCHCWJyKRPEj1ineLEvsQxrAQRL0mG1kIw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR14MB4792.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(31696002)(316002)(7246003)(36756003)(8676002)(2906002)(16576012)(2616005)(8936002)(956004)(7126003)(31686004)(38100700002)(86362001)(66476007)(26005)(508600001)(66556008)(66946007)(53546011)(83380400001)(66574015)(52116002)(5660300002)(110136005)(6486002)(45640500001)(186003)(38350700002)(43740500002)(45980500001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?gx+uVOo0QAcichYh1BEPF206MJ3zX04As1EztKmdiThvBPe6NnvP4PJe?= =?Windows-1252?Q?iU9rAmiT61cMX492NKb2lMyhGugn3DowzvrI/JD7FerU+TPzqiHb7fM0?= =?Windows-1252?Q?0cPXBZdPqilTpJewSzpAotytOzsB9tspknd8LwytD7AilztXYEh649V9?= =?Windows-1252?Q?Vf+v6pW6FIatMUBCKcBLjZXsn5XiT2AeHorxy+nNveMekiG8mZ7BfNLW?= =?Windows-1252?Q?Wt0rWueaINFsDhRbcbM6wbO3J9iuF5v5apX02/8+xNCjZsrLGp+whI8g?= =?Windows-1252?Q?UWN/JFhQwfwM5Sqn0NgevuimkQ1fwjrfLYQz1C/GtqngWhSzc87IWLdc?= =?Windows-1252?Q?IBlpXiz6cDkPqIyBTxcEwPlsXqwLuylJ49JBEuBOIjwEgN0+blMT2eIM?= =?Windows-1252?Q?S7JqUGpDB2CQSlb4DPzn3XTtsRrbsb1Z1nYqstPyVGKr+4YauP8prkSa?= =?Windows-1252?Q?d72RIgzvmrB4fsUQERJUvZY84SMFfj5Clg5dMvtCLspVf1nq3RzGlN+w?= =?Windows-1252?Q?NxkbyioQwUzo8c6z/ibnaRSItNgXsYSPlXcdudC8f26iprSVo5yFthsP?= =?Windows-1252?Q?XVsJbgmlpNO0USDAllE5txRFzIZFI7KP0+2K0uUKtLat4PY4rGIWRKbK?= =?Windows-1252?Q?py2FduKLU1CQNBq9RWf2g9U5mFcqXUv+nRC1YGFXNHiZgkGk11IuDou6?= =?Windows-1252?Q?/4WnUIbOJ/ROeCSWQIJfLJ1KWTnJHTROYqoteXNsLehr2vithKyrMNuf?= =?Windows-1252?Q?ZYPr/cPhIxUY7T/vwo5nGPcTWS1gUVJnLnKlaCW2BiS/1/yvYc+YrVcN?= =?Windows-1252?Q?ZnqGe+f2gtrmRMTNPTL3t1VlGNwjcytn1HY5VwuwWP2FptUPGr+F8t84?= =?Windows-1252?Q?9OOydlz5we5/BRMC8SL56KqGzLbcUE7mH8hitwKZKLiB/ZdBHfJq3p3c?= =?Windows-1252?Q?QXZhG6bkbLk+rsv/k8mxP3f0/5i5cLd5Z+RnBmgAWCblUxzfvavDk54J?= =?Windows-1252?Q?xu7uGoRs9WPHx2X0sl0B5RwWuaYceGKdtmNjNh1Kf3Nfg5mZjjOuKpgl?= =?Windows-1252?Q?RAnNN0yxTFxeSR8eaPx2Nv9HgYdpJ4EEyjsnHvtzu0HDO50f07ChGjFt?= =?Windows-1252?Q?3Sf+MrmCZ+QU5nQSYyOGvB/41xlR0yqF6a8LaTtuLQ/l19VKQbMa7VY2?= =?Windows-1252?Q?w6E/1MFodTMgDt76HCqCsbJAIHpBC7mvKbr7gvtaF1gl4SVcL4zq+3c5?= =?Windows-1252?Q?Tv6IINhx5DGKOpfzsxYpA+MnvDNd7vJ/3X9LWAyZGfjQudJAs+Kw8po8?= =?Windows-1252?Q?p2+6A2ZkAyCuXV3QUvPwNvuBNyyeALaZd4AV9kugKx4Rs/A2Tgz5Gyxg?= =?Windows-1252?Q?jEDWLO706fkOq/Jbj8W4rNqAPxI3TsQZ+zXBHQ/+4ZVX7pL23iryg4HZ?=
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-Network-Message-Id: ce846784-666c-4f46-4891-08d952ecc209
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR14MB4792.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 23:58:27.2426 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o0otnOrzfUK2sI2YvyZpbvyQvOVKWxs1ZbsUBQB9jPuAtfM6fMBWzlCWt/rWJajyIRAvAXzWcs5nY2XbhxywBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR14MB4645
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/tHXkXMrEqTpamtEogn6uRkYC4Lc>
Subject: Re: [manet] comments on draft-berger-manet-dlep-ether-credit-extension
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 23:58:37 -0000

Hi Ronald,

Sorry for missing this one, see below

On 7/15/2021 1:25 PM, Velt, R. (Ronald) in 't wrote:
>
> Hi Authors, WG participants,
>
> Please find below my comments (as WG participant) on 
> draft-berger-manet-dlep-ether-credit-extension.
>
> Thanks,
>
> Ronald
>
> --
>
> Major Issues
>
> ============
>
> None
>
> Minor Issues
>
> ============
>
> Section 1, Introduction, contains the somewhat puzzling sentence 
> "Traffic sent by a router will use traffic flow classification 
> information provided by the modem to identify which traffic is 
> associated with each credit window." I would think it is the router, 
> as opposed to the traffic, that uses the classification information. 
> The traffic, which may originate from an upstream source, is what it 
> is. But then the question is HOW the router should make use of the 
> classification information. Should it e.g. set IEEE 802.1Q PCPs on 
> particular flows to ensure that they receive preferential treatment 
> (i.e., are throttled last in case of congestion)? In my opinion, at 
> the very least the sentence quoted above should be rephrased; in 
> addition some further clarification on the mechanism foreseen could be 
> helpful.
>
Agreed!
>
> Nits
>
> ====
>
> Section 1
>
> 3rd para: "... to provided credit window based flow control ..." => 
> "... to provide credit window based flow control ..."
>
agreed
>
> 3rd para: "... based on on DLEP destination and Ethernet VLANs and 
> Priority Code Points. " => "... based on DLEP destinations and 
> Ethernet VLANs and Priority Code Points. "
>
agreed
>
> 3rd para: "...shared across traffic sent to multiple DLEP destinations 
> VLANs, and PCPs, ..." => "...shared across traffic sent to multiple 
> DLEP destinations, VLANs and PCPs, ..."
>
thanks
>
> Section 2
>
> 1st para: "... the Ethernet Traffic Classification Sub Data Item," => 
> "... the Ethernet Traffic Classification Sub-Data Item," (following 
> the precedent set by RFC8651)
>
Done!

Thanks again, will have the update out shortly!

Lou

> This message may contain information that is not intended for you. If 
> you are not the addressee or if this message was sent to you by 
> mistake, you are requested to inform the sender and delete the 
> message. TNO accepts no liability for the content of this e-mail, for 
> the manner in which you use it and for damage of any kind resulting 
> from the risks inherent to the electronic transmission of messages.
>