Re: [manet] AD Review of draft-ietf-manet-dlep-multi-hop-extension-05

"Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl> Fri, 15 March 2019 17:11 UTC

Return-Path: <Ronald.intVelt@tno.nl>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9412712705F; Fri, 15 Mar 2019 10:11:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=tno.nl
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D79RdP9GV2s6; Fri, 15 Mar 2019 10:11:53 -0700 (PDT)
Received: from fromintouta.tno.nl (fromintouta.tno.nl [134.221.1.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 375FD130E7C; Fri, 15 Mar 2019 10:11:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tno.nl; l=4960; s=mta1; t=1552669914; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=W6l7S5cB4N2kEqIzJyEiZulRxXZNC6VepnNsRSSUQGo=; b=fGXR3/2U4pKsEnWQuFWmEsKR//WGVBsu3/Mi/7mCkRv+kIZJPlMjG89c FNDC5k7TmakwHYqrLasvLs+Fu5cXfquQFDZkt354hpPhyUqAm+zmbTiHu WkviKKzZ2Kfhhrv5LBbuuDcoBzb+CGQymfwaFDbnnw+nP7uHJgaU5EtRB E=;
X-IronPort-AV: E=Sophos;i="5.58,482,1544482800"; d="scan'208";a="42402338"
Received: from UCP13.tsn.tno.nl (134.221.225.173) by UCP14.tsn.tno.nl (134.221.225.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Fri, 15 Mar 2019 18:11:48 +0100
Received: from UCP13.tsn.tno.nl ([fe80::c142:976e:5281:8298]) by UCP13.tsn.tno.nl ([fe80::c142:976e:5281:8298%7]) with mapi id 15.01.1591.008; Fri, 15 Mar 2019 18:11:48 +0100
From: "Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl>
To: Lou Berger <lberger@labn.net>, Alvaro Retana <aretana.ietf@gmail.com>, "draft-ietf-manet-dlep-multi-hop-extension@ietf.org" <draft-ietf-manet-dlep-multi-hop-extension@ietf.org>
CC: "manet@ietf.org" <manet@ietf.org>, Mobile Ad-hoc Networks Working Group <manet-chairs@ietf.org>
Thread-Topic: [manet] AD Review of draft-ietf-manet-dlep-multi-hop-extension-05
Thread-Index: AQHUgRK/CN/18EKXq0qUzc122om/Y6YNirPZ///1WQCAAB+qsA==
Date: Fri, 15 Mar 2019 17:11:48 +0000
Message-ID: <bb78f15ded5c4496b74867af0127119e@tno.nl>
References: <CAMMESszKYXy_Oy-L+TgiJqqWBWOFTOxtnjuaX+O8Q+Jpg9iO3A@mail.gmail.com> <CAMMESsxztEYE3aDz0zmAsPwqpU9Q1szv0qiMcH8kUf=O9jhfgg@mail.gmail.com> <07cfd806-e3b1-3772-70a6-9db5af9662e7@labn.net> <CAMMESsz4rXqph=RR7hmnQM3hBT34=d6sLpxEkpyx7=3gPFJ9ng@mail.gmail.com> <9715773a-acb4-039f-a424-f881d0e05eef@labn.net>
In-Reply-To: <9715773a-acb4-039f-a424-f881d0e05eef@labn.net>
Accept-Language: en-US, nl-NL
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [134.221.225.191]
x-esetresult: clean, is OK
x-esetid: 37303A291C78446C627763
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/vbZG3jWIRTyQvdJy_cVLKewQoL0>
Subject: Re: [manet] AD Review of draft-ietf-manet-dlep-multi-hop-extension-05
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Mar 2019 17:11:57 -0000

Lou,

Another nit, see below.

> -----Original Message-----
> From: manet <manet-bounces@ietf.org> On Behalf Of Lou Berger
> Sent: vrijdag 15 maart 2019 17:10
> To: Alvaro Retana <aretana.ietf@gmail.com>om>; draft-ietf-manet-dlep-multi-
> hop-extension@ietf.org
> Cc: manet@ietf.org; Mobile Ad-hoc Networks Working Group <manet-
> chairs@ietf.org>
> Subject: Re: [manet] AD Review of draft-ietf-manet-dlep-multi-hop-
> extension-05
> 
> 
> On 3/15/2019 11:47 AM, Alvaro Retana wrote:
> > On March 8, 2019 at 9:54:24 AM, Lou Berger (lberger@labn.net
> > <mailto:lberger@labn.net>) wrote:
> >
> > Lou:
> >
> > Hi!
> >
> > Thanks for getting this done.
> >
> > I have a couple of nits below — and will also send a reply to your
> > exchange with Justin.   I’ll start the IETF LC in a couple of minutes.
> >
> > Alvaro.
> >
> >
> > ...
> >>>>>> ...
> >>>>>> 72 1. Introduction
> >>>>>> ...
> >>>>>> 80 Some modem technologies support connectivity to destinations
> >>>>>> via
> >>>>>> 81 multi-hop forwarding.  DLEP Destination messages can be used
> >>>>>> to
> >>>>>> 82 report such connectivity, see [RFC8175], but do not provide
> >>>>>> any
> >>>>>> 83 information related to the number or capacity of the hops. The
> >>>>>> 84 extension defined in this document enables modems to inform
> >>>>>> routers
> >>>>>> 85 when multi-hop forwarding is being used, and routers to
> >>>>>> request that
> >>>>>> 86 modems change multi-hop forwarding behavior.  The extension
> >>>>>> defined
> >>>>>> 87 in this document is referred to as "Multi-Hop Forwarding".
> >>>>>>
> >>>>>> [major] Please define "multi-hop forwarding" in the context of
> >>>>>> the modems.
> >>
> >> Done, please see the changes at the repo posted above and let me know
> >> if the changes are sufficient.
> >
> > Yes, I think that’s fine.  Just a nit: there’s some orphaned text
> > (“example using”) left in the new text.
> >
> >
> woops - thanks.
> > ...
> >>
> >>>>>>
> >>>>>> 166   Reserved:
> >>>>>>
> >>>>>> 168      MUST be set to zero by the sender (a modem) and ignored
> >>>>>> by the
> >>>>>> 169      receiver (a router).
> >>>>>>
> >>>>>> [major] I think that a registry for these bits is needed.
> >>>>>> Otherwise anyone can use them...
> >>
> >> My inclination would be to establish a registry on the second usage
> >> of the reserved field.  Right now I don't see additional uses and it
> >> seems like a lot of unneeded overhead at this point.  Of course,
> >> you're the AD so your view counts for more ;-)
> >
> > …but you still didn’t define the registry. :-(
> >
> > Seriously:  it’s ok.  I trust that the next user will do the right thing.
> >
> Thanks!
> 
> I've pushed your and some other nit changes to the repo, but don't think
> they need hold anything.

... and then there is a then that should be a than 😉 (line 191 in the latest repo version: "any messages other THAN a Link Characteristics Response Message.")

Thanks,
Ronald

> 
> Thanks,
> 
> Lou
> 
> _______________________________________________
> manet mailing list
> manet@ietf.org
> https://www.ietf.org/mailman/listinfo/manet
This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.