[manet] Review of draft-ietf-manet-dlep-radio-quality-01
Donald Eastlake <d3e3e3@gmail.com> Thu, 19 December 2024 03:32 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 13F8EC14F71E for <manet@ietfa.amsl.com>; Wed, 18 Dec 2024 19:32:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.857
X-Spam-Level:
X-Spam-Status: No, score=-1.857 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zQY2WmVWU7ba for <manet@ietfa.amsl.com>; Wed, 18 Dec 2024 19:32:17 -0800 (PST)
Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A1A31C14F701 for <manet@ietf.org>; Wed, 18 Dec 2024 19:32:17 -0800 (PST)
Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-46772a0f85bso2528311cf.3 for <manet@ietf.org>; Wed, 18 Dec 2024 19:32:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734579136; x=1735183936; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=4jJtbr6VEgQh+ghN9LLHEVsm3/b6JSyXKjc+YoRzguU=; b=CW2Xj9gNANk1BHIz4rA2cSsS+SGGtMO6SnEQDy+9Rvm3B+zNzPswqySgzGCrcIwcp4 J+rEnO8PhDSzqWCEKT06cUdnT/nKuAs2HqoXpYCED/JIy20IHTZGjGRTW8ugSmU+DxWj Yq1Te2AW5HtHKb70G+ThWa4PSpfTCzGMM4GQ/mqAcChJXiOn1TitP2y/6y3Xey6ihNjc fgxi68frIRob4Hz/Kbhdbi9+haPns06pg3qlIBEYWk4XgeiZHd+rb49QHH+kKV0T5XWp OATyLm4GvyhFXYgagPZxYxJy07rDfHAe047a2t4EHzM/MEDxAQqRI553lJHYeUvkUuMx EeYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734579136; x=1735183936; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4jJtbr6VEgQh+ghN9LLHEVsm3/b6JSyXKjc+YoRzguU=; b=DZaSlrO6Nn6kSpFjonHy0+Al3YSbZODuH6R483LqToLFNam2jXykJAg1cOZdSwBqOz ue7i9KxdRpnQf4+WDQJeBC4of0o38HJUdbAW786aCrJdrGx6bmeAmPO5eU6Bx7SBwtoA UauuVKR2nyqyrDKybIALeE/3h2ntHB9+4G9RCZurVYGCvYE2JAqWTFXtMLG47w9AiYn8 g9R0/mE/yxKsNly/sI3OyoKZPI+3t/ICjJ+Nz4WN4uWrBCJM78oi7Q1kr9u0hVMz4h0k kaRHHXD7AKHNPapgICe9LHEr0J7ec4LpPk3Rqn6KzDb9ZZpEIPGMaOlwx7e0mD4kYRz5 vuvA==
X-Gm-Message-State: AOJu0YzkqJRJvbWVnzvJPf2AaeKbsaV0z1rY/jBChlJqh7Jh1iLXTARK 2NHU1hVjlzyo1Af0HsRdIVfQRbhV2J32NukXtbf5fjoIbkX2JEjltGbFcQUCiHNUc3dK4Zr+baX 4FA6frv10fN4obT4gmxNuvAMpPlOUO5i2
X-Gm-Gg: ASbGnctKXdDmn8xYVAzUimcnMSDAPmL+Rh8LC1iRJTcL4BjJCM8XJ7HnNsb5zQasnfy cp1E6QMSjDIZj1QZ5eszYKYcQd3Ee8kG9IOGSh9E=
X-Google-Smtp-Source: AGHT+IHnmXfcup2Vs7ZoES+OQG132CC0NZh1PWg7OtFbqLFwXUqgLxafwzXBxDQLxAs6zCchVp7xYPKJ3hnL6F2u/+M=
X-Received: by 2002:ad4:4eac:0:b0:6dc:d29a:b18e with SMTP id 6a1803df08f44-6dd0925cc7amr103097326d6.47.1734579136202; Wed, 18 Dec 2024 19:32:16 -0800 (PST)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 18 Dec 2024 22:32:05 -0500
Message-ID: <CAF4+nEFtbJ4_T=7Q0Pq0zgK-3AyAvxU1BEen2cDGhvizM9-s3w@mail.gmail.com>
To: manet <manet@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID-Hash: TV27HP4M26KG4ATBUKITMOV5M2BYS2XF
X-Message-ID-Hash: TV27HP4M26KG4ATBUKITMOV5M2BYS2XF
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-manet.ietf.org-0; header-match-manet.ietf.org-1; header-match-manet.ietf.org-2; header-match-manet.ietf.org-3; header-match-manet.ietf.org-4; header-match-manet.ietf.org-5; header-match-manet.ietf.org-6; header-match-manet.ietf.org-7; header-match-manet.ietf.org-8; header-match-manet.ietf.org-9; header-match-manet.ietf.org-10; header-match-manet.ietf.org-11; header-match-manet.ietf.org-12; header-match-manet.ietf.org-13; header-match-manet.ietf.org-14; header-match-manet.ietf.org-15; header-match-manet.ietf.org-16; header-match-manet.ietf.org-17; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [manet] Review of draft-ietf-manet-dlep-radio-quality-01
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/wcqLWMKlfuhXyTkuYl1t23OHyMc>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Owner: <mailto:manet-owner@ietf.org>
List-Post: <mailto:manet@ietf.org>
List-Subscribe: <mailto:manet-join@ietf.org>
List-Unsubscribe: <mailto:manet-leave@ietf.org>
Issues ------ Section 3, last paragraph, first sentence: Mandatory requirement should be stated using RFC 2199 keywords such as "When using the Radio Quality extension, the Biterror Rate data item MUST be included." (Alternatively, you could leave this wording as is and put the "MUST" in Section 3.1.) Section 3.1: It seems to me that most of the range of the Biterror byte is useless as it represents astronomically tiny error rates. Shouldn't it be scaled? Maybe the decimal point should be in the middle so that N means one bit error in 10**(N/16) (or maybe 10** (1 + N/16) ) or something like that. (255 being a special value is fine.) Section 3.2, first sentence: Seems wrong. The data item does not seem to talk about "which signal". Section 3.2: I don't understand the explanation for "I" below Figure 2. The SINR acronym needs to be clearly expanded somewhere in the document. Section 3.3, first sentence: "contains information which absolute" -> "contains information about which absolute" or "contains information on which absolute" Section 3.4, first sentence: same problem as in Section 3.3. Section 5: "two" -> "five" "Both assignments" -> "These assignments" Section 5: The document uses "TBD" throughout for all five of the code points IANA is to assign. These should be replaced with something like TBD1, TBD2, TBD3, TBD4, and TBD5 so that it is completely unambiguous which table entry in Section 5 goes with which code point in the rest of the document. Section 5.2 heading: "Value" -> "Values" Nits ---- Section 1.:, Requirements language boilerplate is out of date and must be updated. See RFC 8174. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com
- [manet] Review of draft-ietf-manet-dlep-radio-qua… Donald Eastlake