Re: [Masque] Lars Eggert's No Objection on draft-ietf-masque-connect-udp-14: (with COMMENT)

David Schinazi <dschinazi.ietf@gmail.com> Thu, 16 June 2022 18:39 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: masque@ietfa.amsl.com
Delivered-To: masque@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9737FC157B4B; Thu, 16 Jun 2022 11:39:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UsCFUo7LJeC4; Thu, 16 Jun 2022 11:39:14 -0700 (PDT)
Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5CECBC157B43; Thu, 16 Jun 2022 11:39:14 -0700 (PDT)
Received: by mail-pj1-x1030.google.com with SMTP id e9so2087157pju.5; Thu, 16 Jun 2022 11:39:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WCGyqEZ179o7Km+dX6miuiyj8mBpKzkxHRf7dBgWP9Q=; b=aleNLP52fjnACHvsro0hyXz8P4Jhr/XFRu8tUvCWKzNadCHddRjTLUL3fcgsmu5WW7 lXlUTz/euJZAxfYt64BaMe1+UDZyGI0zQpfFA/sFGcoyWp5O90wXSNBcuXDM0b4i1lzk 94uFkjZUnOlhrHh6XMDigBADmYU99foUKejS6t+qSIe8/rA+/TU6GNmQFjAxCFdvidfm gIVQHXRdRk6lCDWpNujATA5UdL3D/MSXWmX07g3iERYVMffY1Nxn63F5psnv0h6pc/P+ bzAw5nHq7ZsWHjLC1M3omUqK/QRrk5A8bgRPeLoW/NDtUnR+sMxDKehYcvb5JA3Kj6cP Uplw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WCGyqEZ179o7Km+dX6miuiyj8mBpKzkxHRf7dBgWP9Q=; b=wzByoP8J0PoXMwUattUOeqqCe5oCN08tqYO2P1ETFbEXqZD8doo4HOo3kDyApStVQd dOaLXL25EOX3MSorreUIx2CsweF54kWkdfM5qXXC+M0p48e6Ni1wwEWOYD3yP+P7CdFf sc5afUxrAHZSgSyMij2OxiH75n6BskEC1t/6iV6kDKsK5lYhNaQ7N6V6Qiu22B7lYn6s EuFjjNm5fNaX3jqd8FALBDDugiJ6pqBg0eafdSOXi1rUgzxVlpqmex7pd2tPbS8WBm0e c0h8XQdAV8asOyygfLyGM0qIeVhEX/t1sTtWfVzH2efd0Qr/LZoHQFjEDgUx2T5e+2ar Tu2Q==
X-Gm-Message-State: AJIora/o41kXBgbD+1cmu1fbFWhUhjjf9KCQdGsusHXoxTKk9OFwPNtq Q6F/RmtSV7OqZoJrP46oTwyUsTKrARIZVLMu4l4=
X-Google-Smtp-Source: AGRyM1sFf/hEZLlpblwllcgk0ADX26uNslEXVNTWXEke7d/KIM77XH9DHi4UcwHj1NIS5JvuOA1Mxa55794/Xbutv5I=
X-Received: by 2002:a17:90b:96:b0:1e5:cae7:ba53 with SMTP id bb22-20020a17090b009600b001e5cae7ba53mr6477724pjb.73.1655404753788; Thu, 16 Jun 2022 11:39:13 -0700 (PDT)
MIME-Version: 1.0
References: <165538324203.60947.238363818130521939@ietfa.amsl.com>
In-Reply-To: <165538324203.60947.238363818130521939@ietfa.amsl.com>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Thu, 16 Jun 2022 11:39:02 -0700
Message-ID: <CAPDSy+79Nz8vFH6CjMnnzdXpycZC6d6dzbM7F-6WnhR39A5qjQ@mail.gmail.com>
To: Lars Eggert <lars@eggert.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-masque-connect-udp@ietf.org, masque-chairs@ietf.org, MASQUE <masque@ietf.org>, Eric Kinnear <ekinnear@apple.com>
Content-Type: multipart/alternative; boundary="0000000000004f238705e194f4c4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/masque/PLaeaFUA35QqR0wtx6VfAmGvaSE>
Subject: Re: [Masque] Lars Eggert's No Objection on draft-ietf-masque-connect-udp-14: (with COMMENT)
X-BeenThere: masque@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multiplexed Application Substrate over QUIC Encryption <masque.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/masque>, <mailto:masque-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/masque/>
List-Post: <mailto:masque@ietf.org>
List-Help: <mailto:masque-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/masque>, <mailto:masque-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2022 18:39:16 -0000

Hi Lars, thanks for your review.
Responses inline.
David

On Thu, Jun 16, 2022 at 5:40 AM Lars Eggert via Datatracker <
noreply@ietf.org> wrote:

> ### Section 3.1, paragraph 0
> ```
>   3.1.  UDP Proxy Handling
> ```
> This section as well as Section 6 later in the document have some overlap
> with
> the guidance in RFC8085, specifically, its Section 3. It might be good to
> align
> the guidance.
>

Good point, I've added a reference in this commit:
https://github.com/ietf-wg-masque/draft-ietf-masque-connect-udp/commit/32c72fc7db2d833f3b8c3f44df8ff4c016248c41

#### Section 3.1, paragraph 3
> ```
> her the destination is reachable. Therefore it needs to respond to the
> reques
>                                   ^^^^^^^^^
> ```
> A comma may be missing after the conjunctive/linking adverb "Therefore".
>

Agreed, fixed via this commit:
https://github.com/ietf-wg-masque/draft-ietf-masque-connect-udp/commit/d7fa471c67a112153b434d35736216246f54d485

#### Section 3.6, paragraph 2
> ```
> located within a given HTTP namespace but MAY be allocated in any order.
> The
>                                      ^^^^
> ```
> Use a comma before "but" if it connects two independent clauses (unless
> they
> are closely connected and short).
>

These two clauses are closely connected and short.

#### Section 9.1, paragraph 12
> ```
> ke to thank Eric Rescorla for suggesting to use an HTTP method to proxy
> UDP.
>                               ^^^^^^^^^^^^^^^^^
> ```
> The verb "suggesting" is used with the gerund form.
>

Agreed, fixed via this commit:
https://github.com/ietf-wg-masque/draft-ietf-masque-connect-udp/commit/d7fa471c67a112153b434d35736216246f54d485