[MBONED] Yangdoctors early review of draft-ietf-mboned-cbacc-02

Reshad Rahman via Datatracker <noreply@ietf.org> Sun, 11 April 2021 21:15 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Reshad Rahman via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-mboned-cbacc.all@ietf.org, mboned@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161817573499.20366.15012284864667773875@ietfa.amsl.com>
Reply-To: Reshad Rahman <reshad@yahoo.com>
Date: Sun, 11 Apr 2021 14:15:35 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mboned/-rTlwWf4J4TSfAEkuwY105WhQbE>
Subject: [MBONED] Yangdoctors early review of draft-ietf-mboned-cbacc-02

Reviewer: Reshad Rahman
Review result: Almost Ready

YANG Doctor review of rev-02 by Reshad Rahman.

Comments/questions:

The document and YANG module-name have CBACC, yet the module prefix is "ambi",
is this on purpose? Intuitively, I was expecting the prefix to be "cbacc".

For presence statement, use CBACC-enabled instead of cbacc-enabled?

Is max-mss for a TCP Max Segment Size, or is this really max packet size? And
no need for jumbograms since this is for UDP?

Consider renaming max-bits-per-second to something along the lines of
max-speed. Description says kilobits (not bits).

Add "unit" statement e.g. to data-rate-window and max-bits-per-second

OOC, why so many priorities? I'm used to seeing 3 or 8 bits for priority.

Security considerations should mention the YANG data nodes.

Regards,
Reshad.

[MBONED] Yangdoctors early review of draft-ietf-m… Reshad Rahman via Datatracker
Re: [MBONED] Yangdoctors early review of draft-ie… Holland, Jake
Re: [MBONED] Yangdoctors early review of draft-ie… Reshad Rahman