Re: [media-types] AD review of draft-ietf-dispatch-javascript-mjs-09

Alexey Melnikov <alexey.melnikov@isode.com> Wed, 25 August 2021 16:22 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: media-types@ietfa.amsl.com
Delivered-To: media-types@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6AA0D3A10F8; Wed, 25 Aug 2021 09:22:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTID8BHLnjHp; Wed, 25 Aug 2021 09:22:47 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id 476113A10F3; Wed, 25 Aug 2021 09:22:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1629908564; d=isode.com; s=june2016; i=@isode.com; bh=DfP7MjdvYF3Kzz9y9xXe8myAUC7uZTQRrMtD5ZDxr0Y=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=k3/8Q3IR24U+TlbI0tSWDCZ03i0ptSBgGDch48gr3aWAWB3eoloDNrgAsp25OvTA2fhIXE 6xtYKbL6rUckjdgHQCvT3RxzBzFCM0BIqYuSW/9qpqpEIi3j2juJ4Yl6WjvoLFaYIxK71n gNhFYCYL1Qle38xAo/hCCRfbmTXMaBw=;
Received: from [192.168.1.222] (host31-49-142-44.range31-49.btcentralplus.com [31.49.142.44]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <YSZuVABawU-m@statler.isode.com>; Wed, 25 Aug 2021 17:22:44 +0100
To: Francesca Palombini <francesca.palombini=40ericsson.com@dmarc.ietf.org>, "draft-ietf-dispatch-javascript-mjs.all@ietf.org" <draft-ietf-dispatch-javascript-mjs.all@ietf.org>, "dispatch@ietf.org" <dispatch@ietf.org>
Cc: "media-types@ietf.org" <media-types@ietf.org>
References: <4747725C-5B58-4CCF-8C05-856A02FE7055@ericsson.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <90c02186-55e5-f906-2727-86f1b52e6b0a@isode.com>
Date: Wed, 25 Aug 2021 17:22:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0
In-Reply-To: <4747725C-5B58-4CCF-8C05-856A02FE7055@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/media-types/EqObvdN1IDume16aKqXJkcJuuUg>
Subject: Re: [media-types] AD review of draft-ietf-dispatch-javascript-mjs-09
X-BeenThere: media-types@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IANA mailing list for reviewing Media Type \(MIME Type, Content Type\) registration requests." <media-types.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/media-types>, <mailto:media-types-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/media-types/>
List-Post: <mailto:media-types@ietf.org>
List-Help: <mailto:media-types-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/media-types>, <mailto:media-types-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2021 16:22:53 -0000

Hi Francesca,

Just commenting on a few things:

On 24/08/2021 16:49, Francesca Palombini wrote:
> Thank you for the work on this document. This is my AD review.
>
> I have divided comments into "main", "minor" and "nits". I'd like to have a discussion on my main comments before requesting the IETF Last Call. On the other hand, you can address the minors and nits together with any additional Last Call comments you will get. As I am coming in late to the process, please understand that I don't mean to re-hash existing discussions that I am not aware of, and I appreciate your patience: feel free to point me to previous discussion (and conclusions) I might have missed, if relevant.
>
> For the minor comments - some of these are suggestions or questions which I hope will help improve readability, which you can decide to take or leave as you please.
>
> Francesca
>
> ## Main
>
> 1. ----
>
> FP: This document is presented in the Abstract, Introduction and Compatibility section as aiming to update some IANA registrations for the media types mentioned, as well as documenting current usage of these media types. Because of that, I am not convinced about the use of BCP 14 language: if the intent is documenting current practices, most of these BCP 14 terms should be replaced by explanations on how implementations behave. To give an example of my concern, for the following paragraph in Section 4:
>
>     Implementations that support binary source text MUST support binary
>     source text encoded using the UTF-8 [RFC3629] character encoding
>     scheme.  Module goal sources MUST be encoded as UTF-8, all other
>     encodings will fail.  Source goal sources SHOULD be encoded as UTF-8;
>     other character encoding schemes MAY be supported, but are
>     discouraged.
>
> FP: Are these requirements that should have been there in RFC 4329 and are being added now? Are these how most implementations already behave? Would it not make more sense to reformulate this paragraph to describe implementations behaviour, rather than mandate and recommend? Why using BCP 14 terms?
I am not an editor of this document, but I am speculating that the above 
is more restrictive than originally specified in RFC 4329.
> This comment applies to all new occurrences of BCP 14 terms (it does not to apply to sections taken from RFC 4329, such as the first paragraph of section 4.1).
>
> 2. ----
>
> FP: Maybe more of a question: why is the "Encoding considerations" field in all subsections of section 6.1 "binary"? RFC 4329 did have more text about the encoding, is that obsoleted? Did I miss in which part of the draft this is discussed?

Actually text in RFC 4329 is pointing to RFC 3023 and the description in 
the latter is actually wrong. This field should be one of 4 values: 
7bit, 8bit, binary or framed. UTF-8 encoded JSON can be have CRLF 
terminated lines longer than 1000 octets, which makes the encoding field 
"binary".

Best Regards,

Alexey