Re: [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06

Hiroshi Tsunoda <tsuno@m.ieice.org> Mon, 14 May 2018 12:11 UTC

Return-Path: <dr.h.t@ieee.org>
X-Original-To: mib-doctors@ietfa.amsl.com
Delivered-To: mib-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1E6EF12DB6C for <mib-doctors@ietfa.amsl.com>; Mon, 14 May 2018 05:11:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.361
X-Spam-Level:
X-Spam-Status: No, score=-2.361 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ieee-org.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id orclp1hiVrF4 for <mib-doctors@ietfa.amsl.com>; Mon, 14 May 2018 05:11:10 -0700 (PDT)
Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04A4512DA4C for <mib-doctors@ietf.org>; Mon, 14 May 2018 05:11:10 -0700 (PDT)
Received: by mail-lf0-x22b.google.com with SMTP id p85-v6so17610331lfg.7 for <mib-doctors@ietf.org>; Mon, 14 May 2018 05:11:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7JJQcp/yM7DgZY/Xrvi9jlqHTgIBZuqB6y9wI+SU4BQ=; b=XluWUgPdFT17Ia09cZG2rPodsKw0y6hnneanYjBMwpWPLjAL73TVKDntV0/8MR/YOQ EjIN88f0T3ScH/jTp1GWo4MEaLNwepL3Uzt0dBowQmnogZwL6CKZA+EeDVAo6XYt4BFV VYhSM9uCiXeCKdbRNhCEStjEj6IxNhtE5tIY6oSKY0RO0aNqGW4N2dTgrA6U2d9vUchs LmtdwkzWQ5Ir6JYbm16r+pZSuklBd9Pdq0f3NRwKyp3+J+n6oI76JFGmFe7DRPQ31Da2 yRaXeOENWQVeOI+Du5/faOvuKSGzUnPWa+UAbLOc6lEFKWJmLX8rAR/KzVXRiEV46QyZ pXdQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=7JJQcp/yM7DgZY/Xrvi9jlqHTgIBZuqB6y9wI+SU4BQ=; b=JkS/o33pYmPO498oEgFmlzEvub4oEWyfwu6YCTZpFbaQcTvxWZi8F4q5JF5dGj/G9T 3U9Ej59LkNkE/3LMqVDecb6FAtb59YlHmNEmbG+yp3j1I8svGwTjDKHushZxa7TmE5X4 w+EeYKkBd49byr3zxVNmq+kKKOGZVI2/9wITGY7vXI2k44R4WuJZKo8aQSyvmD+N9VA6 VoNtyUtDDujI6QBygHdp04B018uk//EvClpzodvWZqvUvcuu9xocLG7v2RfyOZJb/+on nhlwtVE37aAei9NZB5/6O2PmpKScdgAjmld956NLsP/6UN3CC43/25P0yP/6OhX5WpKS r4yw==
X-Gm-Message-State: ALKqPwcvxqlReMHphwH6w5Qc6sqUTK7/ZwZB0iU5eO/nCNYJIeFtXpBM ciBcQgT3N1FjlYiqb0oFxHQKsiUKBm9I/8z6dFgq3g==
X-Google-Smtp-Source: AB8JxZrmtFiPr1/FlZA/E/7zefGcXUbw/C3jZkPkpg48jJVvArNQeXykKqdTyq2MLle6iDTTCtuwX/2HZfYt6sX6XNc=
X-Received: by 2002:a2e:9218:: with SMTP id k24-v6mr4254538ljg.70.1526299868113; Mon, 14 May 2018 05:11:08 -0700 (PDT)
MIME-Version: 1.0
Sender: dr.h.t@ieee.org
Received: by 2002:a2e:1b96:0:0:0:0:0 with HTTP; Mon, 14 May 2018 05:10:27 -0700 (PDT)
In-Reply-To: <70f776cd-f9c5-7031-eeaf-64c92e580cad@cysols.com>
References: <CAPbjwkzJi3xRr5cu5_6S_qHoqYcBTDYiUM_KcRA1opwedx4btQ@mail.gmail.com> <227a1df3-a65b-2f61-cf78-d57068953458@cysols.com> <70f776cd-f9c5-7031-eeaf-64c92e580cad@cysols.com>
From: Hiroshi Tsunoda <tsuno@m.ieice.org>
Date: Mon, 14 May 2018 21:10:27 +0900
X-Google-Sender-Auth: -5yfQVHKat8wkMVro4DTmNnPO4c
Message-ID: <CAPbjwkz7kD28aGcyjGq-3fvc-uW=hWkVSyJQWaZHOth3DdcWVA@mail.gmail.com>
To: Glenn Mansfield Keeni <glenn@cysols.com>
Cc: mib-doctors@ietf.org, Mach Chen <mach.chen@huawei.com>, bess@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mib-doctors/PFwAXyorGeOuoO0ghKoiNb9lWS8>
Subject: Re: [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mib-doctors/>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 12:11:13 -0000

Hi Glenn,

Thanks a lot for your review.
I am going to revise the MIB part along with your comments
and get back to you hopefully soon.

-- tsuno


2018-05-13 18:56 GMT+09:00 Glenn Mansfield Keeni <glenn@cysols.com>;:
> Hi Tsunoda,
>    I have done a review of the MIB. The comments follow.
> Glenn
>
> draft: draft-ietf-bess-mvpn-mib-06.txt
>        Only the MIB has been reviewed.
>
> COMMENTS:
>
> 1. Naming: Please review.
>         MO: mvpnBgpGenVrfRouteImport:
>               if it is a condition for import name accordingly
>
> 2. Usage:  Please make the usages of the following uniform in the document
>                       MVPN/mvpn/MVRF
>                       tunnel type/Tunnel type
>                       Source AS/source-as
>
>
> 3. Units:  The units for the following MOs are unspecified.
>         Please check.
>         MO: mvpnBgpGenCmcastRouteWithdrawalTimer
>         MO: mvpnBgpGenSrcSharedTreeJoinTimer
>         MO: mvpnBgpGenMsgRateLimit
>         MO: mvpnBgpGenMaxSpmsiAdRoutes
>         MO: mvpnBgpGenMaxSpmsiAdRouteFreq
>         MO: mvpnBgpGenMaxSrcActiveAdRoutes
>         MO: mvpnBgpGenMaxSrcActiveAdRouteFreq
> 4. Semantics:
>         InetAddress and INetAddressType objects
>             for several MOs, usage of InetAddressType unknown(0)
>             is described. In all such cases the corresponding
>             InetAddress MO value MUST be a string of length 0.
>             Plese explain that case in the respective DESCRIPTIONs
>             E.g. mvpnMrouteUpstreamNeighborAddr
>                  mvpnMrouteNextHopSourceAddr
>                  mvpnMrouteCmcastSourceAddr
>                  mvpnMrouteSourceAddr
>
> 5. mvpnSpmsiAdvtCmcastSourceAddr OBJECT-TYPE
>      SYNTAX        InetAddress
>      ==> corresponding InetAddressType object
>          mvpnSpmsiAdvtCmcastSourceAddrType is missing
>
> 6. Nits:
>         MO:  mvpnMrouteCmcastSourceAddrType OBJECT-TYPE
>              DESCRIPTION
>                  "A value indicating the address family of the address
>                   contained in mvpnMrouteSourceAddr.
>              s/mvpnMrouteSourceAddr/mvpnMrouteCmcastSourceAddr/
>
> 7. Table descriptions:
>      mvpnIpmsiAdvtTable
>      mvpnSpmsiAdvtTable
>         The DESCRIPTIONs are unclear.
>             Do the tables 'contain' all advertisements or,
>             Statistics related to the advertisements?
>
>
> 8. Additional suggestions:
>    o For INDEX clauses of variable size where the size may potentially
>      exceed 128 octets, a statement like the following will be good.
>             Implementors need to be aware that if the total number of
>             octets in MO1, MO2 and MO3 exceeds NNN, then OIDs of column
>             instances in this row will have more than 128 sub-identifiers
>             and cannot be accessed using SNMPv1, SNMPv2c, or SNMPv3.
>
>    o In REFERENCES be more specific if possible. Eg.
>        Current:
>            mvpnPmsiTunnelIfIndex OBJECT-TYPE
>               REFERENCE
>                   "RFC2863
>        Suggested:
>            mvpnPmsiTunnelIfIndex OBJECT-TYPE
>               REFERENCE
>                   "RFC2863 Sec. 3.1.5
>
>
>
>
> On 2018/05/02 6:59, Glenn Mansfield Keeni wrote:
>>
>> Hi Tsunoda,
>>     Thanks for the good work.
>> I will start reviewing this right away.
>>
>> Glenn
>>
>> On 2018/05/01 12:14, Hiroshi Tsunoda wrote:
>>>
>>> Dear Glenn,
>>>
>>> Thank you for waiting the update.
>>> I have submitted the updated version of
>>> draft-ietf-bess-mvpn-mib.
>>>
>>> Links to the draft and diff are as follows.
>>>
>>> URL:
>>> https://www.ietf.org/internet-drafts/draft-ietf-bess-mvpn-mib-06.txt
>>> Htmlized:       https://tools.ietf.org/html/draft-ietf-bess-mvpn-mib-06
>>> Htmlized:
>>> https://datatracker.ietf.org/doc/html/draft-ietf-bess-mvpn-mib
>>> Diff:
>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-mvpn-mib-0
>>>
>>> This version contains some major changes as follows.
>>> I hope this update make the role and usage of the MIB clear for you.
>>>
>>> +----------------------------------------------------------+
>>> Changes:
>>>
>>> 1. Support for row creation in all tables is removed
>>>
>>>     Reason: The utility of row creation is dubious.
>>>     It increases complexity of the MIB implementation.
>>>     Unless an immediate need for row creation, we will go ahead
>>>     with the current draft and review the need for row creation
>>>     at a later date if and when it arises.
>>>
>>> 2. Added objects to make the role and usage of this MIB clear.
>>>
>>>     Reason: This MIB will provide the following management functions.
>>>
>>>     - Configuration of MVRF related timers
>>>
>>>     - Generation of Notifications to indicate  creation, deletion,
>>>       and/or modification of MVRFs
>>>
>>>     - Generation of Notification  when a member joins or leaves a
>>>       multicast group
>>>
>>>     - Monitoring of the following
>>>       - attributes of MVRFs of MVPNs
>>>       - PMSIs
>>>       - statistics of advertisements exchanged by a PE
>>>       - routing entries in a MVRF
>>>       - next-hops for a multicast destination in a MVRF
>>> +----------------------------------------------------------+
>>>
>>> -- tsuno
>>>
>>
>> _______________________________________________
>> MIB-DOCTORS mailing list
>> MIB-DOCTORS@ietf.org
>> https://www.ietf.org/mailman/listinfo/mib-doctors
>
>