Re: [mile] Secdir last call review of draft-ietf-mile-xmpp-grid-09

"Nancy Cam-Winget (ncamwing)" <ncamwing@cisco.com> Mon, 04 March 2019 23:00 UTC

Return-Path: <ncamwing@cisco.com>
X-Original-To: mile@ietfa.amsl.com
Delivered-To: mile@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C67B1311EC; Mon, 4 Mar 2019 15:00:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=R/6d3DEu; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=OaWNoioa
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0jTuNSS3-6-R; Mon, 4 Mar 2019 15:00:26 -0800 (PST)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B3EC131130; Mon, 4 Mar 2019 15:00:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4656; q=dns/txt; s=iport; t=1551740426; x=1552950026; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nvraGNZ7bQG3Z+hLG2ws8px90DW7T9npBw0zqBQ4lUw=; b=R/6d3DEuBMyrk25PAy7R7cud39cp/McBqICMYtnHiiKdd6ORPSyrVH6Z Y6Z7n3+2Rt83nZM2c1YXAqfwwxVwWzXC2k9v6+b5BvjYjS6wi7Z1i8UF+ vKhi3D7EwIIIy9FxYfgKfI6ToH/yhXWNkcmhjrpwBC2Nhh5rerThDCX/9 A=;
IronPort-PHdr: =?us-ascii?q?9a23=3AiaSt6RNU0IuyDa37xtEl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEu6w/l0fHCIPc7f8My/HbtaztQyQh2d6AqzhDFf4ETB?= =?us-ascii?q?oZkYMTlg0kDtSCDBj9J/fvcC08E+xJVURu+DewNk0GUMs=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ANAABMrX1c/5xdJa1lGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBUQYBAQELAYE8UAOBXAQLJ4QIg0cDhFCLAIIyJZghgSQDVAsBASy?= =?us-ascii?q?EQAIXhA4iNAkNAQEDAQEDAQMCbRwMhUsGIxEMAQE3AQ8CAQgSAgYCCB4CAgI?= =?us-ascii?q?wFQIOAgQBDQWDIoFeAxUBnioCihRxgS+CeAEBBYUDGIILCIELJAGLJxeBf4E?= =?us-ascii?q?RJwwTgkyICzGCJoxEl0IJApJyGYF0hWKILoMeimSSIwIEAgQFAg0BAQWBRzi?= =?us-ascii?q?BVnAVZQGCQYIKDBeDS4pTcoEoj20BAQ?=
X-IronPort-AV: E=Sophos;i="5.58,441,1544486400"; d="scan'208";a="532056475"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2019 23:00:20 +0000
Received: from XCH-RCD-016.cisco.com (xch-rcd-016.cisco.com [173.37.102.26]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id x24N0IuL031424 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 4 Mar 2019 23:00:19 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-RCD-016.cisco.com (173.37.102.26) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 4 Mar 2019 17:00:17 -0600
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 4 Mar 2019 17:00:17 -0600
Received: from NAM04-SN1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 4 Mar 2019 17:00:17 -0600
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvraGNZ7bQG3Z+hLG2ws8px90DW7T9npBw0zqBQ4lUw=; b=OaWNoioaHl5SAEv50tvZ9h/OOHobwElN2i+PRLP4ASxf+SvE/lPhWCiTkw/1bruDmal63ISAd+UIGJNiDtCdeyH6W2Qz2RP34VbsEFRA9HMsacYIxxXlsQlSHwepGpl1BJV6WU9B9df018Hds0mB7E3E7ym7X5418bzfJ01H4h8=
Received: from BN6PR11MB1732.namprd11.prod.outlook.com (10.175.99.7) by BN6PR11MB1569.namprd11.prod.outlook.com (10.172.24.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Mon, 4 Mar 2019 23:00:16 +0000
Received: from BN6PR11MB1732.namprd11.prod.outlook.com ([fe80::3df6:de14:447c:4146]) by BN6PR11MB1732.namprd11.prod.outlook.com ([fe80::3df6:de14:447c:4146%3]) with mapi id 15.20.1665.019; Mon, 4 Mar 2019 23:00:16 +0000
From: "Nancy Cam-Winget (ncamwing)" <ncamwing@cisco.com>
To: Matthew Miller <linuxwolf+ietf@outer-planes.net>, "secdir@ietf.org" <secdir@ietf.org>
CC: "mile@ietf.org" <mile@ietf.org>, "draft-ietf-mile-xmpp-grid.all@ietf.org" <draft-ietf-mile-xmpp-grid.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Secdir last call review of draft-ietf-mile-xmpp-grid-09
Thread-Index: AQHUs0W2aSPmnUhDtUaqYfWjQfdJQaX7z2mA
Date: Mon, 4 Mar 2019 23:00:16 +0000
Message-ID: <5CFE429E-31EA-4261-B1CD-17181200F394@cisco.com>
References: <154826649938.7505.11018194912932133243@ietfa.amsl.com>
In-Reply-To: <154826649938.7505.11018194912932133243@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.7.190210
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ncamwing@cisco.com;
x-originating-ip: [2001:420:292:1260:1dfe:3a6c:3efe:7107]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d7212739-8ab2-4db5-e55d-08d6a0f52af8
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB1569;
x-ms-traffictypediagnostic: BN6PR11MB1569:
x-microsoft-exchange-diagnostics: =?utf-8?B?MTtCTjZQUjExTUIxNTY5OzIzOmNBazZmTGhQVnpKRU5TT05ydDlralFpRGt0?= =?utf-8?B?T2owbk9PWkdSMnRVOFAvMGZiNVVyeUNmVGx3RUdmOEVMTHJLZXJsbzBDSmpH?= =?utf-8?B?ZjE1RFQvRWp6RGpOS000a2pZcDZtR1I1QWRsRG03TFZQbjRZaEI3STNaVmZP?= =?utf-8?B?cnBXa1JKSUtFUkE2NDN5Zkt1aGo3alhFM1MyVW9pbm0yMGFacFlLQjBlcHp4?= =?utf-8?B?L2NJVVRPQjRBTkN6bXB3cFJ3OWdkUk8wREM5Nk54blA4ZTI1UXdRQ2orMDF5?= =?utf-8?B?eEFHMFBnSzVsWVNUNXg2b3R6UWFXNDk5ay9jRmYxaEErWmp4Y2RpVXU0OUFD?= =?utf-8?B?a2hlaFY4d09XRTlIWldaa1I4RnY5Sm5EMVZMcHdZemp1V2x4N0czbGhFNWJJ?= =?utf-8?B?KzQwUDBkck1tN0hFVEhtMWdONmdSOTk2NEN4NEY2c3YyeGpxb2VMQ2xkOVNT?= =?utf-8?B?ZnJXSzhqekRndzlzdmtyYXF0WjZTUWFoYy9kUk1rUW9DT1lhWHhTYjFGZFA0?= =?utf-8?B?amlOdU45cGZRd0N0cFdoWVJIWFZHR053OXFDcmxhY0Y3d25IbDJ6TVNnS0U1?= =?utf-8?B?RHMrK0lpSTg5ZkJ5MmMzZ25MOGY4Ym5XZEVjVmt0dDRlektaWXMvaEVPUlNk?= =?utf-8?B?b09UTGNQRVRJT1dRbGdWRGZoaTNHVVVhM01ScENPN2JzazIvRytXbHo5UkxU?= =?utf-8?B?TmpybEs2VUVGMW9WVWJMekIzTXJNRHRXWnlKUHFTSG9oUzU4YXBkOG1EYzNL?= =?utf-8?B?UUFRbUxHbnFoZkU1eS91MUdKejVhTDgrM2M5UnhSL2svZXBGY3IwVDFuNVRS?= =?utf-8?B?eVZOVldBUTd5Z05yMFV4ZGZGcU5Xa243OXpFbE0xTVdCU1A4c2lNdXBwa01P?= =?utf-8?B?aXM2NUZjZFRlZXFsYzBkM1pSU2dsblVOUVcrRFdiWHdxbS9sUmYwRUROT2VS?= =?utf-8?B?WGgrUVdVc0FFc1owUmJpMmxrYWt1Q2g3NitmcS9YeVdkeUU5RmZLbHhwNzJR?= =?utf-8?B?b2RUc2xRVkdWWEhBbGdFdDBIbHA0alliQWJ1ZkxKRThwSk10UVZocmdtc3BC?= =?utf-8?B?cllhcDVhU0VRb3FnMUcxTVJNcUsyMDViYkdtMk96TXZIUExOYk11eTBjZ3Zn?= =?utf-8?B?UnduYmcwUlM3V0NRWkVOQTRBcndBRHAxQm5ZTDRIZUhjbktKYmxHcHVSS05E?= =?utf-8?B?akpiZm5QSURDRXEyWi9TcnJNdE9LSHpQRDNzUGxsRURVZmZkcWhtbXlybzhw?= =?utf-8?B?SUxocC9wY1F1VXc3NEptVUg5eHMxcy9hcnh0YXROUDdDOUxkTzYzcldjeHF0?= =?utf-8?B?eWVmNVNuVWlGY0c1akhLUDF2NUlLd2NiRDIrZnZXbmJ2S2FjU3diMXpFOUxJ?= =?utf-8?B?eFExUkltY3RuNUFIUlJpbnBXZXFQajJuenM5Ri92RGd6NDVmRkhJWXpHVXlG?= =?utf-8?B?L3IvVTdnejhLZlMrWGFJV09sY0JoTytselltbFJKeXQ2YzFjUkk2MEhRUHVt?= =?utf-8?B?WkI4emdqaU9XT3ozZGJ5OFVnMmZkYklaWXUrWjYxVkZEbEsrdzRaSHN2T0pm?= =?utf-8?B?dWtYSis4aE80YVZFUHhhS1VRSzJFUC9VTW5WTW5YTnRXYWppSzZUUkFzejhL?= =?utf-8?B?dEpZZmZnWFYxTFdPbExiaklrNWZOWmg5ZnVTNGU5V21yVDhVeUVIclEyeCtt?= =?utf-8?Q?cSEfQnN6otySGoAtU0OOfBTTeeMGUcSsWr4WKiZ?=
x-microsoft-antispam-prvs: <BN6PR11MB1569D08437299A0774A225B0D6710@BN6PR11MB1569.namprd11.prod.outlook.com>
x-forefront-prvs: 09669DB681
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(346002)(376002)(396003)(189003)(199004)(51914003)(81156014)(102836004)(81166006)(8676002)(6116002)(46003)(97736004)(229853002)(68736007)(8936002)(6246003)(256004)(14444005)(6436002)(11346002)(446003)(2616005)(186003)(105586002)(476003)(106356001)(486006)(58126008)(6512007)(305945005)(82746002)(76176011)(25786009)(54906003)(14454004)(86362001)(7736002)(110136005)(2906002)(2501003)(6486002)(71190400001)(71200400001)(33656002)(53936002)(36756003)(4326008)(6506007)(83716004)(5660300002)(99286004)(478600001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR11MB1569; H:BN6PR11MB1732.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: i6PenAnT2+IUiw+QTsQY1/4Xr5D7gWJDP+KDAtQwtm4EQgXcwuOGmThAcngAu7+adtAYNFU1dje2U95nf9azggSDgIaz/UZtRCL6G2lRDbcRLKLEr6j8J1XCEPCk6kMre9KN8Bz+ecuZjPgOo2c/UXSFb4RIrlquudevaXaEhKxj3I7sYl+3rJUfDbyyfyAEqU3QZuqRVsV7fJ3Nm8peYmSSoxU8i7MVG3MPUtqaRI1enqHOMSuE0UHVgeKq033tImeAqtbQbFZAluJDMX6LrxkLAlOlNdhpiYwUtBUgSikq2fs6Lj+oABNvXJpLkA4K30JnOfHeKP82HggzM0kuTJ0v3d3FzgJDlnHqdPpuRHoyx3+j1UB3l28QU71YfqEPOx4F3zmE+rnWdPYJ7cLAJppiHlaJIyQUXEtyhOFh7Ew=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4D59E790B8B98F409B47FE7E88C18155@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d7212739-8ab2-4db5-e55d-08d6a0f52af8
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 23:00:16.5658 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1569
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.26, xch-rcd-016.cisco.com
X-Outbound-Node: rcdn-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mile/8eL55023jAPQ-3hN7xDkQZp_tCg>
Subject: Re: [mile] Secdir last call review of draft-ietf-mile-xmpp-grid-09
X-BeenThere: mile@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Managed Incident Lightweight Exchange, IODEF extensions and RID exchanges" <mile.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mile>, <mailto:mile-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mile/>
List-Post: <mailto:mile@ietf.org>
List-Help: <mailto:mile-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mile>, <mailto:mile-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 23:00:29 -0000

Hi Matt, thanks for the review.  Please see below for comments:

´╗┐On 1/23/19, 10:01, "Matthew Miller" <linuxwolf+ietf@outer-planes.net>; wrote:

    Reviewer: Matthew Miller
    Review result: Has Issues
    
    I have reviewed this document as part of the security directorate's
    ongoing effort to review all IETF documents being processed by the
    IESG.  These comments were written primarily for the benefit of the
    security area directors.  Document editors and WG chairs should
    treat these comments just like any other last call comments.
    
    Document: draft-ietf-mile-xmpp-grid-09
    Reviewer: Matthew A. Miller
    Review Date: 2018-01-23
    IETF LC End Date: 2019-01-14
    IESG Telechat date: 2019-01-24
    
    Summary:
    
    This document defines an architecture for distributing security
    information using publish-subscribe semantics over XMPP.  It is
    well written and addressed many (but not all) known concerns
    of a publish-subscribe 
    
    This document has issues that should be addressed before it is
    ready to be published as a Proposed Standard.
    
    
    Major Issues:
    
    The document does not explicitly discuss the implications of the
    Controller and Broker having plaintext access and control of the
    published data.  It seems to be implied in the section 8.2.3 for
    the Controller (and, for those proficient with XMPP, the Broker).
    I am not strongly recommending any sort of end-to-end protections
    be proscribed (since existing protections are likely unsuitable
    for this architecture).
[NCW] We have added a sentence in 8.3.3 to address protection 
against controller/broker to employ end-to-end encryption.
    
    The document does not have any real discussion around persistence
    of node items.  if they are expected or desired to be persisted,
    then there should be some discussion about retention policies
    (meaning: deployments ought to have one), and behaviors when a
    Platform subscribes to the Topic (e.g., should or may automatically
    send the last published item to the recent subscriber).  If not,
    then some discussion on the implications of existing/historic
    data being unavailable through this mechanism.
[NCW] Fair point. We added the following statements to the document to address this -
Note that the control plane may optionally also implement XEP-0203 to facilitate delayed
delivery of messages to the connected consumer as described in XEP-0060. Since information
may be timely and sensitive, capability providers should communicate to the controller
whether its messages can be cached for delayed delivery during configuration; such function
is out of scope for this document.    

    Minor Issues:
    
    XMPP pubsub is complex, and node configuration reflects that.
    Relying on XEP-0060 is something of a disservice to implementers,
    in my opinion.   I suggest that an addition Topic creation
    example be added that demonstrates the recommended configuration:
    * pubsub#access-authorize or access-whitelist
    * pubsub#persist_items = ?? (1 or 0)
    * pubsub#send_last_published_item = ?? (on_sub? never?) 
[NCW] That seems reasonable, I will add it as an option (as the current section does state it is the minimal for topic creation).
    
    Nits: N/A