Re: [mile] review request on the json IODEF draft at https://github.com/milewg/draft-ietf-mile-jsoniodef

"Takeshi Takahashi" <takeshi_takahashi@nict.go.jp> Tue, 25 December 2018 09:54 UTC

Return-Path: <takeshi_takahashi@nict.go.jp>
X-Original-To: mile@ietfa.amsl.com
Delivered-To: mile@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 14F85130DE4 for <mile@ietfa.amsl.com>; Tue, 25 Dec 2018 01:54:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T7K7dgh1s7sh for <mile@ietfa.amsl.com>; Tue, 25 Dec 2018 01:54:21 -0800 (PST)
Received: from ns2.nict.go.jp (ns2.nict.go.jp [IPv6:2001:df0:232:300::2]) by ietfa.amsl.com (Postfix) with ESMTP id A42A1130DD1 for <mile@ietf.org>; Tue, 25 Dec 2018 01:54:21 -0800 (PST)
Received: from gw2.nict.go.jp (gw2.nict.go.jp [133.243.18.251]) by ns2.nict.go.jp with ESMTP id wBP9sIfI058019 for <mile@ietf.org>; Tue, 25 Dec 2018 18:54:18 +0900 (JST)
Received: from mail2.nict.go.jp (mail2.nict.go.jp [133.243.18.15]) by gw2.nict.go.jp with ESMTP id wBP9sI7b058015 for <mile@ietf.org>; Tue, 25 Dec 2018 18:54:18 +0900 (JST)
Received: from LAPTOP9DLCDU5S (ssh1.nict.go.jp [133.243.3.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail2.nict.go.jp (NICT Mail Spool Server2) with ESMTPSA id 5E9491477A for <mile@ietf.org>; Tue, 25 Dec 2018 18:54:18 +0900 (JST)
From: Takeshi Takahashi <takeshi_takahashi@nict.go.jp>
To: 'MILE IETF' <mile@ietf.org>
References: <2b4da7d3-e65a-c16e-cf30-baa4875a726f@lepidum.co.jp>
In-Reply-To: <2b4da7d3-e65a-c16e-cf30-baa4875a726f@lepidum.co.jp>
Date: Tue, 25 Dec 2018 18:54:18 +0900
Message-ID: <12e601d49c37$cdae6600$690b3200$@nict.go.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHQMshHTfWdhorKvqOVXT4XYkJbrKWYCKdA
Content-Language: ja
X-Virus-Scanned: clamav-milter 0.100.1 at zenith2
X-Virus-Status: Clean
Archived-At: <https://mailarchive.ietf.org/arch/msg/mile/NFEzKA3fn0CnsOTP92Ngzh6mpaM>
Subject: Re: [mile] review request on the json IODEF draft at https://github.com/milewg/draft-ietf-mile-jsoniodef
X-BeenThere: mile@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Managed Incident Lightweight Exchange, IODEF extensions and RID exchanges" <mile.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mile>, <mailto:mile-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mile/>
List-Post: <mailto:mile@ietf.org>
List-Help: <mailto:mile-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mile>, <mailto:mile-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Dec 2018 09:54:24 -0000

Hi Takahiro,

Thank you very much for your kind reviews.

The latest version of the draft on the github reflected your kind comments.
The table in Section 3.1 and the CDDL data model/json schema were corrected.

https://github.com/milewg/draft-ietf-mile-jsoniodef

Thank you, and kind regards,
Take



-----Original Message-----
From: mile <mile-bounces@ietf.org> On Behalf Of Takahiko Nagata
Sent: Thursday, December 20, 2018 4:50 PM
To: MILE IETF <mile@ietf.org>
Subject: Re: [mile] review request on the json IODEF draft at
https://github.com/milewg/draft-ietf-mile-jsoniodef

Hi Take

 > (2) [Question]DomainData, Address of Node should be exist  > at the same
time?

Sorry, this comment is unnecessary.
Because of my misunderstood "xs:choice".

"xs:choice" with maxOccurs="unbounded" can select element at each reptition.

So, DomainData and Address can exists at same time.
And, I also confirm this XML Schema with XML validators(xmllint, msv).


Finally, my comment is only this one.


(1) Should apply ErrataID: 5398 (AlternativeIndicatorID)

Errata ID: 5398
https://www.rfc-editor.org/errata/eid5398

CDDL in latest draft says:
```
AlternativeIndicatorID = {
   ? restriction: restriction .default "private"
   ? ext-restriction: text
   IndicatorReference: [+ IndicatorReference] } ```

It should say:
```
AlternativeIndicatorID = {
   ? restriction: restriction .default "private"
   ? ext-restriction: text
   IndicatorID: [+ IndicatorID]
}
```


Best Regards,
Takahiko Nagata

_______________________________________________
mile mailing list
mile@ietf.org
https://www.ietf.org/mailman/listinfo/mile