Re: [mile] Alexey Melnikov's Yes on draft-ietf-mile-jsoniodef-13: (with COMMENT)

"Takeshi Takahashi" <takeshi_takahashi@nict.go.jp> Mon, 10 February 2020 18:17 UTC

Return-Path: <takeshi_takahashi@nict.go.jp>
X-Original-To: mile@ietfa.amsl.com
Delivered-To: mile@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7FB5112081E; Mon, 10 Feb 2020 10:17:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nict.go.jp
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x3nqogIAkY0H; Mon, 10 Feb 2020 10:17:45 -0800 (PST)
Received: from mo-csw.securemx.jp (mo-csw1516.securemx.jp [210.130.202.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDD4E12081C; Mon, 10 Feb 2020 10:17:44 -0800 (PST)
DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=nict.go.jp;h=From:To:Cc: References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding;i=takeshi_takahashi@nict.go.jp;s=20190225.smx;t= 1581358657; x=1582568257; bh=7K5Mj2J+2i4ky6t/BDu8K/wq73xYscCWIvYmQjVTkak=; b=INk +7OXOI4g4ty+9jX+C5sm35gBHD19TygkZjlLYjzQjcoR/1UVRao0GzBl5N3STvmQOPwlRUx6DNI2D jBPNd2O3e7gVyQ210E3lNnRN8DDe9cj4jY4pA0xziABBDLPWvbL1cJ8DgdRrAx2oBh97+Lzada0s/ Jqqa+xAirS79+UsJxcKt6P9Uz2RGgWvUhLVYrHFi6PUu79AtT6cnc1riRgrDL3ssGghbiXE2VM9pO U7YYepSC8YTfdt99Lj8OVcYY5KbfLciFduosqH3C56oqnhXeHbI3sDJ+hkQ5iE+ePT1GgWXRcV9Gj x/h/rOeqq+xIZX1m4MY2ta228VZ62HA==;
Received: by mo-csw.securemx.jp (mx-mo-csw1516) id 01AIHabW012604; Tue, 11 Feb 2020 03:17:36 +0900
X-Iguazu-Qid: 34treNMPbvStQqe21w
X-Iguazu-QSIG: v=2; s=0; t=1581358655; q=34treNMPbvStQqe21w; m=5tKhIFOF7oQwKvLajWx4zcibL06sbpXd8inoLPMg+Co=
Received: from mail2.nict.go.jp (ipv6.mail2.nict.go.jp [IPv6:2001:df0:232:1200::f]) by relay.securemx.jp (mx-mr1512) id 01AIHYAT036413 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 11 Feb 2020 03:17:35 +0900
Received: from LAPTOP9DLCDU5S (ssh1.nict.go.jp [133.243.3.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail2.nict.go.jp (NICT Mail Spool Server2) with ESMTPSA id A57F43472E; Tue, 11 Feb 2020 03:17:33 +0900 (JST)
From: "Takeshi Takahashi" <takeshi_takahashi@nict.go.jp>
To: "'Alexey Melnikov'" <aamelnikov@fastmail.fm>, "'The IESG'" <iesg@ietf.org>
Cc: <mile@ietf.org>, <mile-chairs@ietf.org>, <draft-ietf-mile-jsoniodef@ietf.org>
References: <158133359232.4113.3743042372265721969.idtracker@ietfa.amsl.com>
In-Reply-To: <158133359232.4113.3743042372265721969.idtracker@ietfa.amsl.com>
Date: Mon, 10 Feb 2020 10:17:35 -0800
Message-ID: <03ab01d5e03e$5eb74180$1c25c480$@nict.go.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHSxjoigjuKVQDfAiZ6MuvBdHx5jKga5MzA
Content-Language: en-us
Archived-At: <https://mailarchive.ietf.org/arch/msg/mile/npMKUJB1Obpx9-XHBHiApTwumNE>
Subject: Re: [mile] Alexey Melnikov's Yes on draft-ietf-mile-jsoniodef-13: (with COMMENT)
X-BeenThere: mile@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Managed Incident Lightweight Exchange, IODEF extensions and RID exchanges" <mile.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mile>, <mailto:mile-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mile/>
List-Post: <mailto:mile@ietf.org>
List-Help: <mailto:mile-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mile>, <mailto:mile-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2020 18:17:48 -0000

Hello Alexey,

Thank you for your kind review.

> Why are you using SHOULD twice above? Is there any reason why you are not
using MUST?

We have changed them into MUST. Thank you.

> I think you meant "specified" here instead of "prepared".

Thank you for the correction.

> I am not sure what "Otherwise" is used for here? Are you saying that the
default is either "en" or another value agreed by both receiver and sender?
> If this is what you intended, then I think the sentence starting with
"Otherwise" is not correct, as it will cause non interoperable behaviour.
I.e., if the default is not "en", the language tag has to be specified in
the JSON document.

We have deleted the sentence starting with "Otherwise" because it does not
make sense and it causes non interoperable behavior as you kindly pointed
out.

The changes are already reflected to the working github repository.
https://github.com/milewg/draft-ietf-mile-jsoniodef

Let me publish this document to the datatracker after some time (because we
might receive further comments.)
Thank you very much.

Best regards,
Take



-----Original Message-----
From: mile <mile-bounces@ietf.org> On Behalf Of Alexey Melnikov via
Datatracker
Sent: Monday, February 10, 2020 3:20 AM
To: The IESG <iesg@ietf.org>
Cc: mile@ietf.org; mile-chairs@ietf.org; draft-ietf-mile-jsoniodef@ietf.org
Subject: [mile] Alexey Melnikov's Yes on draft-ietf-mile-jsoniodef-13: (with
COMMENT)

Alexey Melnikov has entered the following ballot position for
draft-ietf-mile-jsoniodef-13: Yes

When responding, please keep the subject line intact and reply to all email
addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mile-jsoniodef/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for addressing my earlier DISCUSS. Below are a few minor
questions/comments based on your most recent changes to the document:

2.2.5.  Structured Information

   When embedding the raw data, base64 encoding defined in Section 4 of
   [RFC4648] SHOULD be used for JSON IODEF while binary representation
   SHOULD be used for CBOR IODEF.

Why are you using SHOULD twice above? Is there any reason why you are not
using MUST?

2.2.6.  EXTENSION

   Note that this data type is prepared in [RFC7970] as its generic

I think you meant "specified" here instead of "prepared".

   extension mechanism.  If a data item has internal structure that is
   intended to be processed outside of the IODEF framework, one may
   consider using StructuredInfo data type mentioned in Section 2.2.5.

In 3.2:

   o  The elements of ML_STRING type in XML IODEF document are presented
      as either STRING type or ML_STRING type in JSON IODEF document.
      When converting from XML IODEF document to JSON one or vice versa,
      the information contained in the original data of ML_STRING type
      must be preserved.  When STRING is used instead of ML_STRING,
      parsers can assume that its xml:lang is set to "en".  Otherwise it

I am not sure what "Otherwise" is used for here? Are you saying that the
default is either "en" or another value agreed by both receiver and sender?
If this is what you intended, then I think the sentence starting with
"Otherwise" is not correct, as it will cause non interoperable behaviour.
I.e., if the default is not "en", the language tag has to be specified in
the JSON document.

      is expected that both receiver and sender have some external
      methods to agree upon the language used in this field.


_______________________________________________
mile mailing list
mile@ietf.org
https://www.ietf.org/mailman/listinfo/mile