Re: [MLS] Erik Kline's No Objection on draft-ietf-mls-protocol-17: (with COMMENT)
Erik Kline <ek.ietf@gmail.com> Tue, 31 January 2023 19:22 UTC
Return-Path: <ek.ietf@gmail.com>
X-Original-To: mls@ietfa.amsl.com
Delivered-To: mls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D752FC14CEFD; Tue, 31 Jan 2023 11:22:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EkuqwbAzF1fh; Tue, 31 Jan 2023 11:22:09 -0800 (PST)
Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5424CC14F726; Tue, 31 Jan 2023 11:22:09 -0800 (PST)
Received: by mail-vs1-xe2b.google.com with SMTP id e9so9342411vsj.3; Tue, 31 Jan 2023 11:22:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G82JWUEQyZSoyROZrIGHvrlwVB7DksbHRXOun/uQtDw=; b=popP7QmvTglBBSpSsqGCpv1p3vxXG8b5qDNBlKPOSKMzloysbPVUX+05hhfWRVXBJp CRrKuN3wKu2EkUtVhzuQT3StwkAhffFIC3eFn0pbIh6+xxUo9eR1ectKZYRzpGLDAUtC suS93vkfRrGPjXbpWrA35wGyGnWorHek14+DnTrs1c2v6k1U9q94IiMn1Uz0xx1nA6zM 8xItnhoviJ19+DGfXqo/Rd37Ne9I+NIvSL/HLeJod9mBl3BcnH/d5FnnMATuLCN7n1/J iziWGWWtcIJcwtjKGN1WdwxfzoGYVrxoKOXwbI8BOYU7h0Qmsg0SzF1R8QUKTfDs4oPX EmuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G82JWUEQyZSoyROZrIGHvrlwVB7DksbHRXOun/uQtDw=; b=BUGPT7daFzvBRr00tRlfDS9tvFv4ZH8fEWwGSk0NvCOpS5lIIsDu0Au6v7Czpgr3h7 ZWAECH93WUGy8HSVhqx5Y6D5+a+Ublk9rt/e9lz1DCqkXmavj9OXeSy1n0VQhjJZLaTc lo5DIJE6gc81MhZmbgA2zo4/yIiszrYef6JJZSMKud/9JGwY4Bdc0jtd8kLRYAZEaYWc UikQ3CfIxEZrLKbHbpbLAcu19CdEgK40fRGp+nWID/BK3ZwKJ/sj+PatJuncyo2P8DGa PrjIe43nght9OZXlROn9Q6coyMw99IBTj4HW66qjuhb0EAFAiFz/3n71LoRXrfxga2VP loWQ==
X-Gm-Message-State: AO0yUKWy2M4RmDKNxmFl18zFxEr90/30a415clBO6AAZqtMlL3DkAViW CZ4QQtCMMUPryXqoKgys3BLl10LbpK7FjfOIPhwH5obY0wE=
X-Google-Smtp-Source: AK7set/dOWhzL0D4RKWppGJPOLtOhfJFGpTRBq844Y+OabQOyn8flV+LDbi/EkP+SPEW7a5ZVjwCjxrDBVrSTRRliWA=
X-Received: by 2002:a67:e956:0:b0:3f7:8ffc:4ffb with SMTP id p22-20020a67e956000000b003f78ffc4ffbmr18234vso.24.1675192928380; Tue, 31 Jan 2023 11:22:08 -0800 (PST)
MIME-Version: 1.0
References: <167514991366.26632.7090779328804294577@ietfa.amsl.com> <CAL02cgSqHXwbg6KFCzEmTXzRAAUe495Lr8wx0kb+ZhU_kRz23g@mail.gmail.com> <CAL02cgTyB0-=mxsuSFhmy4B3tv3Pqogr92LZDtiMGSd+rSQxLQ@mail.gmail.com>
In-Reply-To: <CAL02cgTyB0-=mxsuSFhmy4B3tv3Pqogr92LZDtiMGSd+rSQxLQ@mail.gmail.com>
From: Erik Kline <ek.ietf@gmail.com>
Date: Tue, 31 Jan 2023 11:21:57 -0800
Message-ID: <CAMGpriWpFDQcRRY3nGOvOU_Ptrpo8XNCQD_b5hLcbF=hdNhnUg@mail.gmail.com>
To: Richard Barnes <rlb@ipv.sx>
Cc: The IESG <iesg@ietf.org>, mls@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/mls/Ql1H7dCTLx5IT2c7GCnro5ZumPI>
Subject: Re: [MLS] Erik Kline's No Objection on draft-ietf-mls-protocol-17: (with COMMENT)
X-BeenThere: mls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Messaging Layer Security <mls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mls>, <mailto:mls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mls/>
List-Post: <mailto:mls@ietf.org>
List-Help: <mailto:mls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mls>, <mailto:mls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2023 19:22:09 -0000
Thanks; LGTM On Tue, Jan 31, 2023 at 6:51 AM Richard Barnes <rlb@ipv.sx> wrote: > > I filed a PR for these changes: > > https://github.com/mlswg/mls-protocol/pull/849 > > On Tue, Jan 31, 2023 at 9:10 AM Richard Barnes <rlb@ipv.sx> wrote: >> >> Hi Erik, >> >> Thanks for the review. A couple responses inline below... >> >> On Tue, Jan 31, 2023 at 2:25 AM Erik Kline via Datatracker <noreply@ietf.org> wrote: >>> >>> ## Comments >>> >>> * Thank you very much for all of the explicitly worked examples. >> >> >> They were helpful in the WG discussions as well :) >> >> >>> ### S7.3 >>> >>> * What is the reason for MUST vs RECOMMENDED difference in the two different >>> circumstances when validating the `lifetime` field? >> >> >> The reason is asynchronicity. The protocol anticipates that there may be some time between when a message is sent and when it is received, during which time the KeyPackage might have expired. So the WG felt that having a hard requirement on the receive side would cause undue complexity in light of this requirement. >> >> >>> >>> * Consider adding a platitude about communicating nodes SHOULD use some >>> method of time synchronization... >> >> >> Good idea, thanks. >> >>> >>> ## Nits >>> >>> ### S3.2 >>> >>> * "top of these basic mechanism" -> "top of these basic mechanisms" >>> (or maybe "top of this basic mechanism") >>> >>> ### S6.3.1 >>> >>> * "in an PrivateContentTBE structure" -> "in a PrivateContentTBE structure" >> >> >> Can you tell we changed the names of these structs late in the process? :) >> >> Best, >> --Richard
- [MLS] Erik Kline's No Objection on draft-ietf-mls… Erik Kline via Datatracker
- Re: [MLS] Erik Kline's No Objection on draft-ietf… Richard Barnes
- Re: [MLS] Erik Kline's No Objection on draft-ietf… Erik Kline
- Re: [MLS] Erik Kline's No Objection on draft-ietf… Richard Barnes